diff mbox series

[v6,04/20] net: fec_mxc_init(): do not ignore return status of fec_open()

Message ID f85577564a96916e74a45b063429ebe15b2b0646.1722601509.git.jerome.forissier@linaro.org
State Superseded
Headers show
Series [v6,01/20] flash: prefix error codes with FL_ | expand

Commit Message

Jerome Forissier Aug. 2, 2024, 1:13 p.m. UTC 
The fec_mxc_init() function currently always returns 0. This does not
allow the callers to detect when for instance the PHY initialization
failed due to the port being unconnected. Fix that by returning the
status of fec_open().

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
---
 drivers/net/fec_mxc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index 0a0d92bc2cd..2dc1364beec 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -615,8 +615,7 @@  static int fecmxc_init(struct udevice *dev)
 	if (fec->xcv_type != SEVENWIRE)
 		miiphy_restart_aneg(dev);
 #endif
-	fec_open(dev);
-	return 0;
+	return fec_open(dev);
 }
 
 /**