diff mbox series

[06/12] selinux/genheaders: include bitsperlong and posix_types headers

Message ID 20240807-macos-build-support-v1-6-4cd1ded85694@samsung.com
State New
Headers show
Series Enable build system on macOS hosts | expand

Commit Message

Daniel Gomez via B4 Relay Aug. 6, 2024, 11:09 p.m. UTC
From: Daniel Gomez <da.gomez@samsung.com>

The genheaders requires the bitsperlong.h and posix_types.h headers.
To ensure these headers are found during compilation on macOS hosts,
add usr/include to HOST_EXTRACFLAGS in the genheaders Makefile. This
adjustment allows the compiler to locate all necessary headers when they
are not available by default on macOS.

Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
 scripts/selinux/genheaders/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Nicolas Schier Aug. 7, 2024, 3:38 p.m. UTC | #1
On Wed, Aug 07, 2024 at 01:09:20AM +0200, Daniel Gomez via B4 Relay wrote:
> From: Daniel Gomez <da.gomez@samsung.com>
> 
> The genheaders requires the bitsperlong.h and posix_types.h headers.
> To ensure these headers are found during compilation on macOS hosts,
> add usr/include to HOST_EXTRACFLAGS in the genheaders Makefile. This
> adjustment allows the compiler to locate all necessary headers when they
> are not available by default on macOS.
> 
> Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
> ---
>  scripts/selinux/genheaders/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/selinux/genheaders/Makefile b/scripts/selinux/genheaders/Makefile
> index 1faf7f07e8db..017149c90f8e 100644
> --- a/scripts/selinux/genheaders/Makefile
> +++ b/scripts/selinux/genheaders/Makefile
> @@ -2,4 +2,5 @@
>  hostprogs-always-y += genheaders
>  HOST_EXTRACFLAGS += \
>  	-I$(srctree)/include/uapi -I$(srctree)/include \
> -	-I$(srctree)/security/selinux/include
> +	-I$(srctree)/security/selinux/include \
> +	-I$(srctree)/usr/include

'make headers' composes the UAPI header tree in $(objtree)/usr/include.
So, if you build out-of-source, -I$(srctree)/usr/include will not match.
Just remove the '$(srctree)/' prefix as '$(objtree)/' is always '.'.

But I am suspecting that this break cross-building.

Kind regards,
Nicolas
diff mbox series

Patch

diff --git a/scripts/selinux/genheaders/Makefile b/scripts/selinux/genheaders/Makefile
index 1faf7f07e8db..017149c90f8e 100644
--- a/scripts/selinux/genheaders/Makefile
+++ b/scripts/selinux/genheaders/Makefile
@@ -2,4 +2,5 @@ 
 hostprogs-always-y += genheaders
 HOST_EXTRACFLAGS += \
 	-I$(srctree)/include/uapi -I$(srctree)/include \
-	-I$(srctree)/security/selinux/include
+	-I$(srctree)/security/selinux/include \
+	-I$(srctree)/usr/include