| Message ID | 20240808164132.81306-2-detlev.casanova@collabora.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add pinctrl support for rk3576 | expand |
On Thu, Aug 08, 2024 at 12:39:55PM -0400, Detlev Casanova wrote: > Add the compatible string as well as the optional rockchip,sys-grf field. Optional for all rockchip devices supported by this binding, or just the one you're adding? > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > --- > .../devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > index 20e806dce1ecb..cd527ccc9e6bf 100644 > --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > @@ -45,6 +45,7 @@ properties: > - rockchip,rk3368-pinctrl > - rockchip,rk3399-pinctrl > - rockchip,rk3568-pinctrl > + - rockchip,rk3576-pinctrl > - rockchip,rk3588-pinctrl > - rockchip,rv1108-pinctrl > - rockchip,rv1126-pinctrl > @@ -54,6 +55,12 @@ properties: > description: > The phandle of the syscon node for the GRF registers. > > + rockchip,sys-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + The phandle of the syscon node for the SYS GRF registers. > + It is used for i3c software controlled weak pull-up. > + > rockchip,pmu: > $ref: /schemas/types.yaml#/definitions/phandle > description: > -- > 2.46.0 >
On Friday, 9 August 2024 10:58:38 EDT Conor Dooley wrote: > On Thu, Aug 08, 2024 at 12:39:55PM -0400, Detlev Casanova wrote: > > Add the compatible string as well as the optional rockchip,sys-grf field. > > Optional for all rockchip devices supported by this binding, or just the > one you're adding? It is only optionally used by rk3576. I can add it in an 'if:', or update the description with somthing like "It is used on rk3576 for i3c software controlled weak pull-up" > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > > --- > > > > .../devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > > b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml index > > 20e806dce1ecb..cd527ccc9e6bf 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > > > > @@ -45,6 +45,7 @@ properties: > > - rockchip,rk3368-pinctrl > > - rockchip,rk3399-pinctrl > > - rockchip,rk3568-pinctrl > > > > + - rockchip,rk3576-pinctrl > > > > - rockchip,rk3588-pinctrl > > - rockchip,rv1108-pinctrl > > - rockchip,rv1126-pinctrl > > > > @@ -54,6 +55,12 @@ properties: > > description: > > The phandle of the syscon node for the GRF registers. > > > > + rockchip,sys-grf: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + The phandle of the syscon node for the SYS GRF registers. > > + It is used for i3c software controlled weak pull-up. > > + > > > > rockchip,pmu: > > $ref: /schemas/types.yaml#/definitions/phandle > > description:
On Fri, Aug 09, 2024 at 01:53:16PM -0400, Detlev Casanova wrote: > On Friday, 9 August 2024 10:58:38 EDT Conor Dooley wrote: > > On Thu, Aug 08, 2024 at 12:39:55PM -0400, Detlev Casanova wrote: > > > Add the compatible string as well as the optional rockchip,sys-grf field. > > > > Optional for all rockchip devices supported by this binding, or just the > > one you're adding? > > It is only optionally used by rk3576. I can add it in an 'if:', or update the > description with somthing like "It is used on rk3576 for i3c software > controlled weak pull-up" And if/else that restricts it to where it is available please. > > > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > > > --- > > > > > > .../devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > > > b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml index > > > 20e806dce1ecb..cd527ccc9e6bf 100644 > > > --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > > > +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml > > > > > > @@ -45,6 +45,7 @@ properties: > > > - rockchip,rk3368-pinctrl > > > - rockchip,rk3399-pinctrl > > > - rockchip,rk3568-pinctrl > > > > > > + - rockchip,rk3576-pinctrl > > > > > > - rockchip,rk3588-pinctrl > > > - rockchip,rv1108-pinctrl > > > - rockchip,rv1126-pinctrl > > > > > > @@ -54,6 +55,12 @@ properties: > > > description: > > > The phandle of the syscon node for the GRF registers. > > > > > > + rockchip,sys-grf: > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > + description: > > > + The phandle of the syscon node for the SYS GRF registers. > > > + It is used for i3c software controlled weak pull-up. > > > + > > > > > > rockchip,pmu: > > > $ref: /schemas/types.yaml#/definitions/phandle > > > description: > > > >
diff --git a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml index 20e806dce1ecb..cd527ccc9e6bf 100644 --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml @@ -45,6 +45,7 @@ properties: - rockchip,rk3368-pinctrl - rockchip,rk3399-pinctrl - rockchip,rk3568-pinctrl + - rockchip,rk3576-pinctrl - rockchip,rk3588-pinctrl - rockchip,rv1108-pinctrl - rockchip,rv1126-pinctrl @@ -54,6 +55,12 @@ properties: description: The phandle of the syscon node for the GRF registers. + rockchip,sys-grf: + $ref: /schemas/types.yaml#/definitions/phandle + description: + The phandle of the syscon node for the SYS GRF registers. + It is used for i3c software controlled weak pull-up. + rockchip,pmu: $ref: /schemas/types.yaml#/definitions/phandle description:
Add the compatible string as well as the optional rockchip,sys-grf field. Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> --- .../devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 7 +++++++ 1 file changed, 7 insertions(+)