diff mbox series

[v2] scsi: ufs: ufshcd-pltfrm: Use of_property_present()

Message ID 20240808170644.1436991-1-robh@kernel.org
State New
Headers show
Series [v2] scsi: ufs: ufshcd-pltfrm: Use of_property_present() | expand

Commit Message

Rob Herring (Arm) Aug. 8, 2024, 5:06 p.m. UTC
Use of_property_present() to test for property presence rather than
of_find_property(). This is part of a larger effort to remove callers
of of_find_property() and similar functions. of_find_property() leaks
the DT struct property and data pointers which is a problem for
dynamically allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
v2:
 - Update subject to include 'ufshcd-pltfrm'
---
 drivers/ufs/host/ufshcd-pltfrm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Bart Van Assche Aug. 8, 2024, 5:09 p.m. UTC | #1
On 8/8/24 10:06 AM, Rob Herring (Arm) wrote:
> Use of_property_present() to test for property presence rather than
> of_find_property(). This is part of a larger effort to remove callers
> of of_find_property() and similar functions. of_find_property() leaks
> the DT struct property and data pointers which is a problem for
> dynamically allocated nodes which may be freed.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Martin K. Petersen Aug. 12, 2024, 10:17 p.m. UTC | #2
Rob,

> Use of_property_present() to test for property presence rather than
> of_find_property(). This is part of a larger effort to remove callers
> of of_find_property() and similar functions. of_find_property() leaks
> the DT struct property and data pointers which is a problem for
> dynamically allocated nodes which may be freed.

Applied to 6.12/scsi-staging, thanks!
Martin K. Petersen Aug. 17, 2024, 1:38 a.m. UTC | #3
On Thu, 08 Aug 2024 11:06:44 -0600, Rob Herring (Arm) wrote:

> Use of_property_present() to test for property presence rather than
> of_find_property(). This is part of a larger effort to remove callers
> of of_find_property() and similar functions. of_find_property() leaks
> the DT struct property and data pointers which is a problem for
> dynamically allocated nodes which may be freed.
> 
> 
> [...]

Applied to 6.12/scsi-queue, thanks!

[1/1] scsi: ufs: ufshcd-pltfrm: Use of_property_present()
      https://git.kernel.org/mkp/scsi/c/fd9cb9615fca
diff mbox series

Patch

diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c
index a3e69ecafd27..2e1eb898a27c 100644
--- a/drivers/ufs/host/ufshcd-pltfrm.c
+++ b/drivers/ufs/host/ufshcd-pltfrm.c
@@ -272,10 +272,10 @@  static int ufshcd_parse_operating_points(struct ufs_hba *hba)
 	const char **clk_names;
 	int cnt, i, ret;
 
-	if (!of_find_property(np, "operating-points-v2", NULL))
+	if (!of_property_present(np, "operating-points-v2"))
 		return 0;
 
-	if (of_find_property(np, "freq-table-hz", NULL)) {
+	if (of_property_present(np, "freq-table-hz")) {
 		dev_err(dev, "%s: operating-points and freq-table-hz are incompatible\n",
 			 __func__);
 		return -EINVAL;