diff mbox series

[2/3] efi_loader: rename efi_bootmgr_image_return_notify

Message ID 20240812205638.1732159-2-ilias.apalodimas@linaro.org
State Accepted
Commit 4a1eeccde6cf4ba9111d0edcd5e36240091b385e
Headers show
Series [1/3] efi_loader: shorten efi_bootmgr_release_uridp_resource() | expand

Commit Message

Ilias Apalodimas Aug. 12, 2024, 8:56 p.m. UTC 
We use this event when returning from an EFI HTTP booted image.
The name is a bit confusing since it suggests we always run it,
rename it to make it clearer

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 lib/efi_loader/efi_bootmgr.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Simon Glass Sept. 1, 2024, 8:10 p.m. UTC | #1 
On Mon, 12 Aug 2024 at 14:56, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> We use this event when returning from an EFI HTTP booted image.
> The name is a bit confusing since it suggests we always run it,
> rename it to make it clearer
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
>  lib/efi_loader/efi_bootmgr.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c
index 181fc8775b96..03cdee15017d 100644
--- a/lib/efi_loader/efi_bootmgr.c
+++ b/lib/efi_loader/efi_bootmgr.c
@@ -421,13 +421,13 @@  efi_status_t efi_bootmgr_release_uridp(struct uridp_context *ctx)
 }
 
 /**
- * efi_bootmgr_image_return_notify() - return to efibootmgr callback
+ * efi_bootmgr_http_return() - return to efibootmgr callback
  *
  * @event:	the event for which this notification function is registered
  * @context:	event context
  */
-static void EFIAPI efi_bootmgr_image_return_notify(struct efi_event *event,
-						   void *context)
+static void EFIAPI efi_bootmgr_http_return(struct efi_event *event,
+					   void *context)
 {
 	efi_status_t ret;
 
@@ -533,7 +533,7 @@  static efi_status_t try_load_from_uri_path(struct efi_device_path_uri *uridp,
 
 	/* create event for cleanup when the image returns or error occurs */
 	ret = efi_create_event(EVT_NOTIFY_SIGNAL, TPL_CALLBACK,
-			       efi_bootmgr_image_return_notify, ctx,
+			       efi_bootmgr_http_return, ctx,
 			       &efi_guid_event_group_return_to_efibootmgr,
 			       &event);
 	if (ret != EFI_SUCCESS) {