| Message ID | 20240812144018.360847-1-Shyam-sundar.S-k@amd.com |
|---|---|
| State | Accepted |
| Commit | 8eea417b5748025d50fd537b224eb7be08e09dfb |
| Headers | show |
| Series | [v2] ACPI: APD: Add AMDI0015 as platform device | expand |
On Mon, Aug 12, 2024 at 08:10:18PM +0530, Shyam Sundar S K wrote: > Add AMDI0015 to the ACPI APD support list to ensure correct clock settings > for the I3C device on the latest AMD platforms. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> from the ACPI ID perspective.
On Mon, Aug 12, 2024 at 7:24 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Aug 12, 2024 at 08:10:18PM +0530, Shyam Sundar S K wrote: > > Add AMDI0015 to the ACPI APD support list to ensure correct clock settings > > for the I3C device on the latest AMD platforms. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > from the ACPI ID perspective. I've replaced the v1 that has been applied for some time already with this one, but please note that it still is not entirely clean. Namely, if there are two S-o-b targs on a patch, 2 cases are possible: (1) The person sending it is not its author and merely sends someone else's work adding an S-o-b to document a "supply chain link". In this case, the From: header should point to the original author (it can be added right before the changelog) and its value should match the other S-o-b tag exactly. (2) The person sending it is one of its authors. In this case, a Co-developed-by tag should be added to point to the other author and its value should match the other S-o-b tag exactly. I've assumed (2) and added "Co-developed-by: Sanket Goswami <Sanket.Goswami@amd.com>" to the commit, but that's not something I should be doing. Thanks!
On 8/20/2024 20:19, Rafael J. Wysocki wrote: > On Mon, Aug 12, 2024 at 7:24 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: >> >> On Mon, Aug 12, 2024 at 08:10:18PM +0530, Shyam Sundar S K wrote: >>> Add AMDI0015 to the ACPI APD support list to ensure correct clock settings >>> for the I3C device on the latest AMD platforms. >> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> from the ACPI ID perspective. > > I've replaced the v1 that has been applied for some time already with > this one, but please note that it still is not entirely clean. > > Namely, if there are two S-o-b targs on a patch, 2 cases are possible: > > (1) The person sending it is not its author and merely sends someone > else's work adding an S-o-b to document a "supply chain link". In > this case, the From: header should point to the original author (it > can be added right before the changelog) and its value should match > the other S-o-b tag exactly. > > (2) The person sending it is one of its authors. In this case, a > Co-developed-by tag should be added to point to the other author and > its value should match the other S-o-b tag exactly. > > I've assumed (2) and added "Co-developed-by: Sanket Goswami > <Sanket.Goswami@amd.com>" to the commit, but that's not something I > should be doing. Thanks! That was a miss. Co-developed-by: Sanket Goswami <Sanket.Goswami@amd.com> is the right tag. Thanks, Shyam > > Thanks!
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 80f945cbec8a..800f97868448 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -118,6 +118,11 @@ static const struct apd_device_desc wt_i2c_desc = { .fixed_clk_rate = 150000000, }; +static const struct apd_device_desc wt_i3c_desc = { + .setup = acpi_apd_setup, + .fixed_clk_rate = 125000000, +}; + static struct property_entry uart_properties[] = { PROPERTY_ENTRY_U32("reg-io-width", 4), PROPERTY_ENTRY_U32("reg-shift", 2), @@ -231,6 +236,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = { { "AMD0030", }, { "AMD0040", APD_ADDR(fch_misc_desc)}, { "AMDI0010", APD_ADDR(wt_i2c_desc) }, + { "AMDI0015", APD_ADDR(wt_i3c_desc) }, { "AMDI0019", APD_ADDR(wt_i2c_desc) }, { "AMDI0020", APD_ADDR(cz_uart_desc) }, { "AMDI0022", APD_ADDR(cz_uart_desc) },