diff mbox series

[v1,1/1] gpio: virtuser: Use GPIO_LOOKUP_IDX() macro

Message ID 20240820200858.3659995-1-andriy.shevchenko@linux.intel.com
State New
Headers show
Series [v1,1/1] gpio: virtuser: Use GPIO_LOOKUP_IDX() macro | expand

Commit Message

Andy Shevchenko Aug. 20, 2024, 8:08 p.m. UTC 
Use GPIO_LOOKUP_IDX() macro which provides a compound literal
and can be used with dynamic data.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-virtuser.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

Comments

Bartosz Golaszewski Aug. 21, 2024, 10:18 a.m. UTC | #1 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Tue, 20 Aug 2024 23:08:58 +0300, Andy Shevchenko wrote:
> Use GPIO_LOOKUP_IDX() macro which provides a compound literal
> and can be used with dynamic data.
> 
> 

Applied, thanks!

[1/1] gpio: virtuser: Use GPIO_LOOKUP_IDX() macro
      commit: 2a4727e6a8bd1d2b8ae7abf95061eda0457c4d79

Best regards,
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-virtuser.c b/drivers/gpio/gpio-virtuser.c
index ccc47ea0b3e1..91b6352c957c 100644
--- a/drivers/gpio/gpio-virtuser.c
+++ b/drivers/gpio/gpio-virtuser.c
@@ -1410,7 +1410,6 @@  gpio_virtuser_make_lookup_table(struct gpio_virtuser_device *dev)
 	size_t num_entries = gpio_virtuser_get_lookup_count(dev);
 	struct gpio_virtuser_lookup_entry *entry;
 	struct gpio_virtuser_lookup *lookup;
-	struct gpiod_lookup *curr;
 	unsigned int i = 0;
 
 	lockdep_assert_held(&dev->lock);
@@ -1426,14 +1425,10 @@  gpio_virtuser_make_lookup_table(struct gpio_virtuser_device *dev)
 
 	list_for_each_entry(lookup, &dev->lookup_list, siblings) {
 		list_for_each_entry(entry, &lookup->entry_list, siblings) {
-			curr = &table->table[i];
-
-			curr->con_id = lookup->con_id;
-			curr->idx = i;
-			curr->key = entry->key;
-			curr->chip_hwnum = entry->offset < 0 ?
-						U16_MAX : entry->offset;
-			curr->flags = entry->flags;
+			table->table[i] =
+				GPIO_LOOKUP_IDX(entry->key,
+						entry->offset < 0 ? U16_MAX : entry->offset,
+						lookup->con_id, i, entry->flags);
 			i++;
 		}
 	}