| Message ID | 20240820145623.3500864-20-avromanov@salutedevices.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Support more Amlogic SoC families in crypto driver | expand |
On Tue, Aug 20, 2024 at 05:56:19PM +0300, Alexey Romanov wrote: > GXL and newer SoC's uses the DMA engine (not blkmv) for crypto HW. > Crypto HW doesn't actually use the blkmv clk. At RTL level, crypto > engine is hard weired to clk81 (CLKID_CLK81). And remove clock-names > field: according to the new dt-binding, it is no longer required. Subject should be "arm64: dts: amlogic: ...". IIRC, Amlogic stuff has moved away from using "meson". > > Also, GXL crypto IP isn't to seconnd interrput line. So we must > remove it from dt-bindings. > > Fixes: c4a0457eb858 ("ARM64: dts: amlogic: adds crypto hardware node") > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > --- > arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > index 17bcfa4702e1..c29d5b81ce67 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > @@ -68,10 +68,8 @@ acodec: audio-controller@c8832000 { > crypto: crypto@c883e000 { > compatible = "amlogic,gxl-crypto"; > reg = <0x0 0xc883e000 0x0 0x36>; > - interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>, > - <GIC_SPI 189 IRQ_TYPE_EDGE_RISING>; > - clocks = <&clkc CLKID_BLKMV>; > - clock-names = "blkmv"; > + interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>; > + clocks = <&clkc CLKID_CLK81>; > status = "okay"; > }; > }; > -- > 2.34.1 >
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi index 17bcfa4702e1..c29d5b81ce67 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi @@ -68,10 +68,8 @@ acodec: audio-controller@c8832000 { crypto: crypto@c883e000 { compatible = "amlogic,gxl-crypto"; reg = <0x0 0xc883e000 0x0 0x36>; - interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>, - <GIC_SPI 189 IRQ_TYPE_EDGE_RISING>; - clocks = <&clkc CLKID_BLKMV>; - clock-names = "blkmv"; + interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>; + clocks = <&clkc CLKID_CLK81>; status = "okay"; }; };
GXL and newer SoC's uses the DMA engine (not blkmv) for crypto HW. Crypto HW doesn't actually use the blkmv clk. At RTL level, crypto engine is hard weired to clk81 (CLKID_CLK81). And remove clock-names field: according to the new dt-binding, it is no longer required. Also, GXL crypto IP isn't to seconnd interrput line. So we must remove it from dt-bindings. Fixes: c4a0457eb858 ("ARM64: dts: amlogic: adds crypto hardware node") Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)