| Message ID | 1479317491-7435-1-git-send-email-sudeep.holla@arm.com |
|---|---|
| State | New |
| Headers | show |
On 16/11/16 17:31, Sudeep Holla wrote: > From: Johan Hovold <johan@kernel.org> > > Make sure to drop the reference to the parent device taken by > class_find_device() after populating the bus. > > Fixes: 3b9334ac835b ("mfd: vexpress: Convert custom func API to regmap") > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > Signed-off-by: Johan Hovold <johan@kernel.org> > --- > drivers/bus/vexpress-config.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > Hi ARM-SoC team, > > I am not sure if these couple of patches can be considered as fixes for > v4.9. I will leave that to you guys. > > Can you pick these couple of patches directly either for v4.9 or v4.10 ? > I am trying to avoid single patch pull requests here. Let me know if > you prefer PR instead. > Gentle ping. It need not go into v4.9. Please pick them for v4.10 -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Wednesday, November 16, 2016 5:31:30 PM CET Sudeep Holla wrote: > From: Johan Hovold <johan@kernel.org> > > Make sure to drop the reference to the parent device taken by > class_find_device() after populating the bus. > > Fixes: 3b9334ac835b ("mfd: vexpress: Convert custom func API to regmap") > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > Signed-off-by: Johan Hovold <johan@kernel.org> > --- > drivers/bus/vexpress-config.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > Hi ARM-SoC team, > > I am not sure if these couple of patches can be considered as fixes for > v4.9. I will leave that to you guys. > > Can you pick these couple of patches directly either for v4.9 or v4.10 ? > I am trying to avoid single patch pull requests here. Let me know if > you prefer PR instead. > Sorry for the delay. I think it's find to wait till 4.10, so I've applied it to next/fixes-non-critical. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c index 9efdf1de4035..493e7b9fc813 100644 --- a/drivers/bus/vexpress-config.c +++ b/drivers/bus/vexpress-config.c @@ -171,6 +171,7 @@ static int vexpress_config_populate(struct device_node *node) { struct device_node *bridge; struct device *parent; + int ret; bridge = of_parse_phandle(node, "arm,vexpress,config-bridge", 0); if (!bridge) @@ -182,7 +183,11 @@ static int vexpress_config_populate(struct device_node *node) if (WARN_ON(!parent)) return -ENODEV; - return of_platform_populate(node, NULL, NULL, parent); + ret = of_platform_populate(node, NULL, NULL, parent); + + put_device(parent); + + return ret; } static int __init vexpress_config_init(void)