From patchwork Wed Nov 16 21:43:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evan Lloyd X-Patchwork-Id: 82620 Delivered-To: patch@linaro.org Received: by 10.182.1.168 with SMTP id 8csp487637obn; Wed, 16 Nov 2016 13:59:21 -0800 (PST) X-Received: by 10.55.3.67 with SMTP id 64mr6998025qkd.257.1479333561636; Wed, 16 Nov 2016 13:59:21 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id s65si22978107qkf.145.2016.11.16.13.59.21; Wed, 16 Nov 2016 13:59:21 -0800 (PST) Received-SPF: pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=linaro-uefi-bounces@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 2E93862DFC; Wed, 16 Nov 2016 21:59:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 367E360C61; Wed, 16 Nov 2016 21:59:18 +0000 (UTC) X-Original-To: linaro-uefi@lists.linaro.org Delivered-To: linaro-uefi@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 024F962DDD; Wed, 16 Nov 2016 21:43:18 +0000 (UTC) Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by lists.linaro.org (Postfix) with ESMTPS id DC21E62DD7 for ; Wed, 16 Nov 2016 21:43:17 +0000 (UTC) Received: from E107800.Emea.Arm.com (e107800.emea.arm.com [10.1.30.22]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id uAGLhFEJ005494; Wed, 16 Nov 2016 21:43:16 GMT From: evan.lloyd@arm.com To: linaro-uefi@lists.linaro.org Date: Wed, 16 Nov 2016 21:43:11 +0000 Message-Id: <20161116214311.12328-3-evan.lloyd@arm.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20161116214311.12328-1-evan.lloyd@arm.com> References: <20161116214311.12328-1-evan.lloyd@arm.com> Subject: [Linaro-uefi] [PATCH 2/2] Platforms/ARM/Juno: Fix Watchdog Timer interrupt mode X-BeenThere: linaro-uefi@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linaro-uefi-bounces@lists.linaro.org Sender: "Linaro-uefi" From: Girish Pathak The SBSA Generic Watchog Timer interrupt is edge triggered. However the interrupt setting in the GTDT ACPI table was not specified, defaulting to a level trigger interrupt. This patch configures the ACPI interrupt description as edge triggered. Change-Id: Id6767d318519da7e141a55b7bacd5ef291f0a9c9 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Girish Pathak Signed-off-by: Evan Lloyd --- Platforms/ARM/Juno/AcpiTables/Gtdt.aslc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc b/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc index afffd4ac8e92888a554f60dda926c64132976229..79675d37462b3827212eb66b700b00ac0e107665 100644 --- a/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc +++ b/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc @@ -94,12 +94,13 @@ GENERIC_TIMER_DESCRIPTION_TABLE Gtdt = { FixedPcdGet32 (PcdGenericWatchdogRefreshBase), FixedPcdGet32 (PcdGenericWatchdogControlBase), 93, - 0), + EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_TIMER_INTERRUPT_MODE), EFI_ACPI_5_1_SBSA_GENERIC_WATCHDOG_STRUCTURE_INIT ( FixedPcdGet32 (PcdGenericWatchdogRefreshBase), FixedPcdGet32 (PcdGenericWatchdogControlBase), 94, - EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_SECURE_TIMER) + (EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_SECURE_TIMER + | EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_TIMER_INTERRUPT_MODE)) } #endif };