diff mbox series

ACPI: video: Add force_vendor quirk for Panasonic Toughbook CF-18

Message ID 20240907124419.21195-1-hdegoede@redhat.com
State Accepted
Commit eb7b0f12e13ba99e64e3a690c2166895ed63b437
Headers show
Series ACPI: video: Add force_vendor quirk for Panasonic Toughbook CF-18 | expand

Commit Message

Hans de Goede Sept. 7, 2024, 12:44 p.m. UTC
The Panasonic Toughbook CF-18 advertises both native and vendor backlight
control interfaces. But only the vendor one actually works.

acpi_video_get_backlight_type() will pick the non working native backlight
by default, add a quirk to select the working vendor backlight instead.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/acpi/video_detect.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Rafael J. Wysocki Sept. 10, 2024, 6:16 p.m. UTC | #1
On Sat, Sep 7, 2024 at 2:44 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> The Panasonic Toughbook CF-18 advertises both native and vendor backlight
> control interfaces. But only the vendor one actually works.
>
> acpi_video_get_backlight_type() will pick the non working native backlight
> by default, add a quirk to select the working vendor backlight instead.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/acpi/video_detect.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index e33ab5a2f489..68afdab5d3ab 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -254,6 +254,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>                 DMI_MATCH(DMI_PRODUCT_NAME, "PCG-FRV35"),
>                 },
>         },
> +       {
> +        .callback = video_detect_force_vendor,
> +        /* Panasonic Toughbook CF-18 */
> +        .matches = {
> +               DMI_MATCH(DMI_SYS_VENDOR, "Matsushita Electric Industrial"),
> +               DMI_MATCH(DMI_PRODUCT_NAME, "CF-18"),
> +               },
> +       },
>
>         /*
>          * Toshiba models with Transflective display, these need to use
> --

Applied as 6.12 material, thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index e33ab5a2f489..68afdab5d3ab 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -254,6 +254,14 @@  static const struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "PCG-FRV35"),
 		},
 	},
+	{
+	 .callback = video_detect_force_vendor,
+	 /* Panasonic Toughbook CF-18 */
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Matsushita Electric Industrial"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "CF-18"),
+		},
+	},
 
 	/*
 	 * Toshiba models with Transflective display, these need to use