| Message ID | 20240913080325.3676181-4-trunixs.kim@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] dt-bindings: watchdog: Document ExynosAutoV920 watchdog bindings | expand |
On 13/09/2024 10:03, Taewan Kim wrote: > From: Byoungtae Cho <bt.cho@samsung.com> > > Adds two watchdog devices for ExynosAutoV920 SoC. > > Signed-off-by: Byoungtae Cho <bt.cho@samsung.com> > Signed-off-by: Taewan Kim <trunixs.kim@samsung.com> > --- > .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > index c1c8566d74f5..de210f8e5599 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > @@ -297,6 +297,26 @@ pinctrl_aud: pinctrl@1a460000 { > compatible = "samsung,exynosautov920-pinctrl"; > reg = <0x1a460000 0x10000>; > }; > + > + watchdog_cl0: watchdog@10060000 { Does not look like placed in correct location. 1a46 > 1006. Please follow DTS coding style in all your works. Best regards, Krzysztof
Hi, I will move it between 'chipid@10000000' and 'interrupt-controller@10400000'. Thank you for pointing. Best regards, Taewan Kim. > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Monday, September 30, 2024 8:38 PM > To: Taewan Kim <trunixs.kim@samsung.com>; Wim Van Sebroeck <wim@linux- > watchdog.org>; Guenter Roeck <linux@roeck-us.net>; Rob Herring > <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > <conor+dt@kernel.org>; Alim Akhtar <alim.akhtar@samsung.com> > Cc: linux-watchdog@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; Byoungtae Cho <bt.cho@samsung.com> > Subject: Re: [PATCH 3/3] arm64: dts: exynosautov920: add watchdog DT node > > On 13/09/2024 10:03, Taewan Kim wrote: > > From: Byoungtae Cho <bt.cho@samsung.com> > > > > Adds two watchdog devices for ExynosAutoV920 SoC. > > > > Signed-off-by: Byoungtae Cho <bt.cho@samsung.com> > > Signed-off-by: Taewan Kim <trunixs.kim@samsung.com> > > --- > > .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 > > +++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > > b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > > index c1c8566d74f5..de210f8e5599 100644 > > --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > > +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > > @@ -297,6 +297,26 @@ pinctrl_aud: pinctrl@1a460000 { > > compatible = "samsung,exynosautov920-pinctrl"; > > reg = <0x1a460000 0x10000>; > > }; > > + > > + watchdog_cl0: watchdog@10060000 { > > Does not look like placed in correct location. 1a46 > 1006. Please follow > DTS coding style in all your works. > > Best regards, > Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi index c1c8566d74f5..de210f8e5599 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi @@ -297,6 +297,26 @@ pinctrl_aud: pinctrl@1a460000 { compatible = "samsung,exynosautov920-pinctrl"; reg = <0x1a460000 0x10000>; }; + + watchdog_cl0: watchdog@10060000 { + compatible = "samsung,exynosautov920-wdt"; + reg = <0x10060000 0x100>; + interrupts = <GIC_SPI 953 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&xtcxo>, <&xtcxo>; + clock-names = "watchdog", "watchdog_src"; + samsung,syscon-phandle = <&pmu_system_controller>; + samsung,cluster-index = <0>; + }; + + watchdog_cl1: watchdog@10070000 { + compatible = "samsung,exynosautov920-wdt"; + reg = <0x10070000 0x100>; + interrupts = <GIC_SPI 952 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&xtcxo>, <&xtcxo>; + clock-names = "watchdog", "watchdog_src"; + samsung,syscon-phandle = <&pmu_system_controller>; + samsung,cluster-index = <1>; + }; }; timer {