| Message ID | 20240923115516.3563029-1-ruanjinjie@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | spi: rockchip: Fix excessive check for get_fifo_len() | expand |
On Mon, Sep 23, 2024 at 07:55:16PM +0800, Jinjie Ruan wrote: > Since commit 13a96935e6f6 ("spi: rockchip: Support 64-location deep > FIFOs"), get_fifo_len() return 64 or 32, never return 0, so remove > the excessive check in rockchip_spi_probe(). > > Fixes: 13a96935e6f6 ("spi: rockchip: Support 64-location deep FIFOs") This is clearly not a bug fix, it's at most a code cleanup but... > @@ -819,11 +819,6 @@ static int rockchip_spi_probe(struct platform_device *pdev) > } > > rs->fifo_len = get_fifo_len(rs); > - if (!rs->fifo_len) { > - dev_err(&pdev->dev, "Failed to get fifo length\n"); > - ret = -EINVAL; > - goto err_put_ctlr; > - } ...given that the probe() path isn't exactly a hot path is there really any benefit from this, if someone does add the option of returning 0 it'll silently break.
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 0bb33c43b1b4..680fe6ef6acc 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -819,11 +819,6 @@ static int rockchip_spi_probe(struct platform_device *pdev) } rs->fifo_len = get_fifo_len(rs); - if (!rs->fifo_len) { - dev_err(&pdev->dev, "Failed to get fifo length\n"); - ret = -EINVAL; - goto err_put_ctlr; - } pm_runtime_set_autosuspend_delay(&pdev->dev, ROCKCHIP_AUTOSUSPEND_TIMEOUT); pm_runtime_use_autosuspend(&pdev->dev);
Since commit 13a96935e6f6 ("spi: rockchip: Support 64-location deep FIFOs"), get_fifo_len() return 64 or 32, never return 0, so remove the excessive check in rockchip_spi_probe(). Fixes: 13a96935e6f6 ("spi: rockchip: Support 64-location deep FIFOs") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- drivers/spi/spi-rockchip.c | 5 ----- 1 file changed, 5 deletions(-)