| Message ID | 20240923034250.3008055-1-ruanjinjie@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | i2c: xiic: Fix pm_runtime_set_suspended() with runtime pm enabled | expand |
Hi Jinjie, On Mon, Sep 23, 2024 at 11:42:50AM GMT, Jinjie Ruan wrote: > It is not valid to call pm_runtime_set_suspended() for devices > with runtime PM enabled because it returns -EAGAIN if it is enabled > already and working. So, call pm_runtime_disable() before to fix it. > > Fixes: 36ecbcab84d0 ("i2c: xiic: Implement power management") > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > --- > drivers/i2c/busses/i2c-xiic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c > index 4c89aad02451..1d68177241a6 100644 > --- a/drivers/i2c/busses/i2c-xiic.c > +++ b/drivers/i2c/busses/i2c-xiic.c > @@ -1337,8 +1337,8 @@ static int xiic_i2c_probe(struct platform_device *pdev) > return 0; > > err_pm_disable: > - pm_runtime_set_suspended(&pdev->dev); > pm_runtime_disable(&pdev->dev); > + pm_runtime_set_suspended(&pdev->dev); Good catch Jinjie! Applied to i2c/i2c-host-fixes. Thanks, Andi > > return ret; > } > -- > 2.34.1 >
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 4c89aad02451..1d68177241a6 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1337,8 +1337,8 @@ static int xiic_i2c_probe(struct platform_device *pdev) return 0; err_pm_disable: - pm_runtime_set_suspended(&pdev->dev); pm_runtime_disable(&pdev->dev); + pm_runtime_set_suspended(&pdev->dev); return ret; }
It is not valid to call pm_runtime_set_suspended() for devices with runtime PM enabled because it returns -EAGAIN if it is enabled already and working. So, call pm_runtime_disable() before to fix it. Fixes: 36ecbcab84d0 ("i2c: xiic: Implement power management") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- drivers/i2c/busses/i2c-xiic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)