| Message ID | 20240930070015.28244-1-philmd@linaro.org |
|---|---|
| State | Accepted |
| Commit | f2a9c31dbba2976796c0391dc7426238e798c644 |
| Headers | show |
| Series | hw/mips: Build fw_cfg.c once | expand |
On 30/09/2024 09.00, Philippe Mathieu-Daudé wrote: > Nothing in fw_cfg.c requires target-specific knowledge, > build it once for the 4 MIPS variants. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > hw/mips/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/mips/meson.build b/hw/mips/meson.build > index ca37c42d90..fcbee53bb3 100644 > --- a/hw/mips/meson.build > +++ b/hw/mips/meson.build > @@ -1,6 +1,6 @@ > mips_ss = ss.source_set() > mips_ss.add(files('bootloader.c', 'mips_int.c')) > -mips_ss.add(when: 'CONFIG_FW_CFG_MIPS', if_true: files('fw_cfg.c')) > +common_ss.add(when: 'CONFIG_FW_CFG_MIPS', if_true: files('fw_cfg.c')) > mips_ss.add(when: 'CONFIG_LOONGSON3V', if_true: files('loongson3_bootp.c', 'loongson3_virt.c')) > mips_ss.add(when: 'CONFIG_MALTA', if_true: files('malta.c')) > mips_ss.add(when: 'CONFIG_MIPS_CPS', if_true: files('cps.c')) Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/hw/mips/meson.build b/hw/mips/meson.build index ca37c42d90..fcbee53bb3 100644 --- a/hw/mips/meson.build +++ b/hw/mips/meson.build @@ -1,6 +1,6 @@ mips_ss = ss.source_set() mips_ss.add(files('bootloader.c', 'mips_int.c')) -mips_ss.add(when: 'CONFIG_FW_CFG_MIPS', if_true: files('fw_cfg.c')) +common_ss.add(when: 'CONFIG_FW_CFG_MIPS', if_true: files('fw_cfg.c')) mips_ss.add(when: 'CONFIG_LOONGSON3V', if_true: files('loongson3_bootp.c', 'loongson3_virt.c')) mips_ss.add(when: 'CONFIG_MALTA', if_true: files('malta.c')) mips_ss.add(when: 'CONFIG_MIPS_CPS', if_true: files('cps.c'))
Nothing in fw_cfg.c requires target-specific knowledge, build it once for the 4 MIPS variants. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/mips/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)