| Message ID | 2495061.jE0xQCEvom@rjwysocki.net |
|---|---|
| State | New |
| Headers | show |
| Series | thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit | expand |
On 10/4/24 20:35, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > After previous changes, the need_update field in struct thermal_zone_device > is only set and never read, so drop it. > > No functional impact. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > > This is a new iteration of > > https://lore.kernel.org/linux-pm/3261209.5fSG56mABF@rjwysocki.net/ > > v1 -> v2: Rebase. > > --- > drivers/thermal/thermal_core.c | 4 ---- > drivers/thermal/thermal_core.h | 2 -- > 2 files changed, 6 deletions(-) > > Index: linux-pm/drivers/thermal/thermal_core.c > =================================================================== > --- linux-pm.orig/drivers/thermal/thermal_core.c > +++ linux-pm/drivers/thermal/thermal_core.c > @@ -840,7 +840,6 @@ static int thermal_bind_cdev_to_trip(str > if (!result) { > list_add_tail(&dev->tz_node, &tz->thermal_instances); > list_add_tail(&dev->cdev_node, &cdev->thermal_instances); > - atomic_set(&tz->need_update, 1); > > thermal_governor_update_tz(tz, THERMAL_TZ_BIND_CDEV); > } > @@ -1505,9 +1504,6 @@ thermal_zone_device_register_with_trips( > if (result) > goto remove_id; > > - /* A new thermal zone needs to be updated anyway. */ > - atomic_set(&tz->need_update, 1); > - > result = dev_set_name(&tz->device, "thermal_zone%d", tz->id); > if (result) { > thermal_zone_destroy_device_groups(tz); > Index: linux-pm/drivers/thermal/thermal_core.h > =================================================================== > --- linux-pm.orig/drivers/thermal/thermal_core.h > +++ linux-pm/drivers/thermal/thermal_core.h > @@ -95,7 +95,6 @@ struct thermal_governor { > trip point. > * @prev_high_trip: the above current temperature if you've crossed a > passive trip point. > - * @need_update: if equals 1, thermal_zone_device_update needs to be invoked. > * @ops: operations this &thermal_zone_device supports > * @tzp: thermal zone parameters > * @governor: pointer to the governor for this thermal zone > @@ -129,7 +128,6 @@ struct thermal_zone_device { > int passive; > int prev_low_trip; > int prev_high_trip; > - atomic_t need_update; > struct thermal_zone_device_ops ops; > struct thermal_zone_params *tzp; > struct thermal_governor *governor; > > > Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Index: linux-pm/drivers/thermal/thermal_core.c =================================================================== --- linux-pm.orig/drivers/thermal/thermal_core.c +++ linux-pm/drivers/thermal/thermal_core.c @@ -840,7 +840,6 @@ static int thermal_bind_cdev_to_trip(str if (!result) { list_add_tail(&dev->tz_node, &tz->thermal_instances); list_add_tail(&dev->cdev_node, &cdev->thermal_instances); - atomic_set(&tz->need_update, 1); thermal_governor_update_tz(tz, THERMAL_TZ_BIND_CDEV); } @@ -1505,9 +1504,6 @@ thermal_zone_device_register_with_trips( if (result) goto remove_id; - /* A new thermal zone needs to be updated anyway. */ - atomic_set(&tz->need_update, 1); - result = dev_set_name(&tz->device, "thermal_zone%d", tz->id); if (result) { thermal_zone_destroy_device_groups(tz); Index: linux-pm/drivers/thermal/thermal_core.h =================================================================== --- linux-pm.orig/drivers/thermal/thermal_core.h +++ linux-pm/drivers/thermal/thermal_core.h @@ -95,7 +95,6 @@ struct thermal_governor { trip point. * @prev_high_trip: the above current temperature if you've crossed a passive trip point. - * @need_update: if equals 1, thermal_zone_device_update needs to be invoked. * @ops: operations this &thermal_zone_device supports * @tzp: thermal zone parameters * @governor: pointer to the governor for this thermal zone @@ -129,7 +128,6 @@ struct thermal_zone_device { int passive; int prev_low_trip; int prev_high_trip; - atomic_t need_update; struct thermal_zone_device_ops ops; struct thermal_zone_params *tzp; struct thermal_governor *governor;