| Message ID | 20241004-venus_sc7280-v1-1-4d7d8fd7e95b@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: sc7280: enable venus node | expand |
Hi Luca, On 11/12/2024 8:49 PM, Luca Weiss wrote: > Hi Vedang, > > On Tue Nov 12, 2024 at 3:39 PM CET, Vedang Nagar wrote: >> >> >> On 11/12/2024 6:43 PM, Dmitry Baryshkov wrote: >>> On Tue, 12 Nov 2024 at 08:17, Vedang Nagar <quic_vnagar@quicinc.com> wrote: >>>> >>>> >>>> >>>> On 10/7/2024 1:20 AM, Dmitry Baryshkov wrote: >>>>> On Fri, Oct 04, 2024 at 04:22:31PM GMT, Vedang Nagar wrote: >>>>>> Enable the venus node on Qualcomm sc7280. It was made disabled >>>>>> earlier to avoid bootup crash, which is fixed now with [1]. >>>>> >>>>> NAK, there might be other reasons to keep venus disabled, like the lack >>>>> of the vendor-signed firmware for the particular device. >>>> Can you pls elaborate more on this? Any device with sc7280 SOC can use >>>> venus.mbn which is already present in linux-firmware git. >>> >>> Can it though if the device is fused to use vendor keys and to check >>> the trust chain? >> Yes, infact the existing ones are signed and works with trustzone authentication. > > No, the venus firmware from linux-firmware does not work on a device > with secure boot on, like the (QCM6490) Fairphone 5 smartphone. Are you saying even after applying this [1] you are seeing the same ? [1] https://patchwork.kernel.org/project/linux-media/patch/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/ > > $ rm /lib/firmware/qcom/qcm6490/fairphone5/venus.mbn > $ cp /lib/firmware/qcom/vpu-2.0/venus.mbn.zst /lib/firmware/qcom/qcm6490/fairphone5/venus.mbn.zst > > leads to > > [ 10.848191] qcom-venus aa00000.video-codec: Adding to iommu group 13 > [ 10.863062] qcom-venus aa00000.video-codec: non legacy binding > [ 10.909555] qcom-venus aa00000.video-codec: error -22 initializing firmware qcom/qcm6490/fairphone5/venus.mbn > [ 10.910099] qcom-venus aa00000.video-codec: fail to load video firmware > [ 10.910849] qcom-venus aa00000.video-codec: probe with driver qcom-venus failed with error -22 > > It's the same with e.g. adsp firmware, modem firmware, etc. > > With secure boot off, yes, the hardware will load any firmware > regardless of the signature. > > Regards > Luca > >>> >>>> >>>> Regards, >>>> Vedang Nagar >>>>> >>>>>> >>>>>> [1] >>>>>> https://lore.kernel.org/linux-media/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/ >>>>>> >>>>>> Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com> >>>>>> --- >>>>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 -- >>>>>> 1 file changed, 2 deletions(-) >>>>> >>> >>> >>> >
On Tue, Jan 07, 2025 at 09:41:56AM +0530, Vedang Nagar wrote: > Hi Luca, > > On 11/13/2024 1:33 PM, Luca Weiss wrote: > > Hi Vedang, > > > > On Wed Nov 13, 2024 at 8:01 AM CET, Vedang Nagar wrote: > >> Hi Luca, > >> On 11/12/2024 8:49 PM, Luca Weiss wrote: > >>> Hi Vedang, > >>> > >>> On Tue Nov 12, 2024 at 3:39 PM CET, Vedang Nagar wrote: > >>>> > >>>> > >>>> On 11/12/2024 6:43 PM, Dmitry Baryshkov wrote: > >>>>> On Tue, 12 Nov 2024 at 08:17, Vedang Nagar <quic_vnagar@quicinc.com> wrote: > >>>>>> > >>>>>> > >>>>>> > >>>>>> On 10/7/2024 1:20 AM, Dmitry Baryshkov wrote: > >>>>>>> On Fri, Oct 04, 2024 at 04:22:31PM GMT, Vedang Nagar wrote: > >>>>>>>> Enable the venus node on Qualcomm sc7280. It was made disabled > >>>>>>>> earlier to avoid bootup crash, which is fixed now with [1]. > >>>>>>> > >>>>>>> NAK, there might be other reasons to keep venus disabled, like the lack > >>>>>>> of the vendor-signed firmware for the particular device. > >>>>>> Can you pls elaborate more on this? Any device with sc7280 SOC can use > >>>>>> venus.mbn which is already present in linux-firmware git. > >>>>> > >>>>> Can it though if the device is fused to use vendor keys and to check > >>>>> the trust chain? > >>>> Yes, infact the existing ones are signed and works with trustzone authentication. > >>> > >>> No, the venus firmware from linux-firmware does not work on a device > >>> with secure boot on, like the (QCM6490) Fairphone 5 smartphone. > >> Are you saying even after applying this [1] you are seeing the same ? > >> > >> [1] > >> https://patchwork.kernel.org/project/linux-media/patch/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/ > > > > That patch has been in mainline since v6.9 and my tree is newer, so yes. > > > > See e.g. Qualcomm doc KBA-161204232438 for some details. > > > > Regards > > Luca > > > >>> > >>> $ rm /lib/firmware/qcom/qcm6490/fairphone5/venus.mbn > >>> $ cp /lib/firmware/qcom/vpu-2.0/venus.mbn.zst /lib/firmware/qcom/qcm6490/fairphone5/venus.mbn.zst > >>> > >>> leads to > >>> > >>> [ 10.848191] qcom-venus aa00000.video-codec: Adding to iommu group 13 > >>> [ 10.863062] qcom-venus aa00000.video-codec: non legacy binding > >>> [ 10.909555] qcom-venus aa00000.video-codec: error -22 initializing firmware qcom/qcm6490/fairphone5/venus.mbn > >>> [ 10.910099] qcom-venus aa00000.video-codec: fail to load video firmware > >>> [ 10.910849] qcom-venus aa00000.video-codec: probe with driver qcom-venus failed with error -22 > >>> > We have seen similar issue with older firmware present in > linux-firmware git due to a bug in singing of the firmware image. > > This issue seems to be resolved with below change: > aeede7afb7a186b62f9e1f959c33fd5f2dea0f7a: qcom: update venus firmware file for SC7280 > > Can you pls give a try with latest firmware if you still see the same issue? > We tried internally and do not see any such failure now. Have you been trying it on the FP5 (or any other vendor-fused device) or on the RB3gen2, fused to accept any CA key? > > Regards, > Vedang Nagar > > >>> It's the same with e.g. adsp firmware, modem firmware, etc. > >>> > >>> With secure boot off, yes, the hardware will load any firmware > >>> regardless of the signature. > >>> > >>> Regards > >>> Luca > >>> > >>>>> > >>>>>> > >>>>>> Regards, > >>>>>> Vedang Nagar > >>>>>>> > >>>>>>>> > >>>>>>>> [1] > >>>>>>>> https://lore.kernel.org/linux-media/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/ > >>>>>>>> > >>>>>>>> Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com> > >>>>>>>> --- > >>>>>>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 -- > >>>>>>>> 1 file changed, 2 deletions(-) > >>>>>>> > >>>>> > >>>>> > >>>>> > >>> >
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 3d8410683402fd4c03c5c2951721938fff20fc77..59dafbeeab1dfd6e1b021335ba1b04767d6c24e5 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -4288,8 +4288,6 @@ venus: video-codec@aa00000 { iommus = <&apps_smmu 0x2180 0x20>; memory-region = <&video_mem>; - status = "disabled"; - video-decoder { compatible = "venus-decoder"; };
Enable the venus node on Qualcomm sc7280. It was made disabled earlier to avoid bootup crash, which is fixed now with [1]. [1] https://lore.kernel.org/linux-media/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/ Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 -- 1 file changed, 2 deletions(-) --- base-commit: 81ee62e8d09ee3c7107d11c8bbfd64073ab601ad change-id: 20241003-venus_sc7280-642a6b81afe1 prerequisite-change-id: 20240913-qcm6490-clock-configs-0239f30babb5:v1 prerequisite-patch-id: faac726ebdf08240ab0913132beb2c620e52a98a Best regards,