diff mbox series

[libgpiod,2/3] dbus: client: notify: free chip and line lists at exit

Message ID 20241007-dbus-memory-fixes-v1-2-0d56d1aa032d@linaro.org
State New
Headers show
Series dbus: client: fix memory leaks and errors | expand

Commit Message

Bartosz Golaszewski Oct. 7, 2024, 7:30 p.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

We don't free the lists storing line and chip objects for the duration
of the program when exiting. Fix it.

Note: these objects need to be kept alive for D-Bus events to work.

Fixes: a5ab76da1e0a ("dbus: add the D-Bus daemon, command-line client and tests")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 dbus/client/notify.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/dbus/client/notify.c b/dbus/client/notify.c
index 6d51a6f..800dd24 100644
--- a/dbus/client/notify.c
+++ b/dbus/client/notify.c
@@ -289,6 +289,8 @@  int gpiocli_notify_main(int argc, char **argv)
 
 	g_main_loop_run(loop);
 
+	g_list_free_full(data.lines, g_object_unref);
+	g_list_free_full(data.chips, g_object_unref);
 	g_bus_unwatch_name(watch_id);
 
 	return EXIT_SUCCESS;