diff mbox series

kselftest/arm64: Ensure stable names for GCS stress test results

Message ID 20241011-arm64-gcs-stress-stable-name-v1-1-4950f226218e@kernel.org
State New
Headers show
Series kselftest/arm64: Ensure stable names for GCS stress test results | expand

Commit Message

Mark Brown Oct. 11, 2024, 2:36 p.m. UTC
The GCS stress test program currently uses the PID of the threads it
creates in the test names it reports, resulting in unstable test names
between runs. Fix this by using a thread number instead.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 tools/testing/selftests/arm64/gcs/gcs-stress.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


---
base-commit: bb9ae1a66c85eeb626864efd812c62026e126ec0
change-id: 20241011-arm64-gcs-stress-stable-name-8550519fe152

Best regards,

Comments

Catalin Marinas Oct. 16, 2024, 4:30 p.m. UTC | #1
On Fri, 11 Oct 2024 15:36:25 +0100, Mark Brown wrote:
> The GCS stress test program currently uses the PID of the threads it
> creates in the test names it reports, resulting in unstable test names
> between runs. Fix this by using a thread number instead.
> 
> 

Applied to arm64 (for-next/gcs), thanks!

[1/1] kselftest/arm64: Ensure stable names for GCS stress test results
      https://git.kernel.org/arm64/c/9b9be7825851
diff mbox series

Patch

diff --git a/tools/testing/selftests/arm64/gcs/gcs-stress.c b/tools/testing/selftests/arm64/gcs/gcs-stress.c
index bdec7ee8cfd5..03222c36c436 100644
--- a/tools/testing/selftests/arm64/gcs/gcs-stress.c
+++ b/tools/testing/selftests/arm64/gcs/gcs-stress.c
@@ -56,7 +56,7 @@  static int num_processors(void)
 	return nproc;
 }
 
-static void start_thread(struct child_data *child)
+static void start_thread(struct child_data *child, int id)
 {
 	int ret, pipefd[2], i;
 	struct epoll_event ev;
@@ -132,7 +132,7 @@  static void start_thread(struct child_data *child)
 		ev.events = EPOLLIN | EPOLLHUP;
 		ev.data.ptr = child;
 
-		ret = asprintf(&child->name, "Thread-%d", child->pid);
+		ret = asprintf(&child->name, "Thread-%d", id);
 		if (ret == -1)
 			ksft_exit_fail_msg("asprintf() failed\n");
 
@@ -437,7 +437,7 @@  int main(int argc, char **argv)
 				   tests);
 
 	for (i = 0; i < gcs_threads; i++)
-		start_thread(&children[i]);
+		start_thread(&children[i], i);
 
 	/*
 	 * All children started, close the startup pipe and let them