| Message ID | 20241013105522.391414-9-sughosh.ganu@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Make EFI memory allocations synchronous with LMB | expand |
On Sun, 13 Oct 2024 at 04:56, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > The efi_add_known_memory() function for the TI K3 platforms is adding > the EFI_CONVENTIONAL_MEMORY type. This memory is now being handled > through the LMB module -- the lmb_add_memory() adds this memory to the > memory map. Remove the definition of the now superfluous > efi_add_known_memory() function. > > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > --- > Changes since V2: None > > arch/arm/mach-k3/common.c | 11 ----------- > 1 file changed, 11 deletions(-) I agree we should not have these calls sprinkled throughout U-Boot. In fact let's make efi_add_memory_map() static at some point! Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c index df48ec8d47..f2086cbdf5 100644 --- a/arch/arm/mach-k3/common.c +++ b/arch/arm/mach-k3/common.c @@ -310,14 +310,3 @@ void setup_qos(void) writel(qos_data[i].val, (uintptr_t)qos_data[i].reg); } #endif - -void efi_add_known_memory(void) -{ - if (IS_ENABLED(CONFIG_EFI_LOADER)) - /* - * Memory over ram_top can be used by various firmware - * Declare to EFI only memory area below ram_top - */ - efi_add_memory_map(gd->ram_base, gd->ram_top - gd->ram_base, - EFI_CONVENTIONAL_MEMORY); -}