diff mbox series

[v2,1/6] dt-bindings: arm: cpus: Add Samsung Mongoose M5

Message ID 20241015210205.963931-2-igor.belwon@mentallysanemainliners.org
State Superseded
Headers show
Series Add minimal Exynos990 SoC and SM-N981B support | expand

Commit Message

Igor Belwon Oct. 15, 2024, 9:02 p.m. UTC 
Add a compatible for the Samsung Mongoose M5 cores, found in
the Exynos 990.

Signed-off-by: Igor Belwon <igor.belwon@mentallysanemainliners.org>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/arm/cpus.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Oct. 16, 2024, 6:17 a.m. UTC | #1 
On 15/10/2024 23:02, Igor Belwon wrote:
> Add a compatible for the Samsung Mongoose M5 cores, found in
> the Exynos 990.
> 
> Signed-off-by: Igor Belwon <igor.belwon@mentallysanemainliners.org>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>

I am not going to review untested code, sorry.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
index e41a8aec6066..c54d20dd9d7e 100644
--- a/Documentation/devicetree/bindings/arm/cpus.yaml
+++ b/Documentation/devicetree/bindings/arm/cpus.yaml
@@ -207,6 +207,7 @@  properties:
       - qcom,oryon
       - qcom,scorpion
       - samsung,mongoose-m2
+      - samsung,mongoose-m5
 
   enable-method:
     $ref: /schemas/types.yaml#/definitions/string