diff mbox series

[-next,1/2] selftests:timers: remove unneeded semicolon

Message ID 20241017062737.98466-1-jiapeng.chong@linux.alibaba.com
State Superseded
Headers show
Series [-next,1/2] selftests:timers: remove unneeded semicolon | expand

Commit Message

Jiapeng Chong Oct. 17, 2024, 6:27 a.m. UTC
No functional modification involved.

./tools/testing/selftests/timers/nanosleep.c:63:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11407
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 tools/testing/selftests/timers/nanosleep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shuah Khan Oct. 17, 2024, 3:43 p.m. UTC | #1
On 10/17/24 00:27, Jiapeng Chong wrote:
> No functional modification involved.

Please include the report details in the change log
> 
> ./tools/testing/selftests/timers/nanosleep.c:63:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11407
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   tools/testing/selftests/timers/nanosleep.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c
> index 252c6308c569..36f9b97f232a 100644
> --- a/tools/testing/selftests/timers/nanosleep.c
> +++ b/tools/testing/selftests/timers/nanosleep.c
> @@ -60,7 +60,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   

thanks,
-- Shuah
Shuah Khan Oct. 17, 2024, 3:45 p.m. UTC | #2
On 10/17/24 00:27, Jiapeng Chong wrote:
> No functional modification involved.
> 
> ./tools/testing/selftests/timers/nsleep-lat.c:62:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11406
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   tools/testing/selftests/timers/nsleep-lat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/timers/nsleep-lat.c b/tools/testing/selftests/timers/nsleep-lat.c
> index de23dc0c9f97..6f7f7d682439 100644
> --- a/tools/testing/selftests/timers/nsleep-lat.c
> +++ b/tools/testing/selftests/timers/nsleep-lat.c
> @@ -59,7 +59,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   

This is the same change. same comment on this one too.
I am working on deleting the duplicate code and there
is no need to make these changes.

thanks,
-- Shuah
diff mbox series

Patch

diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c
index 252c6308c569..36f9b97f232a 100644
--- a/tools/testing/selftests/timers/nanosleep.c
+++ b/tools/testing/selftests/timers/nanosleep.c
@@ -60,7 +60,7 @@  char *clockstring(int clockid)
 		return "CLOCK_BOOTTIME_ALARM";
 	case CLOCK_TAI:
 		return "CLOCK_TAI";
-	};
+	}
 	return "UNKNOWN_CLOCKID";
 }