| Message ID | 20241017-lg-gram-pro-keyboard-v2-1-7c8fbf6ff718@heusel.eu |
|---|---|
| State | Accepted |
| Commit | 53f1a907d36fb3aa02a4d34073bcec25823a6c74 |
| Headers | show |
| Series | [v2] ACPI: resource: Add LG 16T90SP to irq1_level_low_skip_override[] | expand |
On Thu, Oct 17, 2024 at 1:16 PM Christian Heusel <christian@heusel.eu> wrote: > > The LG Gram Pro 16 2-in-1 (2024) the 16T90SP has its keybopard IRQ (1) > described as ActiveLow in the DSDT, which the kernel overrides to EdgeHigh > which breaks the keyboard. > > Add the 16T90SP to the irq1_level_low_skip_override[] quirk table to fix > this. > > Reported-by: Dirk Holten <dirk.holten@gmx.de> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219382 > Cc: stable@vger.kernel.org > Suggested-by: Dirk Holten <dirk.holten@gmx.de> > Signed-off-by: Christian Heusel <christian@heusel.eu> > --- > Note that I do not have the relevant hardware since I'm sending in this > quirk at the request of someone else. > --- > Changes in v2: > - fix the double initialization warning reported by the kernel test > robot, which accidentially overwrote another quirk Applied as 6.12-rc material, thanks! > - Link to v1: https://lore.kernel.org/r/20241016-lg-gram-pro-keyboard-v1-1-34306123102f@heusel.eu > --- > drivers/acpi/resource.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c > index 129bceb1f4a27df93439bcefdb27fd9c91258028..7fe842dae1ec05ce6726af2ae4fcc8eff3698dcb 100644 > --- a/drivers/acpi/resource.c > +++ b/drivers/acpi/resource.c > @@ -503,6 +503,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { > DMI_MATCH(DMI_BOARD_NAME, "17U70P"), > }, > }, > + { > + /* LG Electronics 16T90SP */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"), > + DMI_MATCH(DMI_BOARD_NAME, "16T90SP"), > + }, > + }, > { } > }; > > > --- > base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354 > change-id: 20241016-lg-gram-pro-keyboard-9a9d8b9aa647 > > Best regards, > -- > Christian Heusel <christian@heusel.eu> >
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 129bceb1f4a27df93439bcefdb27fd9c91258028..7fe842dae1ec05ce6726af2ae4fcc8eff3698dcb 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -503,6 +503,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { DMI_MATCH(DMI_BOARD_NAME, "17U70P"), }, }, + { + /* LG Electronics 16T90SP */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"), + DMI_MATCH(DMI_BOARD_NAME, "16T90SP"), + }, + }, { } };
The LG Gram Pro 16 2-in-1 (2024) the 16T90SP has its keybopard IRQ (1) described as ActiveLow in the DSDT, which the kernel overrides to EdgeHigh which breaks the keyboard. Add the 16T90SP to the irq1_level_low_skip_override[] quirk table to fix this. Reported-by: Dirk Holten <dirk.holten@gmx.de> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219382 Cc: stable@vger.kernel.org Suggested-by: Dirk Holten <dirk.holten@gmx.de> Signed-off-by: Christian Heusel <christian@heusel.eu> --- Note that I do not have the relevant hardware since I'm sending in this quirk at the request of someone else. --- Changes in v2: - fix the double initialization warning reported by the kernel test robot, which accidentially overwrote another quirk - Link to v1: https://lore.kernel.org/r/20241016-lg-gram-pro-keyboard-v1-1-34306123102f@heusel.eu --- drivers/acpi/resource.c | 7 +++++++ 1 file changed, 7 insertions(+) --- base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354 change-id: 20241016-lg-gram-pro-keyboard-9a9d8b9aa647 Best regards, -- Christian Heusel <christian@heusel.eu>