diff mbox

[oe,2/4] meta-oe: add explicit dependencies on gnome-common

Message ID 1479910421-28750-2-git-send-email-ross.burton@intel.com
State Accepted
Commit 533826b7652a2cf86ca7b665c25b98c89afc266e
Headers show

Commit Message

Ross Burton Nov. 23, 2016, 2:13 p.m. UTC
gnome-common is deprecated and gnomebase.bbclass will soon stop depending on it,
so add gnome-common to DEPENDS for the recipes that still use it.

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta-oe/recipes-devtools/python/python-pygobject_3.20.1.bb | 3 +--
 meta-oe/recipes-extended/libgxim/libgxim_0.5.0.bb          | 2 +-
 meta-oe/recipes-gnome/vte9/vte9.inc                        | 3 +--
 3 files changed, 3 insertions(+), 5 deletions(-)

-- 
2.8.1

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Martin Jansa Nov. 26, 2016, 12:11 a.m. UTC | #1
On Wed, Nov 23, 2016 at 02:13:39PM +0000, Ross Burton wrote:
> gnome-common is deprecated and gnomebase.bbclass will soon stop depending on it,

> so add gnome-common to DEPENDS for the recipes that still use it.


Doesn't it cause libgxim failure reported here?
http://lists.openembedded.org/pipermail/openembedded-devel/2016-November/110050.html

> Signed-off-by: Ross Burton <ross.burton@intel.com>

> ---

>  meta-oe/recipes-devtools/python/python-pygobject_3.20.1.bb | 3 +--

>  meta-oe/recipes-extended/libgxim/libgxim_0.5.0.bb          | 2 +-

>  meta-oe/recipes-gnome/vte9/vte9.inc                        | 3 +--

>  3 files changed, 3 insertions(+), 5 deletions(-)

> 

> diff --git a/meta-oe/recipes-devtools/python/python-pygobject_3.20.1.bb b/meta-oe/recipes-devtools/python/python-pygobject_3.20.1.bb

> index 77416d4..e490ae5 100644

> --- a/meta-oe/recipes-devtools/python/python-pygobject_3.20.1.bb

> +++ b/meta-oe/recipes-devtools/python/python-pygobject_3.20.1.bb

> @@ -8,7 +8,7 @@ inherit autotools pkgconfig gnomebase distutils-base gobject-introspection

>  PYTHON_BASEVERSION = "2.7"

>  PYTHON_PN = "python"

>  

> -DEPENDS += "python glib-2.0"

> +DEPENDS += "gnome-common-native python glib-2.0"

>  

>  SRCNAME="pygobject"

>  SRC_URI = " \

> @@ -31,4 +31,3 @@ do_install_append() {

>      # Remove files that clash with python3-pygobject; their content is same

>      rm ${D}${includedir}/pygobject-3.0/pygobject.h ${D}${libdir}/pkgconfig/pygobject-3.0.pc

>  }

> -

> diff --git a/meta-oe/recipes-extended/libgxim/libgxim_0.5.0.bb b/meta-oe/recipes-extended/libgxim/libgxim_0.5.0.bb

> index 772babf..1d5ae95 100644

> --- a/meta-oe/recipes-extended/libgxim/libgxim_0.5.0.bb

> +++ b/meta-oe/recipes-extended/libgxim/libgxim_0.5.0.bb

> @@ -20,6 +20,6 @@ LIC_FILES_CHKSUM = "\

>  file://COPYING;md5=2d5025d4aa3495befef8f17206a5b0a1"

>  

>  EXTRA_OECONF = " --disable-static --disable-rebuilds"

> -DEPENDS += "gtk+ glib-2.0 ruby-native intltool-native"

> +DEPENDS += "gtk+ glib-2.0 ruby-native intltool-native gnome-common-native"

>  

>  inherit autotools pkgconfig gettext

> diff --git a/meta-oe/recipes-gnome/vte9/vte9.inc b/meta-oe/recipes-gnome/vte9/vte9.inc

> index 6a5c63c..206c430 100644

> --- a/meta-oe/recipes-gnome/vte9/vte9.inc

> +++ b/meta-oe/recipes-gnome/vte9/vte9.inc

> @@ -1,7 +1,7 @@

>  SUMMARY = "Virtual terminal emulator GTK+ widget library"

>  BUGTRACKER = "https://bugzilla.gnome.org/buglist.cgi?product=vte"

>  LICENSE = "LGPLv2.0"

> -DEPENDS = " glib-2.0 gtk+ intltool-native ncurses"

> +DEPENDS = " glib-2.0 gtk+ intltool-native gnome-common-native ncurses"

>  RDEPENDS_libvte = "vte-termcap"

>  

>  # help gnomebase get the SRC_URI correct

> @@ -16,4 +16,3 @@ EXTRA_OECONF = "--disable-python"

>  PACKAGES =+ "libvte9 vte9-termcap"

>  FILES_libvte9 = "${libdir}/*.so.* ${libexecdir}/gnome-pty-helper"

>  FILES_vte9-termcap = "${datadir}/vte/termcap-0.0"

> -

> -- 

> 2.8.1

> 

> -- 

> _______________________________________________

> Openembedded-devel mailing list

> Openembedded-devel@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Ross Burton Nov. 28, 2016, 3:58 p.m. UTC | #2
On 26 November 2016 at 00:11, Martin Jansa <martin.jansa@gmail.com> wrote:

> Doesn't it cause libgxim failure reported here?

> http://lists.openembedded.org/pipermail/openembedded-devel/

> 2016-November/110050.html

>


In a sense, because the configure would have been throwing errors silently
that gnome-comon wasn't present.

Sent a v2 incorporating a change to disable the fatal warnings in gxim.

Ross
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
diff mbox

Patch

diff --git a/meta-oe/recipes-devtools/python/python-pygobject_3.20.1.bb b/meta-oe/recipes-devtools/python/python-pygobject_3.20.1.bb
index 77416d4..e490ae5 100644
--- a/meta-oe/recipes-devtools/python/python-pygobject_3.20.1.bb
+++ b/meta-oe/recipes-devtools/python/python-pygobject_3.20.1.bb
@@ -8,7 +8,7 @@  inherit autotools pkgconfig gnomebase distutils-base gobject-introspection
 PYTHON_BASEVERSION = "2.7"
 PYTHON_PN = "python"
 
-DEPENDS += "python glib-2.0"
+DEPENDS += "gnome-common-native python glib-2.0"
 
 SRCNAME="pygobject"
 SRC_URI = " \
@@ -31,4 +31,3 @@  do_install_append() {
     # Remove files that clash with python3-pygobject; their content is same
     rm ${D}${includedir}/pygobject-3.0/pygobject.h ${D}${libdir}/pkgconfig/pygobject-3.0.pc
 }
-
diff --git a/meta-oe/recipes-extended/libgxim/libgxim_0.5.0.bb b/meta-oe/recipes-extended/libgxim/libgxim_0.5.0.bb
index 772babf..1d5ae95 100644
--- a/meta-oe/recipes-extended/libgxim/libgxim_0.5.0.bb
+++ b/meta-oe/recipes-extended/libgxim/libgxim_0.5.0.bb
@@ -20,6 +20,6 @@  LIC_FILES_CHKSUM = "\
 file://COPYING;md5=2d5025d4aa3495befef8f17206a5b0a1"
 
 EXTRA_OECONF = " --disable-static --disable-rebuilds"
-DEPENDS += "gtk+ glib-2.0 ruby-native intltool-native"
+DEPENDS += "gtk+ glib-2.0 ruby-native intltool-native gnome-common-native"
 
 inherit autotools pkgconfig gettext
diff --git a/meta-oe/recipes-gnome/vte9/vte9.inc b/meta-oe/recipes-gnome/vte9/vte9.inc
index 6a5c63c..206c430 100644
--- a/meta-oe/recipes-gnome/vte9/vte9.inc
+++ b/meta-oe/recipes-gnome/vte9/vte9.inc
@@ -1,7 +1,7 @@ 
 SUMMARY = "Virtual terminal emulator GTK+ widget library"
 BUGTRACKER = "https://bugzilla.gnome.org/buglist.cgi?product=vte"
 LICENSE = "LGPLv2.0"
-DEPENDS = " glib-2.0 gtk+ intltool-native ncurses"
+DEPENDS = " glib-2.0 gtk+ intltool-native gnome-common-native ncurses"
 RDEPENDS_libvte = "vte-termcap"
 
 # help gnomebase get the SRC_URI correct
@@ -16,4 +16,3 @@  EXTRA_OECONF = "--disable-python"
 PACKAGES =+ "libvte9 vte9-termcap"
 FILES_libvte9 = "${libdir}/*.so.* ${libexecdir}/gnome-pty-helper"
 FILES_vte9-termcap = "${datadir}/vte/termcap-0.0"
-