diff mbox series

[1/2] crypto: tegra - remove unneeded crypto_engine_stop() call

Message ID 20241020192532.4008-1-ovidiu.panait.oss@gmail.com
State Accepted
Commit 6ef46fec4171433fd9a3162b88ec2ce808676193
Headers show
Series [1/2] crypto: tegra - remove unneeded crypto_engine_stop() call | expand

Commit Message

Ovidiu Panait Oct. 20, 2024, 7:25 p.m. UTC
The explicit crypto_engine_stop() call is not needed, as it is already
called internally by crypto_engine_exit().

Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
---
Cc: Akhil R <akhilrajeev@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org

 drivers/crypto/tegra/tegra-se-main.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Thierry Reding Oct. 24, 2024, 5:30 p.m. UTC | #1
On Sun, Oct 20, 2024 at 10:25:31PM +0300, Ovidiu Panait wrote:
> The explicit crypto_engine_stop() call is not needed, as it is already
> called internally by crypto_engine_exit().
> 
> Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
> ---
> Cc: Akhil R <akhilrajeev@nvidia.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: linux-tegra@vger.kernel.org
> 
>  drivers/crypto/tegra/tegra-se-main.c | 2 --
>  1 file changed, 2 deletions(-)

Acked-by: Thierry Reding <treding@nvidia.com>
Herbert Xu Oct. 26, 2024, 7:04 a.m. UTC | #2
On Sun, Oct 20, 2024 at 10:25:31PM +0300, Ovidiu Panait wrote:
> The explicit crypto_engine_stop() call is not needed, as it is already
> called internally by crypto_engine_exit().
> 
> Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
> ---
> Cc: Akhil R <akhilrajeev@nvidia.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: linux-tegra@vger.kernel.org
> 
>  drivers/crypto/tegra/tegra-se-main.c | 2 --
>  1 file changed, 2 deletions(-)

All applied.  Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/tegra/tegra-se-main.c b/drivers/crypto/tegra/tegra-se-main.c
index f94c0331b148..af11a0b5194d 100644
--- a/drivers/crypto/tegra/tegra-se-main.c
+++ b/drivers/crypto/tegra/tegra-se-main.c
@@ -312,7 +312,6 @@  static int tegra_se_probe(struct platform_device *pdev)
 
 	ret = tegra_se_host1x_register(se);
 	if (ret) {
-		crypto_engine_stop(se->engine);
 		crypto_engine_exit(se->engine);
 		return dev_err_probe(dev, ret, "failed to init host1x params\n");
 	}
@@ -324,7 +323,6 @@  static void tegra_se_remove(struct platform_device *pdev)
 {
 	struct tegra_se *se = platform_get_drvdata(pdev);
 
-	crypto_engine_stop(se->engine);
 	crypto_engine_exit(se->engine);
 	host1x_client_unregister(&se->client);
 }