diff mbox series

[v2] obex: Resolve SRM issue for PTS testcases

Message ID 20241022102222.279614-1-quic_amisjain@quicinc.com
State Superseded
Headers show
Series [v2] obex: Resolve SRM issue for PTS testcases | expand

Commit Message

Amisha Jain Oct. 22, 2024, 10:22 a.m. UTC 
Add check for unknown/undefined srm value.

This fix is required to pass the below the PTS testcases :
1. OPP/SR/GOEP/SRM/BI-02-C
2. FTP/SR/GOEP/SRM/BI-02-C
3. PBAP/PSE/GOEP/SRM/BI-05-C

Description - Verify that the Server ignores a SRM header with an
invalid value in the PUT/GET request and carries on with the
PUT/GET operation with SRM disabled.

Current Behaviour - Server is sending SRM enable in the response even
though receiving the unknown SRM value.

To fix this, I have added the check to verify the valid SRM values
before continuing with SRM enable.

---
 gobex/gobex.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

bluez.test.bot@gmail.com Oct. 22, 2024, 12:07 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=901785

---Test result---

Test Summary:
CheckPatch                    PASS      0.39 seconds
GitLint                       PASS      0.28 seconds
BuildEll                      PASS      25.15 seconds
BluezMake                     PASS      1662.17 seconds
MakeCheck                     PASS      13.12 seconds
MakeDistcheck                 PASS      181.06 seconds
CheckValgrind                 PASS      255.14 seconds
CheckSmatch                   PASS      358.32 seconds
bluezmakeextell               PASS      120.60 seconds
IncrementalBuild              PASS      1454.48 seconds
ScanBuild                     PASS      1047.25 seconds



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/gobex/gobex.c b/gobex/gobex.c
index 40d6b8129..e072205ea 100644
--- a/gobex/gobex.c
+++ b/gobex/gobex.c
@@ -317,6 +317,10 @@  static void set_srm(GObex *obex, guint8 op, guint8 srm)
 	struct srm_config *config = obex->srm;
 	gboolean enable;
 
+	if (srm != G_OBEX_SRM_DISABLE && srm != G_OBEX_SRM_ENABLE
+			&& srm != G_OBEX_SRM_INDICATE)
+		return; //unknown srm value
+
 	if (config == NULL) {
 		if (srm == G_OBEX_SRM_DISABLE)
 			return;