| Message ID | 20241025161501.485684-24-miquel.raynal@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | spi-nand/spi-mem DTR support | expand |
On 10/25/24 5:15 PM, Miquel Raynal wrote: > Make the link between the core macros and the datasheet. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/mtd/nand/spi/winbond.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c > index 686e872fe0ff..9e2562805d23 100644 > --- a/drivers/mtd/nand/spi/winbond.c > +++ b/drivers/mtd/nand/spi/winbond.c > @@ -18,6 +18,11 @@ > > #define W25N04KV_STATUS_ECC_5_8_BITFLIPS (3 << 4) > > +/* > + * "X2" in the core is equivalent to "dual output" in the datasheets, > + * "X4" in the core is equivalent to "quad output" in the datasheets. > + */ doesn't help great for an outsider like me. Is quad referring to cmd, addr or data? Or maybe of all? I need to read the code anyway. > + > static SPINAND_OP_VARIANTS(read_cache_dtr_variants, > SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), > SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0),
On 11/11/24 2:38 PM, Tudor Ambarus wrote: > > > On 10/25/24 5:15 PM, Miquel Raynal wrote: >> Make the link between the core macros and the datasheet. >> >> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> >> --- >> drivers/mtd/nand/spi/winbond.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c >> index 686e872fe0ff..9e2562805d23 100644 >> --- a/drivers/mtd/nand/spi/winbond.c >> +++ b/drivers/mtd/nand/spi/winbond.c >> @@ -18,6 +18,11 @@ >> >> #define W25N04KV_STATUS_ECC_5_8_BITFLIPS (3 << 4) >> >> +/* >> + * "X2" in the core is equivalent to "dual output" in the datasheets, >> + * "X4" in the core is equivalent to "quad output" in the datasheets. >> + */ > > doesn't help great for an outsider like me. Is quad referring to cmd, > addr or data? Or maybe of all? I need to read the code anyway. more straight forward would be to use the X-Y-Z terminology in the comment, where X,Y and Z are the number of IO lines for cmd, address and data. >> + >> static SPINAND_OP_VARIANTS(read_cache_dtr_variants, >> SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), >> SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0),
diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c index 686e872fe0ff..9e2562805d23 100644 --- a/drivers/mtd/nand/spi/winbond.c +++ b/drivers/mtd/nand/spi/winbond.c @@ -18,6 +18,11 @@ #define W25N04KV_STATUS_ECC_5_8_BITFLIPS (3 << 4) +/* + * "X2" in the core is equivalent to "dual output" in the datasheets, + * "X4" in the core is equivalent to "quad output" in the datasheets. + */ + static SPINAND_OP_VARIANTS(read_cache_dtr_variants, SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0),
Make the link between the core macros and the datasheet. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/spi/winbond.c | 5 +++++ 1 file changed, 5 insertions(+)