| Message ID | 20241026073734.102723-1-ilias.apalodimas@linaro.org |
|---|---|
| State | Accepted |
| Commit | b63cb21221a4f032f9ae7491ff9ff7891a8d3e00 |
| Headers | show |
| Series | efi_loader: Mark efi_bootmgr_release_uridp as static | expand |
On 10/26/24 09:37, Ilias Apalodimas wrote: > This is only used locally so make it static > > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > --- > lib/efi_loader/efi_bootmgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c > index a3aa2b8d1b92..f9b5988a06ea 100644 > --- a/lib/efi_loader/efi_bootmgr.c > +++ b/lib/efi_loader/efi_bootmgr.c > @@ -385,7 +385,7 @@ err: > * @ctx: event context > * Return: status code > */ > -efi_status_t efi_bootmgr_release_uridp(struct uridp_context *ctx) > +static efi_status_t efi_bootmgr_release_uridp(struct uridp_context *ctx) > { > efi_status_t ret = EFI_SUCCESS; > efi_status_t ret2 = EFI_SUCCESS; Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
On Sat, Oct 26, 2024 at 10:37:32AM +0300, Ilias Apalodimas wrote: > This is only used locally so make it static Missing period at the end. Otherwise LGTM, Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c index a3aa2b8d1b92..f9b5988a06ea 100644 --- a/lib/efi_loader/efi_bootmgr.c +++ b/lib/efi_loader/efi_bootmgr.c @@ -385,7 +385,7 @@ err: * @ctx: event context * Return: status code */ -efi_status_t efi_bootmgr_release_uridp(struct uridp_context *ctx) +static efi_status_t efi_bootmgr_release_uridp(struct uridp_context *ctx) { efi_status_t ret = EFI_SUCCESS; efi_status_t ret2 = EFI_SUCCESS;
This is only used locally so make it static Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> --- lib/efi_loader/efi_bootmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)