| Message ID | 20241029225632.3019083-3-tomm.merciai@gmail.com |
|---|---|
| State | Accepted |
| Commit | eaf296205c61ac2d4024ff7816517c35a6056d78 |
| Headers | show |
| Series | media: i2c: Drop HAS_EVENTS and event handlers | expand |
On Tue, Oct 29, 2024 at 11:56:31PM +0100, Tommaso Merciai wrote: > v4l2_subdev_init_finalize() already sets the HAS_EVENTS flag if a > control handler is set. Let's drop the HAS_EVENTS flag. > > Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/imx415.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c > index a20b0db330d3..3f7924aa1bd3 100644 > --- a/drivers/media/i2c/imx415.c > +++ b/drivers/media/i2c/imx415.c > @@ -1113,8 +1113,7 @@ static int imx415_subdev_init(struct imx415 *sensor) > if (ret) > return ret; > > - sensor->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | > - V4L2_SUBDEV_FL_HAS_EVENTS; > + sensor->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > sensor->pad.flags = MEDIA_PAD_FL_SOURCE; > sensor->subdev.entity.function = MEDIA_ENT_F_CAM_SENSOR; > ret = media_entity_pads_init(&sensor->subdev.entity, 1, &sensor->pad);
Hi all, Sorry for the recent HTML mail. Let's try again -- hopefully it works now. On 10/29/24 23:56, Tommaso Merciai wrote: > v4l2_subdev_init_finalize() already sets the HAS_EVENTS flag if a > control handler is set. Let's drop the HAS_EVENTS flag. > > Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Thanks for the patch. Acked-by: Michael Riesch <michael.riesch@wolfvision.net> Best regards, Michael > --- > drivers/media/i2c/imx415.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c > index a20b0db330d3..3f7924aa1bd3 100644 > --- a/drivers/media/i2c/imx415.c > +++ b/drivers/media/i2c/imx415.c > @@ -1113,8 +1113,7 @@ static int imx415_subdev_init(struct imx415 *sensor) > if (ret) > return ret; > > - sensor->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | > - V4L2_SUBDEV_FL_HAS_EVENTS; > + sensor->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > sensor->pad.flags = MEDIA_PAD_FL_SOURCE; > sensor->subdev.entity.function = MEDIA_ENT_F_CAM_SENSOR; > ret = media_entity_pads_init(&sensor->subdev.entity, 1, &sensor->pad);
diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c index a20b0db330d3..3f7924aa1bd3 100644 --- a/drivers/media/i2c/imx415.c +++ b/drivers/media/i2c/imx415.c @@ -1113,8 +1113,7 @@ static int imx415_subdev_init(struct imx415 *sensor) if (ret) return ret; - sensor->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | - V4L2_SUBDEV_FL_HAS_EVENTS; + sensor->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; sensor->pad.flags = MEDIA_PAD_FL_SOURCE; sensor->subdev.entity.function = MEDIA_ENT_F_CAM_SENSOR; ret = media_entity_pads_init(&sensor->subdev.entity, 1, &sensor->pad);
v4l2_subdev_init_finalize() already sets the HAS_EVENTS flag if a control handler is set. Let's drop the HAS_EVENTS flag. Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> --- drivers/media/i2c/imx415.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)