[v5,09/10] scsi: add support for user-meta interface

Message ID	20241029162402.21400-10-anuj20.g@samsung.com
State	New
Headers	show Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21AC020606D for <linux-scsi@vger.kernel.org>; Tue, 29 Oct 2024 17:25:48 +0000 (UTC) From: Anuj Gupta <anuj20.g@samsung.com> To: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org, martin.petersen@oracle.com, asml.silence@gmail.com, anuj1072538@gmail.com, brauner@kernel.org, jack@suse.cz, viro@zeniv.linux.org.uk Cc: io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, gost.dev@samsung.com, linux-scsi@vger.kernel.org, vishak.g@samsung.com, linux-fsdevel@vger.kernel.org, Anuj Gupta <anuj20.g@samsung.com> Subject: [PATCH v5 09/10] scsi: add support for user-meta interface Date: Tue, 29 Oct 2024 21:54:01 +0530 Message-Id: <20241029162402.21400-10-anuj20.g@samsung.com> In-Reply-To: <20241029162402.21400-1-anuj20.g@samsung.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P DLP-Filter: Pass References: <20241029162402.21400-1-anuj20.g@samsung.com> <CGME20241029163233epcas5p497b3c81dcdf3c691a6f9c461bf0da7ac@epcas5p4.samsung.com>
Series	Read/Write with meta/integrity \| expand [v5,00/10] Read/Write with meta/integrity [v5,01/10] block: define set of integrity flags to be inherited by cloned bip [v5,02/10] block: copy back bounce buffer to user-space correctly in case of split [v5,03/10] block: modify bio_integrity_map_user to accept iov_iter as argument [v5,04/10] fs, iov_iter: define meta io descriptor [v5,05/10] fs: introduce IOCB_HAS_METADATA for metadata [v5,06/10] io_uring/rw: add support to send metadata along with read/write [v5,07/10] block: introduce BIP_CHECK_GUARD/REFTAG/APPTAG bip_flags [v5,08/10] nvme: add support for passing on the application tag [v5,09/10] scsi: add support for user-meta interface [v5,10/10] block: add support to pass user meta buffer

Message ID

20241029162402.21400-10-anuj20.g@samsung.com

State

New

Headers

From: Anuj Gupta <anuj20.g@samsung.com>
To: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
	martin.petersen@oracle.com, asml.silence@gmail.com, anuj1072538@gmail.com,
	brauner@kernel.org, jack@suse.cz, viro@zeniv.linux.org.uk
Cc: io-uring@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-block@vger.kernel.org, gost.dev@samsung.com,
	linux-scsi@vger.kernel.org, vishak.g@samsung.com,
	linux-fsdevel@vger.kernel.org, Anuj Gupta <anuj20.g@samsung.com>
Subject: [PATCH v5 09/10] scsi: add support for user-meta interface
Date: Tue, 29 Oct 2024 21:54:01 +0530
Message-Id: <20241029162402.21400-10-anuj20.g@samsung.com>
In-Reply-To: <20241029162402.21400-1-anuj20.g@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20241029162402.21400-1-anuj20.g@samsung.com>
	<CGME20241029163233epcas5p497b3c81dcdf3c691a6f9c461bf0da7ac@epcas5p4.samsung.com>

Series

Read/Write with meta/integrity | expand

Add support for sending user-meta buffer. Set tags to be checked using flags specified by user/block-layer. Signed-off-by: Anuj Gupta <anuj20.g@samsung.com> --- drivers/scsi/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Christoph Hellwig Oct. 30, 2024, 5:10 a.m. UTC | #1

On Tue, Oct 29, 2024 at 09:54:01PM +0530, Anuj Gupta wrote:
> Add support for sending user-meta buffer. Set tags to be checked
> using flags specified by user/block-layer.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

> -		if (bio_integrity_flagged(bio, BIP_CTRL_NOCHECK) == false)
> +		if (bio_integrity_flagged(bio, BIP_CHECK_GUARD))
>  			scmd->prot_flags |= SCSI_PROT_GUARD_CHECK;
>  	}
>  
>  	if (dif != T10_PI_TYPE3_PROTECTION) {	/* DIX/DIF Type 0, 1, 2 */
>  		scmd->prot_flags |= SCSI_PROT_REF_INCREMENT;
>  
> -		if (bio_integrity_flagged(bio, BIP_CTRL_NOCHECK) == false)
> +		if (bio_integrity_flagged(bio, BIP_CHECK_REFTAG))

BIP_CTRL_NOCHECK is unused now, and should probably go away.

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index ca4bc0ac76ad..d1a2ae0d4c29 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -814,14 +814,14 @@  static unsigned char sd_setup_protect_cmnd(struct scsi_cmnd *scmd,
 		if (bio_integrity_flagged(bio, BIP_IP_CHECKSUM))
 			scmd->prot_flags |= SCSI_PROT_IP_CHECKSUM;
 
-		if (bio_integrity_flagged(bio, BIP_CTRL_NOCHECK) == false)
+		if (bio_integrity_flagged(bio, BIP_CHECK_GUARD))
 			scmd->prot_flags |= SCSI_PROT_GUARD_CHECK;
 	}
 
 	if (dif != T10_PI_TYPE3_PROTECTION) {	/* DIX/DIF Type 0, 1, 2 */
 		scmd->prot_flags |= SCSI_PROT_REF_INCREMENT;
 
-		if (bio_integrity_flagged(bio, BIP_CTRL_NOCHECK) == false)
+		if (bio_integrity_flagged(bio, BIP_CHECK_REFTAG))
 			scmd->prot_flags |= SCSI_PROT_REF_CHECK;
 	}

[v5,09/10] scsi: add support for user-meta interface

Commit Message

Comments

Patch