| Message ID | 20241106233144.9283-2-kiseok.jo@irondevice.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add a driver for the Iron Device SMA1307 Amp | expand |
On Thu, Nov 07, 2024 at 08:31:44AM +0900, Kiseok Jo wrote: > This adds the schema binding for the Iron Device SMA1307 Amp > > Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> > --- > v3 -> v4 > - Modify to fit the character-per-line format <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
> > On Thu, Nov 07, 2024 at 08:31:44AM +0900, Kiseok Jo wrote: > > This adds the schema binding for the Iron Device SMA1307 Amp > > > > Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> > > --- > > v3 -> v4 > > - Modify to fit the character-per-line format > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: Please add Acked- > by/Reviewed-by/Tested-by tags when posting new versions, under or above your > Signed-off-by tag. Tag is "received", when provided in a message replied to > you on the mailing list. Tools like b4 can help here. However, there's no need > to repost patches *only* to add the tags. > The upstream maintainer will do that for tags received on the version they > apply. > > https://elixir.bootlin.com/linux/v6.5- > rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Best regards, > Krzysztof Thank you for the kind explanation. I'll make sure to add the tag next time. I tried using b4, but I encountered issues with email delivery. So I haven't been able to use it properly yet. I'll make sure to use it in my next patch. Thank you! Best regards, Kiseok Jo
On 08/11/2024 00:57, Ki-Seok Jo wrote: >> >> On Thu, Nov 07, 2024 at 08:31:44AM +0900, Kiseok Jo wrote: >>> This adds the schema binding for the Iron Device SMA1307 Amp >>> >>> Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> >>> --- >>> v3 -> v4 >>> - Modify to fit the character-per-line format >> >> <form letter> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: Please add Acked- >> by/Reviewed-by/Tested-by tags when posting new versions, under or above your >> Signed-off-by tag. Tag is "received", when provided in a message replied to >> you on the mailing list. Tools like b4 can help here. However, there's no need >> to repost patches *only* to add the tags. >> The upstream maintainer will do that for tags received on the version they >> apply. >> >> https://elixir.bootlin.com/linux/v6.5- >> rc3/source/Documentation/process/submitting-patches.rst#L577 >> >> If a tag was not added on purpose, please state why and what changed. >> </form letter> >> >> Best regards, >> Krzysztof > > Thank you for the kind explanation. > I'll make sure to add the tag next time. > > I tried using b4, but I encountered issues with email delivery. > So I haven't been able to use it properly yet. > I'll make sure to use it in my next patch. > You don't have to use b4 to send patches. You can collect tags with b4 trailers even if you send patches standard way (git send-email). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml new file mode 100644 index 000000000..1e2a038d0 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/irondevice,sma1307.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Iron Device SMA1307 Audio Amplifier + +maintainers: + - Kiseok Jo <kiseok.jo@irondevice.com> + +description: + SMA1307 boosted digital speaker amplifier with feedback-loop. + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + enum: + - irondevice,sma1307a + - irondevice,sma1307aq + description: + If a 'q' is added, it indicated the product is AEC-Q100 + qualified for automotive applications. SMA1307A supports + both WLCSP and QFN packages. However, SMA1307AQ only + supports the QFN package. + + reg: + maxItems: 1 + + '#sound-dai-cells': + const: 1 + +required: + - compatible + - reg + - '#sound-dai-cells' + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + amplifier@1e { + compatible = "irondevice,sma1307a"; + reg = <0x1e>; + #sound-dai-cells = <1>; + }; + };
This adds the schema binding for the Iron Device SMA1307 Amp Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> --- v3 -> v4 - Modify to fit the character-per-line format v2 -> v3 - Remove ABI documents due to the removal of sysfs in the driver v1 -> v2 - Add ABI documents for sysfs - Remove the interrupt property as it is no longer used .../bindings/sound/irondevice,sma1307.yaml | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml .../bindings/sound/irondevice,sma1307.yaml | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml