diff mbox series

ACPI/IORT: Add PMCG platform information for HiSilicon HIP09A

Message ID 20241107094036.2398983-1-xiaqinxin@huawei.com
State Accepted
Commit c2b46ae022704a2d845e59461fa24431ad627022
Headers show
Series ACPI/IORT: Add PMCG platform information for HiSilicon HIP09A | expand

Commit Message

Qinxin Xia Nov. 7, 2024, 9:40 a.m. UTC
HiSilicon HIP09A platforms using the same SMMU PMCG with HIP09
and thus suffers the same erratum. List them in the PMCG platform
information list without introducing a new SMMU PMCG Model.

Update the silicon-errata.rst as well.

Signed-off-by: Qinxin Xia <xiaqinxin@huawei.com>
---
 Documentation/arch/arm64/silicon-errata.rst | 4 ++--
 drivers/acpi/arm64/iort.c                   | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Yicong Yang Nov. 14, 2024, 2:55 p.m. UTC | #1
On 2024/11/7 17:40, Qinxin Xia wrote:
> HiSilicon HIP09A platforms using the same SMMU PMCG with HIP09
> and thus suffers the same erratum. List them in the PMCG platform
> information list without introducing a new SMMU PMCG Model.
> 
> Update the silicon-errata.rst as well.
> 
> Signed-off-by: Qinxin Xia <xiaqinxin@huawei.com>

Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>

> ---
>  Documentation/arch/arm64/silicon-errata.rst | 4 ++--
>  drivers/acpi/arm64/iort.c                   | 2 ++
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/arch/arm64/silicon-errata.rst b/Documentation/arch/arm64/silicon-errata.rst
> index 65bfab1b1861..b21c0b1ed567 100644
> --- a/Documentation/arch/arm64/silicon-errata.rst
> +++ b/Documentation/arch/arm64/silicon-errata.rst
> @@ -255,8 +255,8 @@ stable kernels.
>  +----------------+-----------------+-----------------+-----------------------------+
>  | Hisilicon      | Hip08 SMMU PMCG | #162001800      | N/A                         |
>  +----------------+-----------------+-----------------+-----------------------------+
> -| Hisilicon      | Hip{08,09,10,10C| #162001900      | N/A                         |
> -|                | ,11} SMMU PMCG  |                 |                             |
> +| Hisilicon      | Hip{08,09x,10x, | #162001900      | N/A                         |
> +|                | 11} SMMU PMCG   |                 |                             |
>  +----------------+-----------------+-----------------+-----------------------------+
>  +----------------+-----------------+-----------------+-----------------------------+
>  | Qualcomm Tech. | Kryo/Falkor v1  | E1003           | QCOM_FALKOR_ERRATUM_1003    |
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 4c745a26226b..bf3be532e089 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -1703,6 +1703,8 @@ static struct acpi_platform_list pmcg_plat_info[] __initdata = {
>  	/* HiSilicon Hip09 Platform */
>  	{"HISI  ", "HIP09   ", 0, ACPI_SIG_IORT, greater_than_or_equal,
>  	 "Erratum #162001900", IORT_SMMU_V3_PMCG_HISI_HIP09},
> +	{"HISI  ", "HIP09A  ", 0, ACPI_SIG_IORT, greater_than_or_equal,
> +	 "Erratum #162001900", IORT_SMMU_V3_PMCG_HISI_HIP09},
>  	/* HiSilicon Hip10/11 Platform uses the same SMMU IP with Hip09 */
>  	{"HISI  ", "HIP10   ", 0, ACPI_SIG_IORT, greater_than_or_equal,
>  	 "Erratum #162001900", IORT_SMMU_V3_PMCG_HISI_HIP09},
>
Hanjun Guo Nov. 18, 2024, 4 a.m. UTC | #2
On 2024/11/7 17:40, Qinxin Xia wrote:
> HiSilicon HIP09A platforms using the same SMMU PMCG with HIP09
> and thus suffers the same erratum. List them in the PMCG platform
> information list without introducing a new SMMU PMCG Model.
> 
> Update the silicon-errata.rst as well.
> 
> Signed-off-by: Qinxin Xia <xiaqinxin@huawei.com>
> ---
>   Documentation/arch/arm64/silicon-errata.rst | 4 ++--
>   drivers/acpi/arm64/iort.c                   | 2 ++
>   2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/arch/arm64/silicon-errata.rst b/Documentation/arch/arm64/silicon-errata.rst
> index 65bfab1b1861..b21c0b1ed567 100644
> --- a/Documentation/arch/arm64/silicon-errata.rst
> +++ b/Documentation/arch/arm64/silicon-errata.rst
> @@ -255,8 +255,8 @@ stable kernels.
>   +----------------+-----------------+-----------------+-----------------------------+
>   | Hisilicon      | Hip08 SMMU PMCG | #162001800      | N/A                         |
>   +----------------+-----------------+-----------------+-----------------------------+
> -| Hisilicon      | Hip{08,09,10,10C| #162001900      | N/A                         |
> -|                | ,11} SMMU PMCG  |                 |                             |
> +| Hisilicon      | Hip{08,09x,10x, | #162001900      | N/A                         |

Since x is also a letter, I think it's better to add 09A after 09, with
no confusion.

> +|                | 11} SMMU PMCG   |                 |                             |
>   +----------------+-----------------+-----------------+-----------------------------+
>   +----------------+-----------------+-----------------+-----------------------------+
>   | Qualcomm Tech. | Kryo/Falkor v1  | E1003           | QCOM_FALKOR_ERRATUM_1003    |
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 4c745a26226b..bf3be532e089 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -1703,6 +1703,8 @@ static struct acpi_platform_list pmcg_plat_info[] __initdata = {
>   	/* HiSilicon Hip09 Platform */
>   	{"HISI  ", "HIP09   ", 0, ACPI_SIG_IORT, greater_than_or_equal,
>   	 "Erratum #162001900", IORT_SMMU_V3_PMCG_HISI_HIP09},
> +	{"HISI  ", "HIP09A  ", 0, ACPI_SIG_IORT, greater_than_or_equal,
> +	 "Erratum #162001900", IORT_SMMU_V3_PMCG_HISI_HIP09},
>   	/* HiSilicon Hip10/11 Platform uses the same SMMU IP with Hip09 */
>   	{"HISI  ", "HIP10   ", 0, ACPI_SIG_IORT, greater_than_or_equal,
>   	 "Erratum #162001900", IORT_SMMU_V3_PMCG_HISI_HIP09},

Please update the patch, and resend with Catalin and Will CCed.

Thanks
Hanjun
diff mbox series

Patch

diff --git a/Documentation/arch/arm64/silicon-errata.rst b/Documentation/arch/arm64/silicon-errata.rst
index 65bfab1b1861..b21c0b1ed567 100644
--- a/Documentation/arch/arm64/silicon-errata.rst
+++ b/Documentation/arch/arm64/silicon-errata.rst
@@ -255,8 +255,8 @@  stable kernels.
 +----------------+-----------------+-----------------+-----------------------------+
 | Hisilicon      | Hip08 SMMU PMCG | #162001800      | N/A                         |
 +----------------+-----------------+-----------------+-----------------------------+
-| Hisilicon      | Hip{08,09,10,10C| #162001900      | N/A                         |
-|                | ,11} SMMU PMCG  |                 |                             |
+| Hisilicon      | Hip{08,09x,10x, | #162001900      | N/A                         |
+|                | 11} SMMU PMCG   |                 |                             |
 +----------------+-----------------+-----------------+-----------------------------+
 +----------------+-----------------+-----------------+-----------------------------+
 | Qualcomm Tech. | Kryo/Falkor v1  | E1003           | QCOM_FALKOR_ERRATUM_1003    |
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 4c745a26226b..bf3be532e089 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -1703,6 +1703,8 @@  static struct acpi_platform_list pmcg_plat_info[] __initdata = {
 	/* HiSilicon Hip09 Platform */
 	{"HISI  ", "HIP09   ", 0, ACPI_SIG_IORT, greater_than_or_equal,
 	 "Erratum #162001900", IORT_SMMU_V3_PMCG_HISI_HIP09},
+	{"HISI  ", "HIP09A  ", 0, ACPI_SIG_IORT, greater_than_or_equal,
+	 "Erratum #162001900", IORT_SMMU_V3_PMCG_HISI_HIP09},
 	/* HiSilicon Hip10/11 Platform uses the same SMMU IP with Hip09 */
 	{"HISI  ", "HIP10   ", 0, ACPI_SIG_IORT, greater_than_or_equal,
 	 "Erratum #162001900", IORT_SMMU_V3_PMCG_HISI_HIP09},