| Message ID | 20241107140833.274986-1-hdegoede@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: rtl8xxxu: add more missing rtl8192cu USB IDs | expand |
Hi, On 18-Nov-24 3:23 AM, Ping-Ke Shih wrote: > Hans de Goede <hdegoede@redhat.com> wrote: > >> The rtl8xxxu has all the rtl8192cu USB IDs from rtlwifi/rtl8192cu/sw.c >> except for the following 10, add these to the untested section so they >> can be used with the rtl8xxxu as the rtl8192cu are well supported. >> >> This fixes these wifi modules not working on distributions which have >> disabled CONFIG_RTL8192CU replacing it with CONFIG_RTL8XXXU_UNTESTED, >> like Fedora. >> >> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2321540 >> Cc: stable@vger.kernel.org >> Cc: Peter Robinson <pbrobinson@gmail.com> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> Reviewed-by: Peter Robinson <pbrobinson@gmail.com> > > 1 patch(es) applied to rtw-next branch of rtw.git, thanks. > > 31be3175bd7b wifi: rtl8xxxu: add more missing rtl8192cu USB IDs Thank you for merging this, since this is a bugfix patch, see e.g. : https://bugzilla.redhat.com/show_bug.cgi?id=2321540 I was expecting this patch to show up in 6.13-rc1 but it does not appear to be there. Can you please include this in a fixes-pull-request to the network maintainer so that gets added to a 6.13-rc# release soon and then can be backported to various stable kernels ? Regards, Hans
Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > On 18-Nov-24 3:23 AM, Ping-Ke Shih wrote: > > Hans de Goede <hdegoede@redhat.com> wrote: > > > >> The rtl8xxxu has all the rtl8192cu USB IDs from rtlwifi/rtl8192cu/sw.c > >> except for the following 10, add these to the untested section so they > >> can be used with the rtl8xxxu as the rtl8192cu are well supported. > >> > >> This fixes these wifi modules not working on distributions which have > >> disabled CONFIG_RTL8192CU replacing it with CONFIG_RTL8XXXU_UNTESTED, > >> like Fedora. > >> > >> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2321540 > >> Cc: stable@vger.kernel.org > >> Cc: Peter Robinson <pbrobinson@gmail.com> > >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > >> Reviewed-by: Peter Robinson <pbrobinson@gmail.com> > > > > 1 patch(es) applied to rtw-next branch of rtw.git, thanks. > > > > 31be3175bd7b wifi: rtl8xxxu: add more missing rtl8192cu USB IDs > > Thank you for merging this, since this is a bugfix patch, see e.g. : > > https://bugzilla.redhat.com/show_bug.cgi?id=2321540 > > I was expecting this patch to show up in 6.13-rc1 but it does > not appear to be there. > > Can you please include this in a fixes-pull-request to the network > maintainer so that gets added to a 6.13-rc# release soon and then > can be backported to various stable kernels ? > This patch stays in rtw.git and 6.14 will have it, and then drain to stable trees. For the redhat users, could you ask the distro maintainer to take this patch ahead? Ping-Ke
Hi, On 9-Dec-24 1:26 AM, Ping-Ke Shih wrote: > Hans de Goede <hdegoede@redhat.com> wrote: >> Hi, >> >> On 18-Nov-24 3:23 AM, Ping-Ke Shih wrote: >>> Hans de Goede <hdegoede@redhat.com> wrote: >>> >>>> The rtl8xxxu has all the rtl8192cu USB IDs from rtlwifi/rtl8192cu/sw.c >>>> except for the following 10, add these to the untested section so they >>>> can be used with the rtl8xxxu as the rtl8192cu are well supported. >>>> >>>> This fixes these wifi modules not working on distributions which have >>>> disabled CONFIG_RTL8192CU replacing it with CONFIG_RTL8XXXU_UNTESTED, >>>> like Fedora. >>>> >>>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2321540 >>>> Cc: stable@vger.kernel.org >>>> Cc: Peter Robinson <pbrobinson@gmail.com> >>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >>>> Reviewed-by: Peter Robinson <pbrobinson@gmail.com> >>> >>> 1 patch(es) applied to rtw-next branch of rtw.git, thanks. >>> >>> 31be3175bd7b wifi: rtl8xxxu: add more missing rtl8192cu USB IDs >> >> Thank you for merging this, since this is a bugfix patch, see e.g. : >> >> https://bugzilla.redhat.com/show_bug.cgi?id=2321540 >> >> I was expecting this patch to show up in 6.13-rc1 but it does >> not appear to be there. >> >> Can you please include this in a fixes-pull-request to the network >> maintainer so that gets added to a 6.13-rc# release soon and then >> can be backported to various stable kernels ? >> > > This patch stays in rtw.git and 6.14 will have it, and then drain to stable > trees. For the redhat users, could you ask the distro maintainer to take this > patch ahead? That is not how things are supposed to work. You are supposed to have a fixes tree/branch and a next tree/branch and fixes should be send out ASAP. Ideally you would have already send this out as a fixes pull-request for 6.12 but waiting till 6.14 really is not acceptable IMHO. Note this is not just about Red Hat / Fedora users, other distros are likely impacted by this too. Regards, Hans
Hans de Goede <hdegoede@redhat.com> writes: > Hi, > > On 9-Dec-24 1:26 AM, Ping-Ke Shih wrote: >> Hans de Goede <hdegoede@redhat.com> wrote: >>> Hi, >>> >>> On 18-Nov-24 3:23 AM, Ping-Ke Shih wrote: >>>> Hans de Goede <hdegoede@redhat.com> wrote: >>>> >>>>> The rtl8xxxu has all the rtl8192cu USB IDs from rtlwifi/rtl8192cu/sw.c >>>>> except for the following 10, add these to the untested section so they >>>>> can be used with the rtl8xxxu as the rtl8192cu are well supported. >>>>> >>>>> This fixes these wifi modules not working on distributions which have >>>>> disabled CONFIG_RTL8192CU replacing it with CONFIG_RTL8XXXU_UNTESTED, >>>>> like Fedora. >>>>> >>>>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2321540 >>>>> Cc: stable@vger.kernel.org >>>>> Cc: Peter Robinson <pbrobinson@gmail.com> >>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >>>>> Reviewed-by: Peter Robinson <pbrobinson@gmail.com> >>>> >>>> 1 patch(es) applied to rtw-next branch of rtw.git, thanks. >>>> >>>> 31be3175bd7b wifi: rtl8xxxu: add more missing rtl8192cu USB IDs >>> >>> Thank you for merging this, since this is a bugfix patch, see e.g. : >>> >>> https://bugzilla.redhat.com/show_bug.cgi?id=2321540 >>> >>> I was expecting this patch to show up in 6.13-rc1 but it does >>> not appear to be there. >>> >>> Can you please include this in a fixes-pull-request to the network >>> maintainer so that gets added to a 6.13-rc# release soon and then >>> can be backported to various stable kernels ? >>> >> >> This patch stays in rtw.git and 6.14 will have it, and then drain to stable >> trees. For the redhat users, could you ask the distro maintainer to take this >> patch ahead? > > That is not how things are supposed to work. You are supposed to have a fixes > tree/branch and a next tree/branch and fixes should be send out ASAP. Please understand that we are more or less volunteers and working with limited time. > Ideally you would have already send this out as a fixes pull-request for > 6.12 but waiting till 6.14 really is not acceptable IMHO. If you have an important fix please document that somehow, for example "[PATCH wireless]" or "[PATCH v6.13]". If there's nothing like that most likely the patch goes to -next, we (in wireless) don't take every fix to -rc.
Hi, On 9-Dec-24 12:01 PM, Kalle Valo wrote: > Hans de Goede <hdegoede@redhat.com> writes: > >> Hi, >> >> On 9-Dec-24 1:26 AM, Ping-Ke Shih wrote: >>> Hans de Goede <hdegoede@redhat.com> wrote: >>>> Hi, >>>> >>>> On 18-Nov-24 3:23 AM, Ping-Ke Shih wrote: >>>>> Hans de Goede <hdegoede@redhat.com> wrote: >>>>> >>>>>> The rtl8xxxu has all the rtl8192cu USB IDs from rtlwifi/rtl8192cu/sw.c >>>>>> except for the following 10, add these to the untested section so they >>>>>> can be used with the rtl8xxxu as the rtl8192cu are well supported. >>>>>> >>>>>> This fixes these wifi modules not working on distributions which have >>>>>> disabled CONFIG_RTL8192CU replacing it with CONFIG_RTL8XXXU_UNTESTED, >>>>>> like Fedora. >>>>>> >>>>>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2321540 >>>>>> Cc: stable@vger.kernel.org >>>>>> Cc: Peter Robinson <pbrobinson@gmail.com> >>>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >>>>>> Reviewed-by: Peter Robinson <pbrobinson@gmail.com> >>>>> >>>>> 1 patch(es) applied to rtw-next branch of rtw.git, thanks. >>>>> >>>>> 31be3175bd7b wifi: rtl8xxxu: add more missing rtl8192cu USB IDs >>>> >>>> Thank you for merging this, since this is a bugfix patch, see e.g. : >>>> >>>> https://bugzilla.redhat.com/show_bug.cgi?id=2321540 >>>> >>>> I was expecting this patch to show up in 6.13-rc1 but it does >>>> not appear to be there. >>>> >>>> Can you please include this in a fixes-pull-request to the network >>>> maintainer so that gets added to a 6.13-rc# release soon and then >>>> can be backported to various stable kernels ? >>>> >>> >>> This patch stays in rtw.git and 6.14 will have it, and then drain to stable >>> trees. For the redhat users, could you ask the distro maintainer to take this >>> patch ahead? >> >> That is not how things are supposed to work. You are supposed to have a fixes >> tree/branch and a next tree/branch and fixes should be send out ASAP. > > Please understand that we are more or less volunteers and working with > limited time. > >> Ideally you would have already send this out as a fixes pull-request for >> 6.12 but waiting till 6.14 really is not acceptable IMHO. > > If you have an important fix please document that somehow, for example > "[PATCH wireless]" or "[PATCH v6.13]". If there's nothing like that most > likely the patch goes to -next, we (in wireless) don't take every fix to Ok, so how do we move forward with this patch now ? Regards, Hans
Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > On 9-Dec-24 12:01 PM, Kalle Valo wrote: > > Hans de Goede <hdegoede@redhat.com> writes: > > > >> Hi, > >> > >> On 9-Dec-24 1:26 AM, Ping-Ke Shih wrote: > >>> Hans de Goede <hdegoede@redhat.com> wrote: > >>>> Hi, > >>>> > >>>> On 18-Nov-24 3:23 AM, Ping-Ke Shih wrote: > >>>>> Hans de Goede <hdegoede@redhat.com> wrote: > >>>>> > >>>>>> The rtl8xxxu has all the rtl8192cu USB IDs from rtlwifi/rtl8192cu/sw.c > >>>>>> except for the following 10, add these to the untested section so they > >>>>>> can be used with the rtl8xxxu as the rtl8192cu are well supported. > >>>>>> > >>>>>> This fixes these wifi modules not working on distributions which have > >>>>>> disabled CONFIG_RTL8192CU replacing it with CONFIG_RTL8XXXU_UNTESTED, > >>>>>> like Fedora. > >>>>>> > >>>>>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2321540 > >>>>>> Cc: stable@vger.kernel.org > >>>>>> Cc: Peter Robinson <pbrobinson@gmail.com> > >>>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > >>>>>> Reviewed-by: Peter Robinson <pbrobinson@gmail.com> > >>>>> > >>>>> 1 patch(es) applied to rtw-next branch of rtw.git, thanks. > >>>>> > >>>>> 31be3175bd7b wifi: rtl8xxxu: add more missing rtl8192cu USB IDs > >>>> > >>>> Thank you for merging this, since this is a bugfix patch, see e.g. : > >>>> > >>>> https://bugzilla.redhat.com/show_bug.cgi?id=2321540 > >>>> > >>>> I was expecting this patch to show up in 6.13-rc1 but it does > >>>> not appear to be there. > >>>> > >>>> Can you please include this in a fixes-pull-request to the network > >>>> maintainer so that gets added to a 6.13-rc# release soon and then > >>>> can be backported to various stable kernels ? > >>>> > >>> > >>> This patch stays in rtw.git and 6.14 will have it, and then drain to stable > >>> trees. For the redhat users, could you ask the distro maintainer to take this > >>> patch ahead? > >> > >> That is not how things are supposed to work. You are supposed to have a fixes > >> tree/branch and a next tree/branch and fixes should be send out ASAP. > > > > Please understand that we are more or less volunteers and working with > > limited time. > > > >> Ideally you would have already send this out as a fixes pull-request for > >> 6.12 but waiting till 6.14 really is not acceptable IMHO. > > > > If you have an important fix please document that somehow, for example > > "[PATCH wireless]" or "[PATCH v6.13]". If there's nothing like that most > > likely the patch goes to -next, we (in wireless) don't take every fix to > > Ok, so how do we move forward with this patch now ? > IMHO the missed ID has been many years, let's wait additional three months. The flow of patch process for maintainers will be more smooth. For newly added ID next time, I will check people if that is urgent or not.
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c b/drivers/net/wireless/realtek/rtl8xxxu/core.c index 7891c988dd5f..bd8e0076baac 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c @@ -8145,6 +8145,8 @@ static const struct usb_device_id dev_table[] = { .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x817e, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, +{USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x8186, 0xff, 0xff, 0xff), + .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x818a, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x317f, 0xff, 0xff, 0xff), @@ -8155,12 +8157,18 @@ static const struct usb_device_id dev_table[] = { .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x050d, 0x1102, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, +{USB_DEVICE_AND_INTERFACE_INFO(0x050d, 0x11f2, 0xff, 0xff, 0xff), + .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x06f8, 0xe033, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, +{USB_DEVICE_AND_INTERFACE_INFO(0x07b8, 0x8188, 0xff, 0xff, 0xff), + .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x07b8, 0x8189, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x0846, 0x9041, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, +{USB_DEVICE_AND_INTERFACE_INFO(0x0846, 0x9043, 0xff, 0xff, 0xff), + .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x0b05, 0x17ba, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x1e1e, 0xff, 0xff, 0xff), @@ -8177,6 +8185,10 @@ static const struct usb_device_id dev_table[] = { .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x13d3, 0x3357, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, +{USB_DEVICE_AND_INTERFACE_INFO(0x13d3, 0x3358, 0xff, 0xff, 0xff), + .driver_info = (unsigned long)&rtl8192cu_fops}, +{USB_DEVICE_AND_INTERFACE_INFO(0x13d3, 0x3359, 0xff, 0xff, 0xff), + .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x330b, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x2019, 0x4902, 0xff, 0xff, 0xff), @@ -8191,6 +8203,8 @@ static const struct usb_device_id dev_table[] = { .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x4856, 0x0091, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, +{USB_DEVICE_AND_INTERFACE_INFO(0x9846, 0x9041, 0xff, 0xff, 0xff), + .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0xcdab, 0x8010, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x04f2, 0xaff7, 0xff, 0xff, 0xff), @@ -8216,6 +8230,8 @@ static const struct usb_device_id dev_table[] = { .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x0586, 0x341f, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, +{USB_DEVICE_AND_INTERFACE_INFO(0x06f8, 0xe033, 0xff, 0xff, 0xff), + .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x06f8, 0xe035, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x0b05, 0x17ab, 0xff, 0xff, 0xff), @@ -8224,6 +8240,8 @@ static const struct usb_device_id dev_table[] = { .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x0df6, 0x0070, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, +{USB_DEVICE_AND_INTERFACE_INFO(0x0df6, 0x0077, 0xff, 0xff, 0xff), + .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x0789, 0x016d, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x07aa, 0x0056, 0xff, 0xff, 0xff), @@ -8246,6 +8264,8 @@ static const struct usb_device_id dev_table[] = { .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x330a, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, +{USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x330d, 0xff, 0xff, 0xff), + .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x2019, 0xab2b, 0xff, 0xff, 0xff), .driver_info = (unsigned long)&rtl8192cu_fops}, {USB_DEVICE_AND_INTERFACE_INFO(0x20f4, 0x624d, 0xff, 0xff, 0xff),
The rtl8xxxu has all the rtl8192cu USB IDs from rtlwifi/rtl8192cu/sw.c except for the following 10, add these to the untested section so they can be used with the rtl8xxxu as the rtl8192cu are well supported. This fixes these wifi modules not working on distributions which have disabled CONFIG_RTL8192CU replacing it with CONFIG_RTL8XXXU_UNTESTED, like Fedora. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2321540 Cc: stable@vger.kernel.org Cc: Peter Robinson <pbrobinson@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/net/wireless/realtek/rtl8xxxu/core.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)