diff mbox series

[v7,12/22] ACPI: platform_profile: Add choices attribute for class interface

Message ID 20241119171739.77028-13-mario.limonciello@amd.com
State New
Headers show
Series Add support for binding ACPI platform profile to multiple drivers | expand

Commit Message

Mario Limonciello Nov. 19, 2024, 5:17 p.m. UTC 
The `choices` file will show all possible choices that a given platform
profile handler can support.

Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v7:
 * Drop locking
v5:
 * Fix kdoc
 * Add tag
 * Fix whitespace
 * Adjust mutex use
---
 drivers/acpi/platform_profile.c | 39 +++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

Comments

Ilpo Järvinen Nov. 20, 2024, 2:47 p.m. UTC | #1 
On Tue, 19 Nov 2024, Mario Limonciello wrote:

> The `choices` file will show all possible choices that a given platform
> profile handler can support.
> 
> Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v7:
>  * Drop locking
> v5:
>  * Fix kdoc
>  * Add tag
>  * Fix whitespace
>  * Adjust mutex use
> ---
>  drivers/acpi/platform_profile.c | 39 +++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
> 
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index a9d7ec3c85844..9d6ead043994c 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -25,6 +25,27 @@ static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST);
>  
>  static DEFINE_IDA(platform_profile_ida);
>  
> +/**
> + * _commmon_choices_show - Show the available profile choices
> + * @choices: The available profile choices
> + * @buf: The buffer to write to

Add empty line.

> + * Return: The number of bytes written
> + */

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
 i.


> +static ssize_t _commmon_choices_show(unsigned long *choices, char *buf)
> +{
> +	int i, len = 0;
> +
> +	for_each_set_bit(i, choices, PLATFORM_PROFILE_LAST) {
> +		if (len == 0)
> +			len += sysfs_emit_at(buf, len, "%s", profile_names[i]);
> +		else
> +			len += sysfs_emit_at(buf, len, " %s", profile_names[i]);
> +	}
> +	len += sysfs_emit_at(buf, len, "\n");
> +
> +	return len;
> +}
> +
>  /**
>   * name_show - Show the name of the profile handler
>   * @dev: The device
> @@ -41,9 +62,27 @@ static ssize_t name_show(struct device *dev,
>  	return sysfs_emit(buf, "%s\n", handler->name);
>  }
>  
> +/**
> + * choices_show - Show the available profile choices
> + * @dev: The device
> + * @attr: The attribute
> + * @buf: The buffer to write to
> + */
> +static ssize_t choices_show(struct device *dev,
> +			    struct device_attribute *attr,
> +			    char *buf)
> +{
> +	struct platform_profile_handler *handler = dev_get_drvdata(dev);
> +
> +	return _commmon_choices_show(handler->choices, buf);
> +}
> +
>  static DEVICE_ATTR_RO(name);
> +static DEVICE_ATTR_RO(choices);
> +
>  static struct attribute *profile_attrs[] = {
>  	&dev_attr_name.attr,
> +	&dev_attr_choices.attr,
>  	NULL
>  };
>  ATTRIBUTE_GROUPS(profile);
>
Armin Wolf Nov. 21, 2024, 10:12 p.m. UTC | #2 
Am 19.11.24 um 18:17 schrieb Mario Limonciello:

> The `choices` file will show all possible choices that a given platform
> profile handler can support.

Reviewed-by: Armin Wolf <W_Armin@gmx.de>

> Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v7:
>   * Drop locking
> v5:
>   * Fix kdoc
>   * Add tag
>   * Fix whitespace
>   * Adjust mutex use
> ---
>   drivers/acpi/platform_profile.c | 39 +++++++++++++++++++++++++++++++++
>   1 file changed, 39 insertions(+)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index a9d7ec3c85844..9d6ead043994c 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -25,6 +25,27 @@ static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST);
>
>   static DEFINE_IDA(platform_profile_ida);
>
> +/**
> + * _commmon_choices_show - Show the available profile choices
> + * @choices: The available profile choices
> + * @buf: The buffer to write to
> + * Return: The number of bytes written
> + */
> +static ssize_t _commmon_choices_show(unsigned long *choices, char *buf)
> +{
> +	int i, len = 0;
> +
> +	for_each_set_bit(i, choices, PLATFORM_PROFILE_LAST) {
> +		if (len == 0)
> +			len += sysfs_emit_at(buf, len, "%s", profile_names[i]);
> +		else
> +			len += sysfs_emit_at(buf, len, " %s", profile_names[i]);
> +	}
> +	len += sysfs_emit_at(buf, len, "\n");
> +
> +	return len;
> +}
> +
>   /**
>    * name_show - Show the name of the profile handler
>    * @dev: The device
> @@ -41,9 +62,27 @@ static ssize_t name_show(struct device *dev,
>   	return sysfs_emit(buf, "%s\n", handler->name);
>   }
>
> +/**
> + * choices_show - Show the available profile choices
> + * @dev: The device
> + * @attr: The attribute
> + * @buf: The buffer to write to
> + */
> +static ssize_t choices_show(struct device *dev,
> +			    struct device_attribute *attr,
> +			    char *buf)
> +{
> +	struct platform_profile_handler *handler = dev_get_drvdata(dev);
> +
> +	return _commmon_choices_show(handler->choices, buf);
> +}
> +
>   static DEVICE_ATTR_RO(name);
> +static DEVICE_ATTR_RO(choices);
> +
>   static struct attribute *profile_attrs[] = {
>   	&dev_attr_name.attr,
> +	&dev_attr_choices.attr,
>   	NULL
>   };
>   ATTRIBUTE_GROUPS(profile);
diff mbox series

Patch

diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index a9d7ec3c85844..9d6ead043994c 100644
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -25,6 +25,27 @@  static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST);
 
 static DEFINE_IDA(platform_profile_ida);
 
+/**
+ * _commmon_choices_show - Show the available profile choices
+ * @choices: The available profile choices
+ * @buf: The buffer to write to
+ * Return: The number of bytes written
+ */
+static ssize_t _commmon_choices_show(unsigned long *choices, char *buf)
+{
+	int i, len = 0;
+
+	for_each_set_bit(i, choices, PLATFORM_PROFILE_LAST) {
+		if (len == 0)
+			len += sysfs_emit_at(buf, len, "%s", profile_names[i]);
+		else
+			len += sysfs_emit_at(buf, len, " %s", profile_names[i]);
+	}
+	len += sysfs_emit_at(buf, len, "\n");
+
+	return len;
+}
+
 /**
  * name_show - Show the name of the profile handler
  * @dev: The device
@@ -41,9 +62,27 @@  static ssize_t name_show(struct device *dev,
 	return sysfs_emit(buf, "%s\n", handler->name);
 }
 
+/**
+ * choices_show - Show the available profile choices
+ * @dev: The device
+ * @attr: The attribute
+ * @buf: The buffer to write to
+ */
+static ssize_t choices_show(struct device *dev,
+			    struct device_attribute *attr,
+			    char *buf)
+{
+	struct platform_profile_handler *handler = dev_get_drvdata(dev);
+
+	return _commmon_choices_show(handler->choices, buf);
+}
+
 static DEVICE_ATTR_RO(name);
+static DEVICE_ATTR_RO(choices);
+
 static struct attribute *profile_attrs[] = {
 	&dev_attr_name.attr,
+	&dev_attr_choices.attr,
 	NULL
 };
 ATTRIBUTE_GROUPS(profile);