| Message ID | 20241122103418.539-1-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/pci: Remove unused pci_irq_pulse() method | expand |
On 22/11/2024 11.34, Philippe Mathieu-Daudé wrote: > Last use of pci_irq_pulse() was removed 7 years ago in commit > 5e9aa92eb1 ("hw/block: Fix pin-based interrupt behaviour of NVMe"). > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > include/hw/pci/pci.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index 135695c551..c0717e3121 100644 > --- a/include/hw/pci/pci.h > +++ b/include/hw/pci/pci.h > @@ -670,16 +670,6 @@ static inline void pci_irq_deassert(PCIDevice *pci_dev) > pci_set_irq(pci_dev, 0); > } > > -/* > - * FIXME: PCI does not work this way. > - * All the callers to this method should be fixed. > - */ > -static inline void pci_irq_pulse(PCIDevice *pci_dev) > -{ > - pci_irq_assert(pci_dev); > - pci_irq_deassert(pci_dev); > -} > - > MSIMessage pci_get_msi_message(PCIDevice *dev, int vector); > void pci_set_power(PCIDevice *pci_dev, bool state); > Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 135695c551..c0717e3121 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -670,16 +670,6 @@ static inline void pci_irq_deassert(PCIDevice *pci_dev) pci_set_irq(pci_dev, 0); } -/* - * FIXME: PCI does not work this way. - * All the callers to this method should be fixed. - */ -static inline void pci_irq_pulse(PCIDevice *pci_dev) -{ - pci_irq_assert(pci_dev); - pci_irq_deassert(pci_dev); -} - MSIMessage pci_get_msi_message(PCIDevice *dev, int vector); void pci_set_power(PCIDevice *pci_dev, bool state);
Last use of pci_irq_pulse() was removed 7 years ago in commit 5e9aa92eb1 ("hw/block: Fix pin-based interrupt behaviour of NVMe"). Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- include/hw/pci/pci.h | 10 ---------- 1 file changed, 10 deletions(-)