diff mbox series

[1/1] tests/avocado: update sbsa-ref firmware

Message ID 20241125125448.185504-1-marcin.juszkiewicz@linaro.org
State New
Headers show
Series [1/1] tests/avocado: update sbsa-ref firmware | expand

Commit Message

Marcin Juszkiewicz Nov. 25, 2024, 12:54 p.m. UTC
Firmware is built using Debian 'bookworm' cross toolchain (gcc 12.2.0).

Used versions:

- Trusted Firmware v2.12.0
- Tianocore EDK2 stable202411
- Tianocore EDK2 Platforms code commit 4b3530d

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 tests/functional/test_aarch64_sbsaref.py | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Peter Maydell Nov. 25, 2024, 1:25 p.m. UTC | #1
On Mon, 25 Nov 2024 at 12:54, Marcin Juszkiewicz
<marcin.juszkiewicz@linaro.org> wrote:
>
> Firmware is built using Debian 'bookworm' cross toolchain (gcc 12.2.0).
>
> Used versions:
>
> - Trusted Firmware v2.12.0
> - Tianocore EDK2 stable202411
> - Tianocore EDK2 Platforms code commit 4b3530d
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

Hi; what's the benefit to taking this update? Would it be better
postponed until the 9.2 release is complete?

thanks
-- PMM
Peter Maydell Dec. 16, 2024, 12:46 p.m. UTC | #2
On Mon, 25 Nov 2024 at 13:25, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 25 Nov 2024 at 12:54, Marcin Juszkiewicz
> <marcin.juszkiewicz@linaro.org> wrote:
> >
> > Firmware is built using Debian 'bookworm' cross toolchain (gcc 12.2.0).
> >
> > Used versions:
> >
> > - Trusted Firmware v2.12.0
> > - Tianocore EDK2 stable202411
> > - Tianocore EDK2 Platforms code commit 4b3530d
> >
> > Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>
> Hi; what's the benefit to taking this update? Would it be better
> postponed until the 9.2 release is complete?

We're now past the 9.2 release, but it would still be good
to know what the benefit to updating the firmware images
for this test is.

thanks
-- PMM
Marcin Juszkiewicz Dec. 17, 2024, 7:10 a.m. UTC | #3
W dniu 16.12.2024 o 13:46, Peter Maydell pisze:
> On Mon, 25 Nov 2024 at 13:25, Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>> On Mon, 25 Nov 2024 at 12:54, Marcin Juszkiewicz
>> <marcin.juszkiewicz@linaro.org> wrote:
>>>
>>> Firmware is built using Debian 'bookworm' cross toolchain (gcc 12.2.0).
>>>
>>> Used versions:
>>>
>>> - Trusted Firmware v2.12.0
>>> - Tianocore EDK2 stable202411
>>> - Tianocore EDK2 Platforms code commit 4b3530d
>>>
>>> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>>
>> Hi; what's the benefit to taking this update? Would it be better
>> postponed until the 9.2 release is complete?
> 
> We're now past the 9.2 release, but it would still be good
> to know what the benefit to updating the firmware images
> for this test is.

We tend to update firmware to the latest in all places it is used. 
Previous one was built from pre-selected git commits due to changes done 
during cycle.

Now we got both components (TF-A and EDK2) from stable releases.
Peter Maydell Dec. 17, 2024, 3:24 p.m. UTC | #4
On Tue, 17 Dec 2024 at 07:10, Marcin Juszkiewicz
<marcin.juszkiewicz@linaro.org> wrote:
>
> W dniu 16.12.2024 o 13:46, Peter Maydell pisze:
> > On Mon, 25 Nov 2024 at 13:25, Peter Maydell <peter.maydell@linaro.org> wrote:
> >>
> >> On Mon, 25 Nov 2024 at 12:54, Marcin Juszkiewicz
> >> <marcin.juszkiewicz@linaro.org> wrote:
> >>>
> >>> Firmware is built using Debian 'bookworm' cross toolchain (gcc 12.2.0).
> >>>
> >>> Used versions:
> >>>
> >>> - Trusted Firmware v2.12.0
> >>> - Tianocore EDK2 stable202411
> >>> - Tianocore EDK2 Platforms code commit 4b3530d
> >>>
> >>> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> >>
> >> Hi; what's the benefit to taking this update? Would it be better
> >> postponed until the 9.2 release is complete?
> >
> > We're now past the 9.2 release, but it would still be good
> > to know what the benefit to updating the firmware images
> > for this test is.
>
> We tend to update firmware to the latest in all places it is used.
> Previous one was built from pre-selected git commits due to changes done
> during cycle.
>
> Now we got both components (TF-A and EDK2) from stable releases.

Thanks; I've applied this to target-arm.next with the commit
message updated to include the rationale for the change.

-- PMM
diff mbox series

Patch

diff --git a/tests/functional/test_aarch64_sbsaref.py b/tests/functional/test_aarch64_sbsaref.py
index 9fda396b3a..3a09523265 100755
--- a/tests/functional/test_aarch64_sbsaref.py
+++ b/tests/functional/test_aarch64_sbsaref.py
@@ -25,9 +25,9 @@  def fetch_firmware(test):
 
     Used components:
 
-    - Trusted Firmware         v2.11.0
-    - Tianocore EDK2           4d4f569924
-    - Tianocore EDK2-platforms 3f08401
+    - Trusted Firmware         v2.12.0
+    - Tianocore EDK2           edk2-stable202411
+    - Tianocore EDK2-platforms 4b3530d
 
     """
 
@@ -63,13 +63,13 @@  class Aarch64SbsarefMachine(QemuSystemTest):
 
     ASSET_FLASH0 = Asset(
         ('https://artifacts.codelinaro.org/artifactory/linaro-419-sbsa-ref/'
-         '20240619-148232/edk2/SBSA_FLASH0.fd.xz'),
-        '0c954842a590988f526984de22e21ae0ab9cb351a0c99a8a58e928f0c7359cf7')
+         '20241122-189881/edk2/SBSA_FLASH0.fd.xz'),
+        '76eb89d42eebe324e4395329f47447cda9ac920aabcf99aca85424609c3384a5')
 
     ASSET_FLASH1 = Asset(
         ('https://artifacts.codelinaro.org/artifactory/linaro-419-sbsa-ref/'
-         '20240619-148232/edk2/SBSA_FLASH1.fd.xz'),
-        'c6ec39374c4d79bb9e9cdeeb6db44732d90bb4a334cec92002b3f4b9cac4b5ee')
+         '20241122-189881/edk2/SBSA_FLASH1.fd.xz'),
+        'f850f243bd8dbd49c51e061e0f79f1697546938f454aeb59ab7d93e5f0d412fc')
 
     def test_sbsaref_edk2_firmware(self):
 
@@ -87,15 +87,15 @@  def test_sbsaref_edk2_firmware(self):
 
         # AP Trusted ROM
         wait_for_console_pattern(self, "Booting Trusted Firmware")
-        wait_for_console_pattern(self, "BL1: v2.11.0(release):")
+        wait_for_console_pattern(self, "BL1: v2.12.0(release):")
         wait_for_console_pattern(self, "BL1: Booting BL2")
 
         # Trusted Boot Firmware
-        wait_for_console_pattern(self, "BL2: v2.11.0(release)")
+        wait_for_console_pattern(self, "BL2: v2.12.0(release)")
         wait_for_console_pattern(self, "Booting BL31")
 
         # EL3 Runtime Software
-        wait_for_console_pattern(self, "BL31: v2.11.0(release)")
+        wait_for_console_pattern(self, "BL31: v2.12.0(release)")
 
         # Non-trusted Firmware
         wait_for_console_pattern(self, "UEFI firmware (version 1.0")