| Message ID | 20241128-z2-v2-1-76cc59bbf117@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Driver for Apple Z2 touchscreens. | expand |
On Thu, Nov 28, 2024 at 11:29:16PM +0100, Sasha Finkelstein wrote: > Add bindings for touchscreen controllers attached using the Z2 protocol. > Those are present in most Apple devices. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > --- > .../input/touchscreen/apple,z2-multitouch.yaml | 69 ++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/apple,z2-multitouch.yaml b/Documentation/devicetree/bindings/input/touchscreen/apple,z2-multitouch.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..c4c0b41178728d5e0a782979d6eecd32e0a83618 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/apple,z2-multitouch.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/apple,z2-multitouch.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple touchscreens attached using the Z2 protocol > + > +maintainers: > + - Sasha Finkelstein <fnkl.kernel@gmail.com> > + > +description: A series of touschscreen controllers used in Apple products > + > +allOf: > + - $ref: touchscreen.yaml# > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + enum: > + - apple,j293-touchbar > + - apple,j493-touchbar > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > + firmware-name: > + maxItems: 1 > + > + apple,z2-cal-blob: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + description: > + Calibration blob supplied by the bootloader What is the expected size? Fixed size or maximum? Add it to the example. Best regards, Krzysztof
On Fri, 29 Nov 2024 at 08:16, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > + description: > > + Calibration blob supplied by the bootloader > > What is the expected size? Fixed size or maximum? Unspecified, 1688 bytes on my machine, but the firmware has a size field. Most likely less than 4k. > Add it to the example. That seems counterproductive - it is a ~1.5kb blob, and it is supposed to be set by the bootloader, not by person writing the dts.
On 29/11/2024 08:53, Sasha Finkelstein wrote: > On Fri, 29 Nov 2024 at 08:16, Krzysztof Kozlowski <krzk@kernel.org> wrote: >>> + description: >>> + Calibration blob supplied by the bootloader >> >> What is the expected size? Fixed size or maximum? > > Unspecified, 1688 bytes on my machine, but the firmware > has a size field. Most likely less than 4k. I suggest putting upper limit. You can still later grow it if different bootloader uses bigger size. > >> Add it to the example. > > That seems counterproductive - it is a ~1.5kb blob, > and it is supposed to be set by the bootloader, not > by person writing the dts. Indeed, let's skip it. Anyway: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/input/touchscreen/apple,z2-multitouch.yaml b/Documentation/devicetree/bindings/input/touchscreen/apple,z2-multitouch.yaml new file mode 100644 index 0000000000000000000000000000000000000000..c4c0b41178728d5e0a782979d6eecd32e0a83618 --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/apple,z2-multitouch.yaml @@ -0,0 +1,69 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/touchscreen/apple,z2-multitouch.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple touchscreens attached using the Z2 protocol + +maintainers: + - Sasha Finkelstein <fnkl.kernel@gmail.com> + +description: A series of touschscreen controllers used in Apple products + +allOf: + - $ref: touchscreen.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + enum: + - apple,j293-touchbar + - apple,j493-touchbar + + interrupts: + maxItems: 1 + + reset-gpios: + maxItems: 1 + + firmware-name: + maxItems: 1 + + apple,z2-cal-blob: + $ref: /schemas/types.yaml#/definitions/uint8-array + description: + Calibration blob supplied by the bootloader + +required: + - compatible + - interrupts + - reset-gpios + - firmware-name + - touchscreen-size-x + - touchscreen-size-y + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + + spi { + #address-cells = <1>; + #size-cells = <0>; + + touchscreen@0 { + compatible = "apple,j293-touchbar"; + reg = <0>; + spi-max-frequency = <11500000>; + reset-gpios = <&pinctrl_ap 139 GPIO_ACTIVE_LOW>; + interrupts-extended = <&pinctrl_ap 194 IRQ_TYPE_EDGE_FALLING>; + firmware-name = "apple/dfrmtfw-j293.bin"; + touchscreen-size-x = <23045>; + touchscreen-size-y = <640>; + }; + }; + +...