| Message ID | 20241223135700.22660-2-quic_janathot@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Enable Bluetooth on qcs6490-rb3gen2 board | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=920408 ---Test result--- Test Summary: CheckPatch PENDING 0.33 seconds GitLint PENDING 0.38 seconds SubjectPrefix FAIL 1.44 seconds BuildKernel PASS 24.92 seconds CheckAllWarning PASS 26.96 seconds CheckSparse PASS 30.73 seconds BuildKernel32 PASS 24.47 seconds TestRunnerSetup PASS 434.98 seconds TestRunner_l2cap-tester PASS 21.80 seconds TestRunner_iso-tester PASS 32.04 seconds TestRunner_bnep-tester PASS 4.77 seconds TestRunner_mgmt-tester FAIL 121.31 seconds TestRunner_rfcomm-tester PASS 7.47 seconds TestRunner_sco-tester PASS 9.32 seconds TestRunner_ioctl-tester PASS 7.98 seconds TestRunner_mesh-tester PASS 6.03 seconds TestRunner_smp-tester PASS 6.96 seconds TestRunner_userchan-tester PASS 4.98 seconds IncrementalBuild PENDING 0.54 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject ############################## Test: TestRunner_mgmt-tester - FAIL Desc: Run mgmt-tester with test-runner Output: Total: 490, Passed: 484 (98.8%), Failed: 2, Not Run: 4 Failed Test Cases LL Privacy - Add Device 3 (AL is full) Failed 0.199 seconds LL Privacy - Set Flags 3 (2 Devices to RL) Failed 0.172 seconds ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
On Mon, Dec 23, 2024 at 07:27:00PM +0530, Janaki Ramaiah Thota wrote: Subject: everything is an update... say something useful, e.g. use PMU abstraction for WCN6750 > Drop the inputs from the host and instead expect the Bluetooth node to > consume the outputs of the internal PMU. On which device? But anyway I have doubts this is correct. enable GPIO is a pin going from the host, not from PMU. > > Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> > --- > .../bindings/net/bluetooth/qualcomm-bluetooth.yaml | 5 ----- > 1 file changed, 5 deletions(-) > I don't understand why this is v6 of previous patchset. There was no such patch before. Best regards, Krzysztof
On 12/24/2024 2:46 PM, Krzysztof Kozlowski wrote: > On Mon, Dec 23, 2024 at 07:27:00PM +0530, Janaki Ramaiah Thota wrote: > > Subject: everything is an update... say something useful, e.g. use PMU > abstraction for WCN6750 > Sure will correct it in next patch. >> Drop the inputs from the host and instead expect the Bluetooth node to >> consume the outputs of the internal PMU. > > On which device? > It is for BT module wcn6750 attached on qcs6490-rb3gen2 board. will update same on next commit message. > But anyway I have doubts this is correct. enable GPIO is a pin going > from the host, not from PMU. > Yes you are correct, enable GPIO is out pin of host, but here updated the entries required for Bluetooth node from PMU, not from host to PMU. >> >> Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> >> --- >> .../bindings/net/bluetooth/qualcomm-bluetooth.yaml | 5 ----- >> 1 file changed, 5 deletions(-) >> > > I don't understand why this is v6 of previous patchset. There was no > such patch before. > Just to maintain the previous patch series history named as v6. Updated the cover letter with previous v5 history: https://lore.kernel.org/linux-arm-msm/20241209103455.9675-1-quic_janathot@quicinc.com/ Thanks, Janakiram
On 24/12/2024 12:51, Janaki Ramaiah Thota wrote: > > > On 12/24/2024 2:46 PM, Krzysztof Kozlowski wrote: >> On Mon, Dec 23, 2024 at 07:27:00PM +0530, Janaki Ramaiah Thota wrote: >> >> Subject: everything is an update... say something useful, e.g. use PMU >> abstraction for WCN6750 >> > > Sure will correct it in next patch. > >>> Drop the inputs from the host and instead expect the Bluetooth node to >>> consume the outputs of the internal PMU. >> >> On which device? >> > > It is for BT module wcn6750 attached on qcs6490-rb3gen2 board. > will update same on next commit message. > >> But anyway I have doubts this is correct. enable GPIO is a pin going >> from the host, not from PMU. >> > > Yes you are correct, enable GPIO is out pin of host, but here updated > the entries required for Bluetooth node from PMU, not from host to PMU. Hm? No, you removed for example enable-gpios, which is input from the host. Sorry, I don't understand the reason behind this patch and commit msg does not help me there. Best regards, Krzysztof
On 12/24/2024 6:57 PM, Krzysztof Kozlowski wrote: > On 24/12/2024 12:51, Janaki Ramaiah Thota wrote: >> >> >> On 12/24/2024 2:46 PM, Krzysztof Kozlowski wrote: >>> On Mon, Dec 23, 2024 at 07:27:00PM +0530, Janaki Ramaiah Thota wrote: >>> >>> Subject: everything is an update... say something useful, e.g. use PMU >>> abstraction for WCN6750 >>> >> >> Sure will correct it in next patch. >> >>>> Drop the inputs from the host and instead expect the Bluetooth node to >>>> consume the outputs of the internal PMU. >>> >>> On which device? >>> >> >> It is for BT module wcn6750 attached on qcs6490-rb3gen2 board. >> will update same on next commit message. >> >>> But anyway I have doubts this is correct. enable GPIO is a pin going >>> from the host, not from PMU. >>> >> >> Yes you are correct, enable GPIO is out pin of host, but here updated >> the entries required for Bluetooth node from PMU, not from host to PMU. > > Hm? No, you removed for example enable-gpios, which is input from the > host. Sorry, I don't understand the reason behind this patch and commit > msg does not help me there. > We are migrating to powerseq for the WCN6750. As per Dmitry’s suggestion, we are now using the on-chip PMU, which necessitates the removal of some entries that are not mandatory to avoid binding errors. For example, the enable GPIO is now handled by the PMU with property bt-enable-gpios, as shown in the patch linked below https://lore.kernel.org/linux-arm-msm/20241209103455.9675-3-quic_janathot@quicinc.com/ Thanks, Janakiram
On 12/27/2024 12:35 PM, Krzysztof Kozlowski wrote: > On 26/12/2024 07:11, Janaki Ramaiah Thota wrote: >> >> >> On 12/24/2024 6:57 PM, Krzysztof Kozlowski wrote: >>> On 24/12/2024 12:51, Janaki Ramaiah Thota wrote: >>>> >>>> >>>> On 12/24/2024 2:46 PM, Krzysztof Kozlowski wrote: >>>>> On Mon, Dec 23, 2024 at 07:27:00PM +0530, Janaki Ramaiah Thota wrote: >>>>> >>>>> Subject: everything is an update... say something useful, e.g. use PMU >>>>> abstraction for WCN6750 >>>>> >>>> >>>> Sure will correct it in next patch. >>>> >>>>>> Drop the inputs from the host and instead expect the Bluetooth node to >>>>>> consume the outputs of the internal PMU. >>>>> >>>>> On which device? >>>>> >>>> >>>> It is for BT module wcn6750 attached on qcs6490-rb3gen2 board. >>>> will update same on next commit message. >>>> >>>>> But anyway I have doubts this is correct. enable GPIO is a pin going >>>>> from the host, not from PMU. >>>>> >>>> >>>> Yes you are correct, enable GPIO is out pin of host, but here updated >>>> the entries required for Bluetooth node from PMU, not from host to PMU. >>> >>> Hm? No, you removed for example enable-gpios, which is input from the >>> host. Sorry, I don't understand the reason behind this patch and commit >>> msg does not help me there. >>> >> >> We are migrating to powerseq for the WCN6750. As per Dmitry’s >> suggestion, we are now using the on-chip PMU, which necessitates the >> removal of some entries that are not mandatory to avoid binding errors. >> For example, the enable GPIO is now handled by the PMU with property >> bt-enable-gpios, as shown in the patch linked below >> https://lore.kernel.org/linux-arm-msm/20241209103455.9675-3-quic_janathot@quicinc.com/ > I don't understand why this patch is separate from the others. Entire > context is missing and nothing gets explained in commit msg. > > Best regards, > Krzysztof Thanks for the reply Krzysztof, * Initially sent the below patch which enables Bluetooth for the qcs6490-rb3gen2 board. https://lore.kernel.org/linux-arm-msm/20241009111436.23473-1-quic_janathot@quicinc.com/ * Then Dmitry recommended implementing pwrseq to enable/disable Bluetooth for the wcn6750 Bluetooth module. * Then we sent the below patches with pwrseq in v5: - [PATCH v5 1/4] regulator: dt-bindings: qcom,qca6390-pmu: document wcn6750-pmu - [PATCH v5 2/4] arm64: dts: qcom: qcs6490-rb3gen: add and enable BT node - [PATCH v5 3/4] Bluetooth: hci_qca: use the power sequencer for wcn6750 - [PATCH v5 4/4] power: sequencing: qcom-wcn: add support for the [PATCH v5 1/4] and [PATCH v5 4/4] were reviewed and got merged. [PATCH v5 2/4] and [PATCH v5 3/4] received Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> * But we got the following warning messages for [PATCH v5 2/4] from Rob Herring (Arm) bot: New warnings running 'make CHECK_DTBS=y qcom/qcs6490-rb3gen2.dtb' for 20241209103455.9675-1-quic_janathot@quicinc.com: ``` arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'enable-gpios' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'swctrl-gpios' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'vddio-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'vddbtcxmx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'vddasd-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pinctrl@f100000: Unevaluated properties are not allowed ('qup_uart7_sleep' was unexpected) from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sc7280-pinctrl.yaml# ``` We got these warnings because the binding file `qualcomm-bluetooth.yaml` was not updated as per the new bluetooth node entries in P2, so we removed the entries from the required property for the Bluetooth node and sent it as v6 PATCH-1. We will update the commit message as below in v7: ``` [PATCH v7 1/1] dt-bindings: bluetooth: Utilize PMU abstraction for WCN6750 We are now using the on-chip PMU node for power sequencing to manage the enable/disable functionality of Bluetooth. Consequently, the inputs previously marked as required under the Bluetooth node can be removed. For instance, the enable GPIO is now managed by the PMU node with the property bt-enable-gpios, as shown in the following patch: https://lore.kernel.org/linux-arm-msm/20241209103455.9675-3-quic_janathot@quicinc.com/ ``` Best regards, Janakiram
diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml index 7bb68311c609..6906e1742d6c 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml @@ -154,16 +154,11 @@ allOf: - qcom,wcn6750-bt then: required: - - enable-gpios - - swctrl-gpios - - vddio-supply - vddaon-supply - - vddbtcxmx-supply - vddrfacmn-supply - vddrfa0p8-supply - vddrfa1p7-supply - vddrfa1p2-supply - - vddasd-supply - if: properties: compatible:
Drop the inputs from the host and instead expect the Bluetooth node to consume the outputs of the internal PMU. Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> --- .../bindings/net/bluetooth/qualcomm-bluetooth.yaml | 5 ----- 1 file changed, 5 deletions(-)