| Message ID | 2ffd08092fabaed0bea8b7a5e19e5c9464e76077.1735278513.git.xiaopei01@kylinos.cn |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: typec: ucsi: make yoga_c630_ucsi_ops be static | expand |
On Fri, Dec 27, 2024 at 01:51:51PM +0800, Pei Xiao wrote: > sparse warnings: > drivers/usb/typec/ucsi/ucsi_yoga_c630.c:101:30: sparse: sparse: > symbol 'yoga_c630_ucsi_ops' was not declared. Should it be static? > That's a nice warning message, but doesn't explain what this change is actually doing. Please read the kernel documentation for how to properly write a changelog commit for what needs to go here. thanks, greg k-h
On Fri, Dec 27, 2024 at 01:51:51PM +0800, Pei Xiao wrote: > sparse warnings: > drivers/usb/typec/ucsi/ucsi_yoga_c630.c:101:30: sparse: sparse: > symbol 'yoga_c630_ucsi_ops' was not declared. Should it be static? > > Fixes: 2ea6d07efe53 ("usb: typec: ucsi: add Lenovo Yoga C630 glue driver") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202412102033.J4vZNaaR-lkp@intel.com/ > Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn> > --- > drivers/usb/typec/ucsi/ucsi_yoga_c630.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/drivers/usb/typec/ucsi/ucsi_yoga_c630.c b/drivers/usb/typec/ucsi/ucsi_yoga_c630.c index f3a5e24ea84d..4cae85c0dc12 100644 --- a/drivers/usb/typec/ucsi/ucsi_yoga_c630.c +++ b/drivers/usb/typec/ucsi/ucsi_yoga_c630.c @@ -71,7 +71,7 @@ static int yoga_c630_ucsi_async_control(struct ucsi *ucsi, u64 command) return yoga_c630_ec_ucsi_write(uec->ec, (u8*)&command); } -const struct ucsi_operations yoga_c630_ucsi_ops = { +static const struct ucsi_operations yoga_c630_ucsi_ops = { .read_version = yoga_c630_ucsi_read_version, .read_cci = yoga_c630_ucsi_read_cci, .read_message_in = yoga_c630_ucsi_read_message_in,
sparse warnings: drivers/usb/typec/ucsi/ucsi_yoga_c630.c:101:30: sparse: sparse: symbol 'yoga_c630_ucsi_ops' was not declared. Should it be static? Fixes: 2ea6d07efe53 ("usb: typec: ucsi: add Lenovo Yoga C630 glue driver") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202412102033.J4vZNaaR-lkp@intel.com/ Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn> --- drivers/usb/typec/ucsi/ucsi_yoga_c630.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)