| Message ID | 20250107154755.2037197-1-jon.lin@rock-chips.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: spi: rockchip-sfc: Add rockchip,fspi compatible | expand |
On 07/01/2025 16:47, Jon Lin wrote: > > diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c > index 59de351499a0..88fbde27925e 100644 > --- a/drivers/spi/spi-rockchip-sfc.c > +++ b/drivers/spi/spi-rockchip-sfc.c > @@ -808,6 +808,7 @@ static const struct dev_pm_ops rockchip_sfc_pm_ops = { > }; > > static const struct of_device_id rockchip_sfc_dt_ids[] = { > + { .compatible = "rockchip,fspi"}, > { .compatible = "rockchip,sfc"}, I don't understand why you are adding generic compatible which is not even used. Use proper SoC specific compatibles and fallbacks when applicable (see writing bindings document). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml index ac1503de0478..4d64155d03f8 100644 --- a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml +++ b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml @@ -15,11 +15,15 @@ allOf: properties: compatible: - const: rockchip,sfc + enum: + - rockchip,fspi + - rockchip,sfc + description: The rockchip sfc controller is a standalone IP with version register, and the driver can handle all the feature difference inside the IP depending on the version register. + The rockchip flexible spi controller is the next generation IP of sfc. reg: maxItems: 1
FSPI is an SFC upgrade IP that adds functions such as XIP. Signed-off-by: Jon Lin <jon.lin@rock-chips.com> --- Documentation/devicetree/bindings/spi/rockchip-sfc.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)