diff mbox series

[v2] pinctrl: renesas: rzg2l: Update PFC_MASK to align with RZ/V2H requirements

Message ID 20250110221045.594596-1-prabhakar.mahadev-lad.rj@bp.renesas.com
State New
Headers show
Series [v2] pinctrl: renesas: rzg2l: Update PFC_MASK to align with RZ/V2H requirements | expand

Commit Message

Lad, Prabhakar Jan. 10, 2025, 10:10 p.m. UTC 
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

The PFC_MASK value for the PFC_mx register was previously hardcoded as
`0x07`, which is correct for SoCs in the RZ/G2L family but insufficient
for RZ/V2H and RZ/G3E, where the mask value should be `0x0f`. This
discrepancy caused incorrect PFC register configurations on RZ/V2H and
RZ/G3E SoCs.

On the RZ/G2L, the PFC_mx bitfields are also 4 bits wide, with bit 4
marked as reserved. The reserved bits are documented to read as zero and
be ignored when written. Updating the PFC_MASK definition from `0x07` to
`0x0f` ensures compatibility with both SoC families while maintaining
correct behavior on RZ/G2L.

Fixes: 9bd95ac86e70 ("pinctrl: renesas: rzg2l: Add support for RZ/V2H SoC")
Cc: stable@vger.kernel.org
Reported-by: Hien Huynh <hien.huynh.px@renesas.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1->v2
- Dropped SoC specific configuration
---
 drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Geert Uytterhoeven Jan. 13, 2025, 9:24 a.m. UTC | #1 
On Fri, Jan 10, 2025 at 11:10 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> The PFC_MASK value for the PFC_mx register was previously hardcoded as
> `0x07`, which is correct for SoCs in the RZ/G2L family but insufficient
> for RZ/V2H and RZ/G3E, where the mask value should be `0x0f`. This
> discrepancy caused incorrect PFC register configurations on RZ/V2H and
> RZ/G3E SoCs.
>
> On the RZ/G2L, the PFC_mx bitfields are also 4 bits wide, with bit 4
> marked as reserved. The reserved bits are documented to read as zero and
> be ignored when written. Updating the PFC_MASK definition from `0x07` to
> `0x0f` ensures compatibility with both SoC families while maintaining
> correct behavior on RZ/G2L.
>
> Fixes: 9bd95ac86e70 ("pinctrl: renesas: rzg2l: Add support for RZ/V2H SoC")
> Cc: stable@vger.kernel.org
> Reported-by: Hien Huynh <hien.huynh.px@renesas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2
> - Dropped SoC specific configuration

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-pinctrl for v6.14, as it is a fix.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index ffcc5255724d..e33efd65670f 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -159,7 +159,7 @@ 
 #define PWPR_REGWE_B		BIT(5)	/* OEN Register Write Enable, known only in RZ/V2H(P) */
 
 #define PM_MASK			0x03
-#define PFC_MASK		0x07
+#define PFC_MASK		0x0f
 #define IEN_MASK		0x01
 #define IOLH_MASK		0x03
 #define SR_MASK			0x01