diff mbox series

[v1,1/2] regulator: dt-bindings: Add TI TPS65214 PMIC bindings

Message ID 20250116223740.429515-2-s-ramamoorthy@ti.com
State Superseded
Headers show
Series Add TI TPS65214 PMIC Regulator Support | expand

Commit Message

Shree Ramamoorthy Jan. 16, 2025, 10:37 p.m. UTC
- TPS65214 is a Power Management IC with 3 Buck regulators and 2 LDOs.
- TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs.
- TPS65214's LDO1 maps to TPS65219's LDO3.
- A key difference between TPS65215 & TPS65214 are the LDO current and
  voltage output ranges and the configurable options available.
- The remaining features for both devices are the same.

Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
---
 .../bindings/regulator/ti,tps65219.yaml          | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

Comments

Mark Brown Feb. 3, 2025, 12:40 a.m. UTC | #1
On Thu, Jan 16, 2025 at 04:37:39PM -0600, Shree Ramamoorthy wrote:
> - TPS65214 is a Power Management IC with 3 Buck regulators and 2 LDOs.
> - TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs.
> - TPS65214's LDO1 maps to TPS65219's LDO3.
> - A key difference between TPS65215 & TPS65214 are the LDO current and
>   voltage output ranges and the configurable options available.
> - The remaining features for both devices are the same.
> 
> Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
> ---
>  .../bindings/regulator/ti,tps65219.yaml          | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)

This doesn't apply against current code, please check and resend:

Applying: regulator: dt-bindings: Add TI TPS65214 PMIC bindings
error: sha1 information is lacking or useless (Documentation/devicetree/bindings/regulator/ti,tps65219.yaml).
error: could not build fake ancestor
Patch failed at 0001 regulator: dt-bindings: Add TI TPS65214 PMIC bindings
Shree Ramamoorthy Feb. 4, 2025, 7:08 p.m. UTC | #2
Hi,


On 2/2/25 6:40 PM, Mark Brown wrote:
> On Thu, Jan 16, 2025 at 04:37:39PM -0600, Shree Ramamoorthy wrote:
>> - TPS65214 is a Power Management IC with 3 Buck regulators and 2 LDOs.
>> - TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs.
>> - TPS65214's LDO1 maps to TPS65219's LDO3.
>> - A key difference between TPS65215 & TPS65214 are the LDO current and
>>    voltage output ranges and the configurable options available.
>> - The remaining features for both devices are the same.
>>
>> Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
>> ---
>>   .../bindings/regulator/ti,tps65219.yaml          | 16 +++++++++++++++-
>>   1 file changed, 15 insertions(+), 1 deletion(-)
> This doesn't apply against current code, please check and resend:
>
> Applying: regulator: dt-bindings: Add TI TPS65214 PMIC bindings
> error: sha1 information is lacking or useless (Documentation/devicetree/bindings/regulator/ti,tps65219.yaml).
> error: could not build fake ancestor
> Patch failed at 0001 regulator: dt-bindings: Add TI TPS65214 PMIC bindings

I combined this TPS65214 series with TPS65215: https://lore.kernel.org/all/20250131221139.342967-1-s-ramamoorthy@ti.com/
I will be re-sending the v5 with Krzysztof's feedback added soon. That would be the replacement patch series to try applying.
Thank you for your time!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
index b0d47415bf83..b56e7f8fe88e 100644
--- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
+++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
@@ -4,7 +4,7 @@ 
 $id: http://devicetree.org/schemas/regulator/ti,tps65219.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: TI TPS65215/TPS65219 Power Management Integrated Circuits
+title: TI TPS65214/TPS65215/TPS65219 Power Management Integrated Circuit
 
 maintainers:
   - Jerome Neanne <jerome.neanne@baylibre.com>
@@ -18,9 +18,13 @@  description: |
   TI TPS65215 is a derivative of TPS65219 with 3 Buck regulators, 2 Low
   Drop-out Regulators (LDOs), 1 GPIO, 1 GPO, and power-button.
 
+  TI TPS65214 is a derivative of TPS65219 with 3 Buck regulators, 2 Low
+  Drop-out Regulators (LDOs), 1 GPIO, 1 GPO, and power-button.
+
 properties:
   compatible:
     enum:
+      - ti,tps65214
       - ti,tps65215
       - ti,tps65219
 
@@ -98,6 +102,16 @@  required:
 additionalProperties: false
 
 allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: ti,tps65214
+    then:
+      properties:
+        regulators:
+          patternProperties:
+            "^ldo[3-4]$": false
   - if:
       properties:
         compatible: