diff mbox series

[2/5] leds: leds-st1202: initialize hardware before DT node child operations

Message ID CWLP123MB54732B78DDB3CC67F2544A7AC51B2@CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM
State New
Headers show
Series [1/5] leds: leds-st1202: fix NULL pointer access on race condition | expand

Commit Message

Manuel Fombuena Jan. 17, 2025, 11:40 p.m. UTC 
Arguably, there are more chances of errors occurring during the
initialization of the hardware, so this should complete successfully
before the DT node childreen are initialized.

Signed-off-by: Manuel Fombuena <fombuena@outlook.com>
---
 drivers/leds/leds-st1202.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c
index e894b3f9a0f4..927874f20839 100644
--- a/drivers/leds/leds-st1202.c
+++ b/drivers/leds/leds-st1202.c
@@ -348,11 +348,11 @@  static int st1202_probe(struct i2c_client *client)
 	devm_mutex_init(&client->dev, &chip->lock);
 	chip->client = client;
 
-	ret = st1202_dt_init(chip);
+	ret = st1202_setup(chip);
 	if (ret < 0)
 		return ret;
 
-	ret = st1202_setup(chip);
+	ret = st1202_dt_init(chip);
 	if (ret < 0)
 		return ret;