diff mbox series

[v2,1/3] wifi: cfg80211: Add support to get EMLSR capabilities of non-AP MLD

Message ID 20250117170416.2907530-2-quic_ramess@quicinc.com
State Superseded
Headers show
Series wifi: cfg80211: update EML capabilities of an ML Station | expand

Commit Message

Rameshkumar Sundaram Jan. 17, 2025, 5:04 p.m. UTC 
From: Ramasamy Kaliappan <quic_rkaliapp@quicinc.com>

The Enhanced multi-link single-radio (EMLSR) operation allows a non-AP MLD
with multiple receive chains to listen on one or more EMLSR links when the
corresponding non-AP STA(s) affiliated with the non-AP MLD is (are) in
the awake state. [IEEE 802.11be-2024, (35.3.17 Enhanced multi-link
single-radio (EMLSR) operation)]

An MLD which intends to enable EMLSR operations will set the EML
Capabilities Present subfield to 1 and shall set the EMLSR Support
subfield in the Common Info field of the Basic Multi-Link element to 1 in
all Management frames that include the Basic Multi-Link element except
Authentication frames. EML capabilities contains information such as
EML Transition timeout, Padding delay and Transition delay. These fields
needs to updated to drivers to trigger EMLSR operation and to transmit and
receive initial control frame and data frames.

Add support to receive EML Capabilities subfield that non-AP MLD
advertises during (re)association request and send it to underlying
drivers during ADD/SET station.

Signed-off-by: Ramasamy Kaliappan <quic_rkaliapp@quicinc.com>
Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com>
---
 include/net/cfg80211.h |  5 +++++
 net/wireless/nl80211.c | 12 ++++++++++++
 2 files changed, 17 insertions(+)

Comments

Johannes Berg Feb. 28, 2025, 12:32 p.m. UTC | #1 
On Fri, 2025-01-17 at 22:34 +0530, Rameshkumar Sundaram wrote:
> 
>  include/net/cfg80211.h |  5 +++++
>  net/wireless/nl80211.c | 12 ++++++++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 363d7dd2255a..7a80dbf37881 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -1756,6 +1756,9 @@ struct cfg80211_ttlm_params {
>   * @supported_oper_classes_len: number of supported operating classes
>   * @support_p2p_ps: information if station supports P2P PS mechanism
>   * @airtime_weight: airtime scheduler weight for this station
> + * @eml_cap_present: Specifies if EML capabilities field (@eml_cap) is
> + *	present/updated
> + * @eml_cap: EML capabilities of this station
>   * @link_sta_params: link related params.
>   */
>  struct station_parameters {
> @@ -1780,6 +1783,8 @@ struct station_parameters {
>  	u8 supported_oper_classes_len;
>  	int support_p2p_ps;
>  	u16 airtime_weight;
> +	bool eml_cap_present;
> +	u16 eml_cap;
>  	struct link_station_parameters link_sta_params;
>  };

OK, I get that this is the minimal change that actually makes this work,
but it seems a bit lazy to me. Allow me to explain: You don't actually
_want_ - nor even implement in patch 3 - this changing at any point in
runtime. OTOH, you _do_ need it to change after the station is
allocated, because in auth frame exchange you don't have the information
yet, and that's when the MLD is added.

So I really think this ought to be accompanied with a change to
cfg80211_check_station_change() that disallows changing this while the
station is already associated?

johannes
Rameshkumar Sundaram March 3, 2025, 10:31 a.m. UTC | #2 
On 2/28/2025 6:02 PM, Johannes Berg wrote:
> On Fri, 2025-01-17 at 22:34 +0530, Rameshkumar Sundaram wrote:
>>
>>   include/net/cfg80211.h |  5 +++++
>>   net/wireless/nl80211.c | 12 ++++++++++++
>>   2 files changed, 17 insertions(+)
>>
>> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
>> index 363d7dd2255a..7a80dbf37881 100644
>> --- a/include/net/cfg80211.h
>> +++ b/include/net/cfg80211.h
>> @@ -1756,6 +1756,9 @@ struct cfg80211_ttlm_params {
>>    * @supported_oper_classes_len: number of supported operating classes
>>    * @support_p2p_ps: information if station supports P2P PS mechanism
>>    * @airtime_weight: airtime scheduler weight for this station
>> + * @eml_cap_present: Specifies if EML capabilities field (@eml_cap) is
>> + *	present/updated
>> + * @eml_cap: EML capabilities of this station
>>    * @link_sta_params: link related params.
>>    */
>>   struct station_parameters {
>> @@ -1780,6 +1783,8 @@ struct station_parameters {
>>   	u8 supported_oper_classes_len;
>>   	int support_p2p_ps;
>>   	u16 airtime_weight;
>> +	bool eml_cap_present;
>> +	u16 eml_cap;
>>   	struct link_station_parameters link_sta_params;
>>   };
> 
> OK, I get that this is the minimal change that actually makes this work,
> but it seems a bit lazy to me. Allow me to explain: You don't actually
> _want_ - nor even implement in patch 3 - this changing at any point in
> runtime. OTOH, you _do_ need it to change after the station is
> allocated, because in auth frame exchange you don't have the information
> yet, and that's when the MLD is added.
> 
> So I really think this ought to be accompanied with a change to
> cfg80211_check_station_change() that disallows changing this while the
> station is already associated?
> 

Yes, That's correct thanks for pointing it out, will add changes to 
disallow modification if STA is already associated (i.e. if != 
CFG80211_STA_AP_CLIENT_UNASSOC)

> johannes
>
diff mbox series

Patch

diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 363d7dd2255a..7a80dbf37881 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -1756,6 +1756,9 @@  struct cfg80211_ttlm_params {
  * @supported_oper_classes_len: number of supported operating classes
  * @support_p2p_ps: information if station supports P2P PS mechanism
  * @airtime_weight: airtime scheduler weight for this station
+ * @eml_cap_present: Specifies if EML capabilities field (@eml_cap) is
+ *	present/updated
+ * @eml_cap: EML capabilities of this station
  * @link_sta_params: link related params.
  */
 struct station_parameters {
@@ -1780,6 +1783,8 @@  struct station_parameters {
 	u8 supported_oper_classes_len;
 	int support_p2p_ps;
 	u16 airtime_weight;
+	bool eml_cap_present;
+	u16 eml_cap;
 	struct link_station_parameters link_sta_params;
 };
 
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index d7d3da0f6833..8e5002aaedab 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -833,6 +833,7 @@  static const struct nla_policy nl80211_policy[NUM_NL80211_ATTR] = {
 	[NL80211_ATTR_MLD_ADDR] = NLA_POLICY_EXACT_LEN(ETH_ALEN),
 	[NL80211_ATTR_MLO_SUPPORT] = { .type = NLA_FLAG },
 	[NL80211_ATTR_MAX_NUM_AKM_SUITES] = { .type = NLA_REJECT },
+	[NL80211_ATTR_EML_CAPABILITY] = { .type = NLA_U16 },
 	[NL80211_ATTR_PUNCT_BITMAP] =
 		NLA_POLICY_FULL_RANGE(NLA_U32, &nl80211_punct_bitmap_range),
 
@@ -7457,6 +7458,12 @@  static int nl80211_set_station(struct sk_buff *skb, struct genl_info *info)
 		params.link_sta_params.he_6ghz_capa =
 			nla_data(info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY]);
 
+	if (info->attrs[NL80211_ATTR_EML_CAPABILITY]) {
+		params.eml_cap_present = true;
+		params.eml_cap =
+			nla_get_u16(info->attrs[NL80211_ATTR_EML_CAPABILITY]);
+	}
+
 	if (info->attrs[NL80211_ATTR_AIRTIME_WEIGHT])
 		params.airtime_weight =
 			nla_get_u16(info->attrs[NL80211_ATTR_AIRTIME_WEIGHT]);
@@ -7615,6 +7622,11 @@  static int nl80211_new_station(struct sk_buff *skb, struct genl_info *info)
 		}
 	}
 
+	if (info->attrs[NL80211_ATTR_EML_CAPABILITY]) {
+		params.eml_cap_present = true;
+		params.eml_cap = nla_get_u16(info->attrs[NL80211_ATTR_EML_CAPABILITY]);
+	}
+
 	if (info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY])
 		params.link_sta_params.he_6ghz_capa =
 			nla_data(info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY]);