diff mbox series

[BlueZ,v1,1/2] org.bluez.MediaTransport: Allow Volume property to follow profile range

Message ID 20250122211446.142626-1-luiz.dentz@gmail.com
State Superseded
Headers show
Series [BlueZ,v1,1/2] org.bluez.MediaTransport: Allow Volume property to follow profile range | expand

Commit Message

Luiz Augusto von Dentz Jan. 22, 2025, 9:14 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This makes the Volume property to follow the profile defined range.
---
 doc/org.bluez.MediaTransport.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com Jan. 22, 2025, 10:27 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=927649

---Test result---

Test Summary:
CheckPatch                    PENDING   0.21 seconds
GitLint                       PENDING   0.17 seconds
BuildEll                      PASS      20.29 seconds
BluezMake                     FAIL      1421.52 seconds
MakeCheck                     FAIL      23.80 seconds
MakeDistcheck                 PASS      161.88 seconds
CheckValgrind                 FAIL      157.54 seconds
CheckSmatch                   FAIL      263.22 seconds
bluezmakeextell               FAIL      90.73 seconds
IncrementalBuild              PENDING   0.27 seconds
ScanBuild                     PASS      848.03 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: BluezMake - FAIL
Desc: Build BlueZ
Output:

tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12893:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12893 | int main(int argc, char *argv[])
      |     ^~~~
unit/test-avdtp.c: In function ‘main’:
unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  766 | int main(int argc, char *argv[])
      |     ^~~~
profiles/audio/transport.c:2445:4: error: initialization of ‘uint8_t (*)(struct media_transport *)’ {aka ‘unsigned char (*)(struct media_transport *)’} from incompatible pointer type ‘int8_t (*)(struct media_transport *)’ {aka ‘signed char (*)(struct media_transport *)’} [-Werror=incompatible-pointer-types]
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2406:16: note: in definition of macro ‘TRANSPORT_OPS’
 2406 |  .get_volume = _get_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:4: note: (near initialization for ‘transport_ops[6].get_volume’)
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2406:16: note: in definition of macro ‘TRANSPORT_OPS’
 2406 |  .get_volume = _get_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:31: error: initialization of ‘int (*)(struct media_transport *, uint8_t)’ {aka ‘int (*)(struct media_transport *, unsigned char)’} from incompatible pointer type ‘int (*)(struct media_transport *, int8_t)’ {aka ‘int (*)(struct media_transport *, signed char)’} [-Werror=incompatible-pointer-types]
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2407:16: note: in definition of macro ‘TRANSPORT_OPS’
 2407 |  .set_volume = _set_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:31: note: (near initialization for ‘transport_ops[6].set_volume’)
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2407:16: note: in definition of macro ‘TRANSPORT_OPS’
 2407 |  .set_volume = _set_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
unit/test-avrcp.c: In function ‘main’:
unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  989 | int main(int argc, char *argv[])
      |     ^~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10125: profiles/audio/bluetoothd-transport.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4693: all] Error 2
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:

profiles/audio/transport.c:2445:4: error: initialization of ‘uint8_t (*)(struct media_transport *)’ {aka ‘unsigned char (*)(struct media_transport *)’} from incompatible pointer type ‘int8_t (*)(struct media_transport *)’ {aka ‘signed char (*)(struct media_transport *)’} [-Werror=incompatible-pointer-types]
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2406:16: note: in definition of macro ‘TRANSPORT_OPS’
 2406 |  .get_volume = _get_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:4: note: (near initialization for ‘transport_ops[6].get_volume’)
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2406:16: note: in definition of macro ‘TRANSPORT_OPS’
 2406 |  .get_volume = _get_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:31: error: initialization of ‘int (*)(struct media_transport *, uint8_t)’ {aka ‘int (*)(struct media_transport *, unsigned char)’} from incompatible pointer type ‘int (*)(struct media_transport *, int8_t)’ {aka ‘int (*)(struct media_transport *, signed char)’} [-Werror=incompatible-pointer-types]
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2407:16: note: in definition of macro ‘TRANSPORT_OPS’
 2407 |  .set_volume = _set_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:31: note: (near initialization for ‘transport_ops[6].set_volume’)
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2407:16: note: in definition of macro ‘TRANSPORT_OPS’
 2407 |  .set_volume = _set_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10125: profiles/audio/bluetoothd-transport.o] Error 1
make: *** [Makefile:12344: check] Error 2
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:

tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12893:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12893 | int main(int argc, char *argv[])
      |     ^~~~
profiles/audio/transport.c:2445:4: error: initialization of ‘uint8_t (*)(struct media_transport *)’ {aka ‘unsigned char (*)(struct media_transport *)’} from incompatible pointer type ‘int8_t (*)(struct media_transport *)’ {aka ‘signed char (*)(struct media_transport *)’} [-Werror=incompatible-pointer-types]
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2406:16: note: in definition of macro ‘TRANSPORT_OPS’
 2406 |  .get_volume = _get_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:4: note: (near initialization for ‘transport_ops[6].get_volume’)
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2406:16: note: in definition of macro ‘TRANSPORT_OPS’
 2406 |  .get_volume = _get_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:31: error: initialization of ‘int (*)(struct media_transport *, uint8_t)’ {aka ‘int (*)(struct media_transport *, unsigned char)’} from incompatible pointer type ‘int (*)(struct media_transport *, int8_t)’ {aka ‘int (*)(struct media_transport *, signed char)’} [-Werror=incompatible-pointer-types]
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2407:16: note: in definition of macro ‘TRANSPORT_OPS’
 2407 |  .set_volume = _set_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:31: note: (near initialization for ‘transport_ops[6].set_volume’)
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2407:16: note: in definition of macro ‘TRANSPORT_OPS’
 2407 |  .set_volume = _set_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10125: profiles/audio/bluetoothd-transport.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:12344: check] Error 2
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
src/shared/gatt-server.c:278:25: warning: Variable length array is used.
src/shared/gatt-server.c:618:25: warning: Variable length array is used.
src/shared/gatt-server.c:716:25: warning: Variable length array is used.
src/shared/bap.c:296:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
src/shared/gatt-server.c:278:25: warning: Variable length array is used.
src/shared/gatt-server.c:618:25: warning: Variable length array is used.
src/shared/gatt-server.c:716:25: warning: Variable length array is used.
src/shared/bap.c:296:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
tools/mesh-cfgtest.c:1453:17: warning: unknown escape sequence: '\%'
tools/sco-tester.c: note: in included file:
./lib/bluetooth.h:232:15: warning: array of flexible structures
./lib/bluetooth.h:237:31: warning: array of flexible structures
tools/bneptest.c:634:39: warning: unknown escape sequence: '\%'
tools/seq2bseq.c:57:26: warning: Variable length array is used.
tools/obex-client-tool.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
android/avctp.c:505:34: warning: Variable length array is used.
android/avctp.c:556:34: warning: Variable length array is used.
unit/test-avrcp.c:373:26: warning: Variable length array is used.
unit/test-avrcp.c:398:26: warning: Variable length array is used.
unit/test-avrcp.c:414:24: warning: Variable length array is used.
android/avrcp-lib.c:1085:34: warning: Variable length array is used.
android/avrcp-lib.c:1583:34: warning: Variable length array is used.
android/avrcp-lib.c:1612:34: warning: Variable length array is used.
android/avrcp-lib.c:1638:34: warning: Variable length array is used.
mesh/mesh-io-mgmt.c:523:67: warning: Variable length array is used.
client/display.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
src/shared/gatt-server.c:278:25: warning: Variable length array is used.
src/shared/gatt-server.c:618:25: warning: Variable length array is used.
src/shared/gatt-server.c:716:25: warning: Variable length array is used.
src/shared/bap.c:296:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
monitor/packet.c: note: in included file:
monitor/display.h:82:26: warning: Variable length array is used.
monitor/packet.c:1868:26: warning: Variable length array is used.
monitor/packet.c: note: in included file:
monitor/bt.h:3606:52: warning: array of flexible structures
monitor/bt.h:3594:40: warning: array of flexible structures
monitor/l2cap.c: note: in included file:
monitor/display.h:82:26: warning: Variable length array is used.
monitor/msft.c: note: in included file:
monitor/msft.h:88:44: warning: array of flexible structures
monitor/att.c: note: in included file:
monitor/display.h:82:26: warning: Variable length array is used.
tools/rctest.c:627:33: warning: non-ANSI function declaration of function 'automated_send_recv'
tools/hex2hcd.c:136:26: warning: Variable length array is used.
tools/meshctl.c:324:33: warning: non-ANSI function declaration of function 'forget_mesh_devices'
tools/mesh-gatt/node.c:456:39: warning: non-ANSI function declaration of function 'node_get_local_node'
tools/mesh-gatt/net.c:1239:30: warning: non-ANSI function declaration of function 'get_next_seq'
tools/mesh-gatt/net.c:2193:29: warning: non-ANSI function declaration of function 'net_get_default_ttl'
tools/mesh-gatt/net.c:2207:26: warning: non-ANSI function declaration of function 'net_get_seq_num'
tools/mesh-gatt/prov.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
tools/mesh-gatt/onoff-model.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
ell/log.c:431:65: warning: non-ANSI function declaration of function 'register_debug_section'
ell/log.c:439:68: warning: non-ANSI function declaration of function 'free_debug_sections'
ell/random.c:60:42: warning: non-ANSI function declaration of function 'l_getrandom_is_supported'
ell/cipher.c:660:28: warning: non-ANSI function declaration of function 'init_supported'
ell/checksum.c:372:28: warning: non-ANSI function declaration of function 'init_supported'
ell/checksum.c:434:47: warning: non-ANSI function declaration of function 'l_checksum_cmac_aes_supported'
ell/cipher.c:519:24: warning: Variable length array is used.
ell/cert-crypto.c:36:33: warning: Variable length array is used.
ell/cert-crypto.c:132:36: warning: Variable length array is used.
ell/cert-crypto.c:188:36: warning: Variable length array is used.
ell/cert-crypto.c:241:31: warning: Variable length array is used.
ell/key.c:538:25: warning: Variable length array is used.
ell/dbus-service.c:548:49: warning: non-ANSI function declaration of function '_dbus_object_tree_new'
ell/dbus-filter.c:232:46: warning: Variable length array is used.
ell/tls.c:45:25: warning: Variable length array is used.
ell/tls.c:86:22: warning: Variable length array is used.
ell/tls.c:86:46: warning: Variable length array is used.
ell/tls-suites.c:1078:25: warning: Variable length array is used.
ell/tls-suites.c:1080:34: warning: Variable length array is used.
ell/tls-suites.c:1083:41: warning: Variable length array is used.
ell/tls-suites.c:1132:41: warning: Variable length array is used.
ell/tls.c:1819:26: warning: Variable length array is used.
emulator/btdev.c:448:29: warning: Variable length array is used.
emulator/bthost.c:613:28: warning: Variable length array is used.
emulator/bthost.c:787:28: warning: Variable length array is used.
attrib/gatttool.c:235:23: warning: Variable length array is used.
attrib/interactive.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
attrib/interactive.c:174:27: warning: non-ANSI function declaration of function 'disconnect_io'
attrib/interactive.c:299:23: warning: Variable length array is used.
profiles/sap/server.c: note: in included file:
profiles/sap/sap.h:77:35: warning: array of flexible structures
profiles/audio/transport.c:2445:4: error: initialization of ‘uint8_t (*)(struct media_transport *)’ {aka ‘unsigned char (*)(struct media_transport *)’} from incompatible pointer type ‘int8_t (*)(struct media_transport *)’ {aka ‘signed char (*)(struct media_transport *)’} [-Werror=incompatible-pointer-types]
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2406:16: note: in definition of macro ‘TRANSPORT_OPS’
 2406 |  .get_volume = _get_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:4: note: (near initialization for ‘transport_ops[6].get_volume’)
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2406:16: note: in definition of macro ‘TRANSPORT_OPS’
 2406 |  .get_volume = _get_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:31: error: initialization of ‘int (*)(struct media_transport *, uint8_t)’ {aka ‘int (*)(struct media_transport *, unsigned char)’} from incompatible pointer type ‘int (*)(struct media_transport *, int8_t)’ {aka ‘int (*)(struct media_transport *, signed char)’} [-Werror=incompatible-pointer-types]
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2407:16: note: in definition of macro ‘TRANSPORT_OPS’
 2407 |  .set_volume = _set_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:31: note: (near initialization for ‘transport_ops[6].set_volume’)
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2407:16: note: in definition of macro ‘TRANSPORT_OPS’
 2407 |  .set_volume = _set_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10125: profiles/audio/bluetoothd-transport.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4693: all] Error 2
##############################
Test: bluezmakeextell - FAIL
Desc: Build Bluez with External ELL
Output:

profiles/audio/transport.c:2445:4: error: initialization of ‘uint8_t (*)(struct media_transport *)’ {aka ‘unsigned char (*)(struct media_transport *)’} from incompatible pointer type ‘int8_t (*)(struct media_transport *)’ {aka ‘signed char (*)(struct media_transport *)’} [-Werror=incompatible-pointer-types]
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2406:16: note: in definition of macro ‘TRANSPORT_OPS’
 2406 |  .get_volume = _get_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:4: note: (near initialization for ‘transport_ops[6].get_volume’)
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2406:16: note: in definition of macro ‘TRANSPORT_OPS’
 2406 |  .get_volume = _get_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:31: error: initialization of ‘int (*)(struct media_transport *, uint8_t)’ {aka ‘int (*)(struct media_transport *, unsigned char)’} from incompatible pointer type ‘int (*)(struct media_transport *, int8_t)’ {aka ‘int (*)(struct media_transport *, signed char)’} [-Werror=incompatible-pointer-types]
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2407:16: note: in definition of macro ‘TRANSPORT_OPS’
 2407 |  .set_volume = _set_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
profiles/audio/transport.c:2445:31: note: (near initialization for ‘transport_ops[6].set_volume’)
 2445 |    transport_asha_get_volume, transport_asha_set_volume, \
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/transport.c:2407:16: note: in definition of macro ‘TRANSPORT_OPS’
 2407 |  .set_volume = _set_volume, \
      |                ^~~~~~~~~~~
profiles/audio/transport.c:2472:2: note: in expansion of macro ‘ASHA_OPS’
 2472 |  ASHA_OPS(ASHA_PROFILE_UUID),
      |  ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10125: profiles/audio/bluetoothd-transport.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4693: all] Error 2
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Jan. 23, 2025, 6:40 p.m. UTC | #2
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 22 Jan 2025 16:14:45 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This makes the Volume property to follow the profile defined range.
> ---
>  doc/org.bluez.MediaTransport.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ,v1,1/2] org.bluez.MediaTransport: Allow Volume property to follow profile range
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=43dbd5f7e64c
  - [BlueZ,v1,2/2] vcp: Fix using scaled values for volume
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=1d9a70206e38

You are awesome, thank you!
diff mbox series

Patch

diff --git a/doc/org.bluez.MediaTransport.rst b/doc/org.bluez.MediaTransport.rst
index 78789bc8044a..a4894a413652 100644
--- a/doc/org.bluez.MediaTransport.rst
+++ b/doc/org.bluez.MediaTransport.rst
@@ -128,7 +128,8 @@  uint16 Volume [readwrite, optional]
 	Indicates volume level of the transport, this property is only writeable
 	when the transport was acquired by the sender.
 
-	Possible Values: 0-127
+	Possible Values: 0-127 (A2DP)
+			 0-255 (BAP)
 
 object Endpoint [readonly, optional, experimental]
 ``````````````````````````````````````````````````