diff mbox

[API-NEXT] linux-gen: pool add missing eof for error prints

Message ID 1480605960-11627-1-git-send-email-maxim.uvarov@linaro.org
State Superseded
Headers show

Commit Message

Maxim Uvarov Dec. 1, 2016, 3:26 p.m. UTC
During debug found missing end of lines in debug prints.

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

---
 platform/linux-generic/odp_pool.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

-- 
2.7.1.250.gff4ea60

Comments

Maxim Uvarov Dec. 1, 2016, 3:58 p.m. UTC | #1
On 12/01/16 18:26, Maxim Uvarov wrote:
> During debug found missing end of lines in debug prints.

>

> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

> ---

>   platform/linux-generic/odp_pool.c | 14 +++++++-------

>   1 file changed, 7 insertions(+), 7 deletions(-)

>

> diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c

> index 4be3827..5ae37e1 100644

> --- a/platform/linux-generic/odp_pool.c

> +++ b/platform/linux-generic/odp_pool.c

> @@ -281,11 +281,11 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>   	uint32_t max_len, max_seg_len;

>   	uint32_t ring_size;

>   	int name_len;

> -	const char *postfix = "_uarea";

> +	const char *postfix = "_uarea\n";

opps,  v2.

Maxim.
>   	char uarea_name[ODP_POOL_NAME_LEN + sizeof(postfix)];

>   

>   	if (params == NULL) {

> -		ODP_ERR("No params");

> +		ODP_ERR("No params\n");

>   		return ODP_POOL_INVALID;

>   	}

>   

> @@ -300,7 +300,7 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>   	/* Validate requested buffer alignment */

>   	if (align > ODP_CONFIG_BUFFER_ALIGN_MAX ||

>   	    align != ODP_ALIGN_ROUNDDOWN_POWER_2(align, align)) {

> -		ODP_ERR("Bad align requirement");

> +		ODP_ERR("Bad align requirement\n");

>   		return ODP_POOL_INVALID;

>   	}

>   

> @@ -332,7 +332,7 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>   		break;

>   

>   	default:

> -		ODP_ERR("Bad pool type");

> +		ODP_ERR("Bad pool type\n");

>   		return ODP_POOL_INVALID;

>   	}

>   

> @@ -342,7 +342,7 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>   	pool = reserve_pool();

>   

>   	if (pool == NULL) {

> -		ODP_ERR("No more free pools");

> +		ODP_ERR("No more free pools\n");

>   		return ODP_POOL_INVALID;

>   	}

>   

> @@ -390,7 +390,7 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>   	pool->shm = shm;

>   

>   	if (shm == ODP_SHM_INVALID) {

> -		ODP_ERR("Shm reserve failed");

> +		ODP_ERR("Shm reserve failed\n");

>   		goto error;

>   	}

>   

> @@ -404,7 +404,7 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>   		pool->uarea_shm = shm;

>   

>   		if (shm == ODP_SHM_INVALID) {

> -			ODP_ERR("Shm reserve failed (uarea)");

> +			ODP_ERR("Shm reserve failed (uarea)\n");

>   			goto error;

>   		}

>
diff mbox

Patch

diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c
index 4be3827..5ae37e1 100644
--- a/platform/linux-generic/odp_pool.c
+++ b/platform/linux-generic/odp_pool.c
@@ -281,11 +281,11 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 	uint32_t max_len, max_seg_len;
 	uint32_t ring_size;
 	int name_len;
-	const char *postfix = "_uarea";
+	const char *postfix = "_uarea\n";
 	char uarea_name[ODP_POOL_NAME_LEN + sizeof(postfix)];
 
 	if (params == NULL) {
-		ODP_ERR("No params");
+		ODP_ERR("No params\n");
 		return ODP_POOL_INVALID;
 	}
 
@@ -300,7 +300,7 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 	/* Validate requested buffer alignment */
 	if (align > ODP_CONFIG_BUFFER_ALIGN_MAX ||
 	    align != ODP_ALIGN_ROUNDDOWN_POWER_2(align, align)) {
-		ODP_ERR("Bad align requirement");
+		ODP_ERR("Bad align requirement\n");
 		return ODP_POOL_INVALID;
 	}
 
@@ -332,7 +332,7 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 		break;
 
 	default:
-		ODP_ERR("Bad pool type");
+		ODP_ERR("Bad pool type\n");
 		return ODP_POOL_INVALID;
 	}
 
@@ -342,7 +342,7 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 	pool = reserve_pool();
 
 	if (pool == NULL) {
-		ODP_ERR("No more free pools");
+		ODP_ERR("No more free pools\n");
 		return ODP_POOL_INVALID;
 	}
 
@@ -390,7 +390,7 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 	pool->shm = shm;
 
 	if (shm == ODP_SHM_INVALID) {
-		ODP_ERR("Shm reserve failed");
+		ODP_ERR("Shm reserve failed\n");
 		goto error;
 	}
 
@@ -404,7 +404,7 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 		pool->uarea_shm = shm;
 
 		if (shm == ODP_SHM_INVALID) {
-			ODP_ERR("Shm reserve failed (uarea)");
+			ODP_ERR("Shm reserve failed (uarea)\n");
 			goto error;
 		}