| Message ID | 20250206220940.10553-3-kamal.dasu@broadcom.com |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: sdhci-brcmstb: Add rpmb sharing support | expand |
On 06/02/2025 23:09, Kamal Dasu wrote: > From: Kamal Dasu <kdasu@broadcom.com> > > Introduce emmc flash sharing support using hardware semaphore > and SDIO share register to synchronize between TZOS and linux. > > Signed-off-by: Kamal Dasu <kdasu@broadcom.com> It's RFC, so I assume you do not expect review and then you can skip this and obviously it is also NAK for the patch (so maintainers won't take it). However if you actually expect review, then: > --- > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > index eee6be7a7867..b0ee39aeccb1 100644 > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > @@ -27,15 +27,23 @@ properties: > - const: brcm,sdhci-brcmstb > > reg: > - maxItems: 2 > + minItems: 2 1. Missing constraint 2. Please follow DTS coding style 3. and finally this needs to be tested, so: <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml index eee6be7a7867..b0ee39aeccb1 100644 --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml @@ -27,15 +27,23 @@ properties: - const: brcm,sdhci-brcmstb reg: - maxItems: 2 + minItems: 2 reg-names: items: - const: host - const: cfg + - const: share # Optional reg + - const: mmc_sem # Optional reg + - const: flshr_ipis0 # Optional reg interrupts: - maxItems: 1 + minItems: 1 + + interrupt-names: + items: + - const: SDIO1_0 + - const: recv_ipi0 # Optional interrupt clocks: minItems: 1 @@ -76,6 +84,7 @@ required: - compatible - reg - interrupts + - interrupt-names - clocks - clock-names @@ -111,7 +120,8 @@ examples: supports-cqe; non-removable; bus-width = <0x8>; - interrupts = <0x0 0x27 0x4>; + interrupts-extended = <0x1 0x0 0x1f 0x4 0x18 0x11>; + interrupt-names = "SDIO1_0", "recv_ipi0"; clocks = <&scmi_clk 245>; clock-names = "sw_sdio"; };