| Message ID | 20250209-dw9761dts-v3-1-14d3f00f0585@apitzsch.eu |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/2] dt-bindings: media: i2c: Add DW9719 and DW9761 VCM | expand |
Hi Sakari, Am Montag, dem 10.02.2025 um 09:53 +0000 schrieb Sakari Ailus: > Hi André, > > Thanks for the update. > > On Sun, Feb 09, 2025 at 10:51:57PM +0100, André Apitzsch via B4 Relay > wrote: > > From: André Apitzsch <git@apitzsch.eu> > > > > Document Dongwoon DW9719 and DW9761 VCM devicetree bindings. > > > > Signed-off-by: André Apitzsch <git@apitzsch.eu> > > --- > > .../bindings/media/i2c/dongwoon,dw9719.yaml | 45 > > ++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml > > b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml > > new file mode 100644 > > index > > 0000000000000000000000000000000000000000..b38d22bf09713a7999e1f9ce6 > > 553de7587dbe5d2 > > --- /dev/null > > +++ > > b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml > > @@ -0,0 +1,45 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9719.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Dongwoon Anatech DW9719 Voice Coil Motor (VCM) Controller > > + > > +maintainers: > > + - devicetree@vger.kernel.org > > + > > +description: > > + The Dongwoon DW9719 is a 10-bit digital-to-analog (DAC) > > converter. The DAC > > + is controlled via a 2-wire (I2C-compatible) serial interface. > > + > > +properties: > > + compatible: > > + enum: > > + - dongwoon,dw9719 > > + - dongwoon,dw9761 > > + > > + reg: > > + maxItems: 1 > > + > > + vdd-supply: > > + description: Regulator providing power to the "VDD" pin. > > The driver uses dongwoon,sac-mode and dongwoon,vcm-freq properties. > Could you document them as well, please, including the defaults? Are > the values the same for both chips? > It is difficult to say, because I couldn't find the datasheet for any of the chips. Maybe someone could provide them. Best regards, André > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + camera-lens@c { > > + compatible = "dongwoon,dw9761"; > > + reg = <0x0c>; > > + vdd-supply = <&pm8916_l10>; > > + }; > > + }; > >
diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml new file mode 100644 index 0000000000000000000000000000000000000000..b38d22bf09713a7999e1f9ce6553de7587dbe5d2 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9719.yaml @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9719.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Dongwoon Anatech DW9719 Voice Coil Motor (VCM) Controller + +maintainers: + - devicetree@vger.kernel.org + +description: + The Dongwoon DW9719 is a 10-bit digital-to-analog (DAC) converter. The DAC + is controlled via a 2-wire (I2C-compatible) serial interface. + +properties: + compatible: + enum: + - dongwoon,dw9719 + - dongwoon,dw9761 + + reg: + maxItems: 1 + + vdd-supply: + description: Regulator providing power to the "VDD" pin. + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + camera-lens@c { + compatible = "dongwoon,dw9761"; + reg = <0x0c>; + vdd-supply = <&pm8916_l10>; + }; + };