| Message ID | 20250213203208.93316-1-david@ixit.cz |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: nokia n900: remove useless io-channel-cells property | expand |
Am Thu, 13 Feb 2025 21:32:03 +0100 schrieb David Heidelberg <david@ixit.cz>: > This property is irrelevant for the ad5820 DAC, > the driver nor the hardware indicate use of channel cells. > > Fixes: d510d12f26f4 ("ARM: dts: nokia n900: update dts with camera support") > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > arch/arm/boot/dts/ti/omap/omap3-n900.dts | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
Hi, On Thu, Feb 13, 2025 at 09:32:03PM +0100, David Heidelberg wrote: > This property is irrelevant for the ad5820 DAC, > the driver nor the hardware indicate use of channel cells. > > Fixes: d510d12f26f4 ("ARM: dts: nokia n900: update dts with camera support") > Signed-off-by: David Heidelberg <david@ixit.cz> > --- I certainly don't think this is a fix and probably just stay, see: https://lore.kernel.org/all/ih3ykzxrnpbwg4bvkmpoo2tashcxidir4r4zofhlvrs7udkp7o@6qtqh6wtmkwd/ -- Sebastian > arch/arm/boot/dts/ti/omap/omap3-n900.dts | 2 -- > 1 file changed, 2 deletions(-) > > diff --git ./arch/arm/boot/dts/ti/omap/omap3-n900.dts ./arch/arm/boot/dts/ti/omap/omap3-n900.dts > index 4bde3342bb959..c50ca572d1b9b 100644 > --- ./arch/arm/boot/dts/ti/omap/omap3-n900.dts > +++ ./arch/arm/boot/dts/ti/omap/omap3-n900.dts > @@ -816,8 +816,6 @@ ad5820: dac@c { > reg = <0x0c>; > > VANA-supply = <&vaux4>; > - > - #io-channel-cells = <0>; > }; > }; > > -- > 2.47.2 > >
Hi! > > This property is irrelevant for the ad5820 DAC, > > the driver nor the hardware indicate use of channel cells. > > > > Fixes: d510d12f26f4 ("ARM: dts: nokia n900: update dts with camera support") > > Signed-off-by: David Heidelberg <david@ixit.cz> > > --- > > I certainly don't think this is a fix and probably just stay, see: > > https://lore.kernel.org/all/ih3ykzxrnpbwg4bvkmpoo2tashcxidir4r4zofhlvrs7udkp7o@6qtqh6wtmkwd/ The idea is that we can simplify binding document at that point. Currently we are getting feedback that it is not needed on that side :-( Best regards, Pavel > > @@ -816,8 +816,6 @@ ad5820: dac@c { > > reg = <0x0c>; > > > > VANA-supply = <&vaux4>; > > - > > - #io-channel-cells = <0>; > > }; > > };
David Heidelberg <david@ixit.cz> writes: > This property is irrelevant for the ad5820 DAC, > the driver nor the hardware indicate use of channel cells. > > Fixes: d510d12f26f4 ("ARM: dts: nokia n900: update dts with camera support") > Signed-off-by: David Heidelberg <david@ixit.cz> Queued for v6.16, Thanks, Kevin
diff --git ./arch/arm/boot/dts/ti/omap/omap3-n900.dts ./arch/arm/boot/dts/ti/omap/omap3-n900.dts index 4bde3342bb959..c50ca572d1b9b 100644 --- ./arch/arm/boot/dts/ti/omap/omap3-n900.dts +++ ./arch/arm/boot/dts/ti/omap/omap3-n900.dts @@ -816,8 +816,6 @@ ad5820: dac@c { reg = <0x0c>; VANA-supply = <&vaux4>; - - #io-channel-cells = <0>; }; };
This property is irrelevant for the ad5820 DAC, the driver nor the hardware indicate use of channel cells. Fixes: d510d12f26f4 ("ARM: dts: nokia n900: update dts with camera support") Signed-off-by: David Heidelberg <david@ixit.cz> --- arch/arm/boot/dts/ti/omap/omap3-n900.dts | 2 -- 1 file changed, 2 deletions(-)