| Message ID | 20250214191709.1.I6e9e94dcded65e4a9ed42ad23ca8a5d81f680382@changeid |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: Always allow SCO packets for user channel | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=933983 ---Test result--- Test Summary: CheckPatch PENDING 0.37 seconds GitLint PENDING 0.31 seconds SubjectPrefix PASS 0.06 seconds BuildKernel PASS 24.35 seconds CheckAllWarning PASS 26.71 seconds CheckSparse PASS 30.13 seconds BuildKernel32 PASS 24.04 seconds TestRunnerSetup PASS 427.77 seconds TestRunner_l2cap-tester FAIL 0.09 seconds TestRunner_iso-tester FAIL 0.08 seconds TestRunner_bnep-tester FAIL 0.08 seconds TestRunner_mgmt-tester FAIL 0.08 seconds TestRunner_rfcomm-tester FAIL 0.21 seconds TestRunner_sco-tester FAIL 0.08 seconds TestRunner_ioctl-tester FAIL 0.09 seconds TestRunner_mesh-tester FAIL 0.08 seconds TestRunner_smp-tester FAIL 0.08 seconds TestRunner_userchan-tester FAIL 0.08 seconds IncrementalBuild PENDING 1.00 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: TestRunner_l2cap-tester - FAIL Desc: Run l2cap-tester with test-runner Output: Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu-system-x86_64: CPU model 'host' requires KVM ############################## Test: TestRunner_iso-tester - FAIL Desc: Run iso-tester with test-runner Output: Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu-system-x86_64: CPU model 'host' requires KVM ############################## Test: TestRunner_bnep-tester - FAIL Desc: Run bnep-tester with test-runner Output: Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu-system-x86_64: CPU model 'host' requires KVM ############################## Test: TestRunner_mgmt-tester - FAIL Desc: Run mgmt-tester with test-runner Output: Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu-system-x86_64: CPU model 'host' requires KVM ############################## Test: TestRunner_rfcomm-tester - FAIL Desc: Run rfcomm-tester with test-runner Output: Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu-system-x86_64: CPU model 'host' requires KVM ############################## Test: TestRunner_sco-tester - FAIL Desc: Run sco-tester with test-runner Output: Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu-system-x86_64: CPU model 'host' requires KVM ############################## Test: TestRunner_ioctl-tester - FAIL Desc: Run ioctl-tester with test-runner Output: Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu-system-x86_64: CPU model 'host' requires KVM ############################## Test: TestRunner_mesh-tester - FAIL Desc: Run mesh-tester with test-runner Output: Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu-system-x86_64: CPU model 'host' requires KVM ############################## Test: TestRunner_smp-tester - FAIL Desc: Run smp-tester with test-runner Output: Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu-system-x86_64: CPU model 'host' requires KVM ############################## Test: TestRunner_userchan-tester - FAIL Desc: Run userchan-tester with test-runner Output: Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu-system-x86_64: CPU model 'host' requires KVM ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hi Luiz, On Fri, Feb 14, 2025 at 7:17 PM Hsin-chen Chuang <chharry@google.com> wrote: > > From: Hsin-chen Chuang <chharry@chromium.org> > > The SCO packets from Bluetooth raw socket are now rejected because > hci_conn_num is left 0. This patch allows such the usecase to enable > the userspace SCO support. > > Fixes: b16b327edb4d ("Bluetooth: btusb: add sysfs attribute to control USB alt setting") > Signed-off-by: Hsin-chen Chuang <chharry@chromium.org> > --- > > drivers/bluetooth/btusb.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 1caf7a071a73..de3fa725d210 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -2130,7 +2130,8 @@ static int btusb_send_frame(struct hci_dev *hdev, struct sk_buff *skb) > return submit_or_queue_tx_urb(hdev, urb); > > case HCI_SCODATA_PKT: > - if (hci_conn_num(hdev, SCO_LINK) < 1) > + if (!hci_dev_test_flag(hdev, HCI_USER_CHANNEL) && > + hci_conn_num(hdev, SCO_LINK) < 1) > return -ENODEV; > > urb = alloc_isoc_urb(hdev, skb); > @@ -2604,7 +2605,8 @@ static int btusb_send_frame_intel(struct hci_dev *hdev, struct sk_buff *skb) > return submit_or_queue_tx_urb(hdev, urb); > > case HCI_SCODATA_PKT: > - if (hci_conn_num(hdev, SCO_LINK) < 1) > + if (!hci_dev_test_flag(hdev, HCI_USER_CHANNEL) && > + hci_conn_num(hdev, SCO_LINK) < 1) > return -ENODEV; > > urb = alloc_isoc_urb(hdev, skb); > -- > 2.48.1.601.g30ceb7b040-goog > Friendly ping for review, thanks.
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Fri, 14 Feb 2025 19:17:09 +0800 you wrote: > From: Hsin-chen Chuang <chharry@chromium.org> > > The SCO packets from Bluetooth raw socket are now rejected because > hci_conn_num is left 0. This patch allows such the usecase to enable > the userspace SCO support. > > Fixes: b16b327edb4d ("Bluetooth: btusb: add sysfs attribute to control USB alt setting") > Signed-off-by: Hsin-chen Chuang <chharry@chromium.org> > > [...] Here is the summary with links: - Bluetooth: Always allow SCO packets for user channel https://git.kernel.org/bluetooth/bluetooth-next/c/eafcfcfca97d You are awesome, thank you!
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 1caf7a071a73..de3fa725d210 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -2130,7 +2130,8 @@ static int btusb_send_frame(struct hci_dev *hdev, struct sk_buff *skb) return submit_or_queue_tx_urb(hdev, urb); case HCI_SCODATA_PKT: - if (hci_conn_num(hdev, SCO_LINK) < 1) + if (!hci_dev_test_flag(hdev, HCI_USER_CHANNEL) && + hci_conn_num(hdev, SCO_LINK) < 1) return -ENODEV; urb = alloc_isoc_urb(hdev, skb); @@ -2604,7 +2605,8 @@ static int btusb_send_frame_intel(struct hci_dev *hdev, struct sk_buff *skb) return submit_or_queue_tx_urb(hdev, urb); case HCI_SCODATA_PKT: - if (hci_conn_num(hdev, SCO_LINK) < 1) + if (!hci_dev_test_flag(hdev, HCI_USER_CHANNEL) && + hci_conn_num(hdev, SCO_LINK) < 1) return -ENODEV; urb = alloc_isoc_urb(hdev, skb);